Skip to content

Commit f05fd4c

Browse files
maciejwieczorretmaningomolnar
authored andcommitted
x86/resctrl: Fix remaining kernel-doc warnings
The kernel test robot reported kernel-doc warnings here: arch/x86/kernel/cpu/resctrl/rdtgroup.c:915: warning: Function parameter or member 'of' not described in 'rdt_bit_usage_show' arch/x86/kernel/cpu/resctrl/rdtgroup.c:915: warning: Function parameter or member 'seq' not described in 'rdt_bit_usage_show' arch/x86/kernel/cpu/resctrl/rdtgroup.c:915: warning: Function parameter or member 'v' not described in 'rdt_bit_usage_show' arch/x86/kernel/cpu/resctrl/rdtgroup.c:1144: warning: Function parameter or member 'type' not described in '__rdtgroup_cbm_overlaps' arch/x86/kernel/cpu/resctrl/rdtgroup.c:1224: warning: Function parameter or member 'rdtgrp' not described in 'rdtgroup_mode_test_exclusive' arch/x86/kernel/cpu/resctrl/rdtgroup.c:1261: warning: Function parameter or member 'of' not described in 'rdtgroup_mode_write' arch/x86/kernel/cpu/resctrl/rdtgroup.c:1261: warning: Function parameter or member 'buf' not described in 'rdtgroup_mode_write' arch/x86/kernel/cpu/resctrl/rdtgroup.c:1261: warning: Function parameter or member 'nbytes' not described in 'rdtgroup_mode_write' arch/x86/kernel/cpu/resctrl/rdtgroup.c:1261: warning: Function parameter or member 'off' not described in 'rdtgroup_mode_write' arch/x86/kernel/cpu/resctrl/rdtgroup.c:1370: warning: Function parameter or member 'of' not described in 'rdtgroup_size_show' arch/x86/kernel/cpu/resctrl/rdtgroup.c:1370: warning: Function parameter or member 's' not described in 'rdtgroup_size_show' arch/x86/kernel/cpu/resctrl/rdtgroup.c:1370: warning: Function parameter or member 'v' not described in 'rdtgroup_size_show' The first two functions are missing an argument description while the other three are file callbacks and don't require a kernel-doc comment. Closes: https://lore.kernel.org/oe-kbuild-all/202310070434.mD8eRNAz-lkp@intel.com/ Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com> Signed-off-by: Ingo Molnar <mingo@kernel.org> Cc: Peter Newman <peternewman@google.com> Cc: Borislav Petkov <bp@alien8.de> Cc: Reinette Chatre <reinette.chatre@intel.com> Link: https://lore.kernel.org/r/20231011064843.246592-1-maciej.wieczor-retman@intel.com
1 parent 94f6f05 commit f05fd4c

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

arch/x86/kernel/cpu/resctrl/rdtgroup.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -895,7 +895,7 @@ static int rdt_shareable_bits_show(struct kernfs_open_file *of,
895895
return 0;
896896
}
897897

898-
/**
898+
/*
899899
* rdt_bit_usage_show - Display current usage of resources
900900
*
901901
* A domain is a shared resource that can now be allocated differently. Here
@@ -1123,6 +1123,7 @@ static enum resctrl_conf_type resctrl_peer_type(enum resctrl_conf_type my_type)
11231123
* @d: The domain instance for which @closid is being tested.
11241124
* @cbm: Capacity bitmask being tested.
11251125
* @closid: Intended closid for @cbm.
1126+
* @type: CDP type of @r.
11261127
* @exclusive: Only check if overlaps with exclusive resource groups
11271128
*
11281129
* Checks if provided @cbm intended to be used for @closid on domain
@@ -1209,6 +1210,7 @@ bool rdtgroup_cbm_overlaps(struct resctrl_schema *s, struct rdt_domain *d,
12091210

12101211
/**
12111212
* rdtgroup_mode_test_exclusive - Test if this resource group can be exclusive
1213+
* @rdtgrp: Resource group identified through its closid.
12121214
*
12131215
* An exclusive resource group implies that there should be no sharing of
12141216
* its allocated resources. At the time this group is considered to be
@@ -1251,9 +1253,8 @@ static bool rdtgroup_mode_test_exclusive(struct rdtgroup *rdtgrp)
12511253
return true;
12521254
}
12531255

1254-
/**
1256+
/*
12551257
* rdtgroup_mode_write - Modify the resource group's mode
1256-
*
12571258
*/
12581259
static ssize_t rdtgroup_mode_write(struct kernfs_open_file *of,
12591260
char *buf, size_t nbytes, loff_t off)
@@ -1357,12 +1358,11 @@ unsigned int rdtgroup_cbm_to_size(struct rdt_resource *r,
13571358
return size;
13581359
}
13591360

1360-
/**
1361+
/*
13611362
* rdtgroup_size_show - Display size in bytes of allocated regions
13621363
*
13631364
* The "size" file mirrors the layout of the "schemata" file, printing the
13641365
* size in bytes of each region instead of the capacity bitmask.
1365-
*
13661366
*/
13671367
static int rdtgroup_size_show(struct kernfs_open_file *of,
13681368
struct seq_file *s, void *v)

0 commit comments

Comments
 (0)