Skip to content

Commit f07640f

Browse files
nunojsaalexandrebelloni
authored andcommitted
rtc: max31335: Fix ignored return value in set_alarm
Return the result from regmap_update_bits() instead of ignoring it and always returning 0. Fixes: dedaf03 ("rtc: max31335: add driver support") Signed-off-by: Nuno Sá <nuno.sa@analog.com> Link: https://patch.msgid.link/20251128-max31335-handler-error-v1-1-6b6f7f78dbda@analog.com Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
1 parent d1220e4 commit f07640f

1 file changed

Lines changed: 2 additions & 4 deletions

File tree

drivers/rtc/rtc-max31335.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -391,10 +391,8 @@ static int max31335_set_alarm(struct device *dev, struct rtc_wkalrm *alrm)
391391
if (ret)
392392
return ret;
393393

394-
ret = regmap_update_bits(max31335->regmap, max31335->chip->int_status_reg,
395-
MAX31335_STATUS1_A1F, 0);
396-
397-
return 0;
394+
return regmap_update_bits(max31335->regmap, max31335->chip->int_status_reg,
395+
MAX31335_STATUS1_A1F, 0);
398396
}
399397

400398
static int max31335_alarm_irq_enable(struct device *dev, unsigned int enabled)

0 commit comments

Comments
 (0)