Skip to content

Commit f0cf7ff

Browse files
kwachowsjlawryno
authored andcommitted
accel/ivpu: Check return code of ipc->lock init
Return value of drmm_mutex_init(ipc->lock) was unchecked. Fixes: 5d7422c ("accel/ivpu: Add IPC driver and JSM messages") Cc: <stable@vger.kernel.org> # v6.3+ Signed-off-by: Wachowski, Karol <karol.wachowski@intel.com> Signed-off-by: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com> Reviewed-by: Jeffrey Hugo <quic_jhugo@quicinc.com> Link: https://patchwork.freedesktop.org/patch/msgid/20240402104929.941186-2-jacek.lawrynowicz@linux.intel.com
1 parent 185fdb4 commit f0cf7ff

1 file changed

Lines changed: 6 additions & 2 deletions

File tree

drivers/accel/ivpu/ivpu_ipc.c

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
// SPDX-License-Identifier: GPL-2.0-only
22
/*
3-
* Copyright (C) 2020-2023 Intel Corporation
3+
* Copyright (C) 2020-2024 Intel Corporation
44
*/
55

66
#include <linux/genalloc.h>
@@ -501,7 +501,11 @@ int ivpu_ipc_init(struct ivpu_device *vdev)
501501
spin_lock_init(&ipc->cons_lock);
502502
INIT_LIST_HEAD(&ipc->cons_list);
503503
INIT_LIST_HEAD(&ipc->cb_msg_list);
504-
drmm_mutex_init(&vdev->drm, &ipc->lock);
504+
ret = drmm_mutex_init(&vdev->drm, &ipc->lock);
505+
if (ret) {
506+
ivpu_err(vdev, "Failed to initialize ipc->lock, ret %d\n", ret);
507+
goto err_free_rx;
508+
}
505509
ivpu_ipc_reset(vdev);
506510
return 0;
507511

0 commit comments

Comments
 (0)