Skip to content

Commit f1c6682

Browse files
DispatchCodebroonie
authored andcommitted
regulator: qcomm-labibb: replace use of system_wq with system_dfl_wq
Currently if a user enqueues a work item using schedule_delayed_work() the used wq is "system_wq" (per-cpu wq) while queue_delayed_work() use WORK_CPU_UNBOUND (used when a cpu is not specified). The same applies to schedule_work() that is using system_wq and queue_work(), that makes use again of WORK_CPU_UNBOUND. This lack of consistency cannot be addressed without refactoring the API. This patch continues the effort to refactor worqueue APIs, which has begun with the change introducing new workqueues and a new alloc_workqueue flag: commit 128ea9f ("workqueue: Add system_percpu_wq and system_dfl_wq") commit 930c2ea ("workqueue: Add new WQ_PERCPU flag") This specific workload do not benefit from a per-cpu workqueue, so use the default unbound workqueue (system_dfl_wq) instead. Suggested-by: Tejun Heo <tj@kernel.org> Signed-off-by: Marco Crivellari <marco.crivellari@suse.com> Link: https://patch.msgid.link/20251106145003.245866-1-marco.crivellari@suse.com Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent c22f7a5 commit f1c6682

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

drivers/regulator/qcom-labibb-regulator.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -230,7 +230,7 @@ static void qcom_labibb_ocp_recovery_worker(struct work_struct *work)
230230
return;
231231

232232
reschedule:
233-
mod_delayed_work(system_wq, &vreg->ocp_recovery_work,
233+
mod_delayed_work(system_dfl_wq, &vreg->ocp_recovery_work,
234234
msecs_to_jiffies(OCP_RECOVERY_INTERVAL_MS));
235235
}
236236

@@ -510,7 +510,7 @@ static void qcom_labibb_sc_recovery_worker(struct work_struct *work)
510510
* taking action is not truly urgent anymore.
511511
*/
512512
vreg->sc_count++;
513-
mod_delayed_work(system_wq, &vreg->sc_recovery_work,
513+
mod_delayed_work(system_dfl_wq, &vreg->sc_recovery_work,
514514
msecs_to_jiffies(SC_RECOVERY_INTERVAL_MS));
515515
}
516516

0 commit comments

Comments
 (0)