Skip to content

Commit f1e46e7

Browse files
Aleksandr Mishingregkh
authored andcommitted
ACPI: PMIC: Remove unneeded check in tps68470_pmic_opregion_probe()
[ Upstream commit 07442c4 ] In tps68470_pmic_opregion_probe() pointer 'dev' is compared to NULL which is useless. Fix this issue by removing unneeded check. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: e13452a ("ACPI / PMIC: Add TI PMIC TPS68470 operation region driver") Suggested-by: Andy Shevchenko <andy.shevchenko@gmail.com> Signed-off-by: Aleksandr Mishin <amishin@t-argos.ru> Reviewed-by: Sakari Ailus <sakari.ailus@linux.intel.com> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> Link: https://patch.msgid.link/20240730225339.13165-1-amishin@t-argos.ru [ rjw: Subject edit ] Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent c66f0be commit f1e46e7

1 file changed

Lines changed: 2 additions & 4 deletions

File tree

drivers/acpi/pmic/tps68470_pmic.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -376,10 +376,8 @@ static int tps68470_pmic_opregion_probe(struct platform_device *pdev)
376376
struct tps68470_pmic_opregion *opregion;
377377
acpi_status status;
378378

379-
if (!dev || !tps68470_regmap) {
380-
dev_warn(dev, "dev or regmap is NULL\n");
381-
return -EINVAL;
382-
}
379+
if (!tps68470_regmap)
380+
return dev_err_probe(dev, -EINVAL, "regmap is missing\n");
383381

384382
if (!handle) {
385383
dev_warn(dev, "acpi handle is NULL\n");

0 commit comments

Comments
 (0)