Skip to content

Commit f31e85a

Browse files
Hannes Reineckekeithbusch
authored andcommitted
nvmet: do not return 'reserved' for empty TSAS values
The 'TSAS' value is only defined for TCP and RDMA, but returning 'reserved' for undefined values tricked nvmetcli to try to write 'reserved' when restoring from a config file. This caused an error and the configuration would not be applied. Fixes: 3f12349 ("nvmet: make TCP sectype settable via configfs") Signed-off-by: Hannes Reinecke <hare@kernel.org> Reviewed-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com> Signed-off-by: Keith Busch <kbusch@kernel.org>
1 parent 9570a48 commit f31e85a

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/nvme/target/configfs.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -410,7 +410,7 @@ static ssize_t nvmet_addr_tsas_show(struct config_item *item,
410410
return sprintf(page, "%s\n", nvmet_addr_tsas_rdma[i].name);
411411
}
412412
}
413-
return sprintf(page, "reserved\n");
413+
return sprintf(page, "\n");
414414
}
415415

416416
static ssize_t nvmet_addr_tsas_store(struct config_item *item,

0 commit comments

Comments
 (0)