Skip to content

Commit f5accfd

Browse files
committed
spi: use min_t() to improve code
Merge series from Qianfeng Rong <rongqianfeng@vivo.com>: Use min_t() to reduce the code and improve readability. No functional changes.
2 parents 9fd5f18 + 9017960 commit f5accfd

3 files changed

Lines changed: 11 additions & 16 deletions

File tree

drivers/spi/spi-fsl-lpspi.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
#include <linux/spi/spi.h>
2626
#include <linux/spi/spi_bitbang.h>
2727
#include <linux/types.h>
28+
#include <linux/minmax.h>
2829

2930
#define DRIVER_NAME "fsl_lpspi"
3031

@@ -473,10 +474,9 @@ static int fsl_lpspi_setup_transfer(struct spi_controller *controller,
473474
fsl_lpspi->tx = fsl_lpspi_buf_tx_u32;
474475
}
475476

476-
if (t->len <= fsl_lpspi->txfifosize)
477-
fsl_lpspi->watermark = t->len;
478-
else
479-
fsl_lpspi->watermark = fsl_lpspi->txfifosize;
477+
fsl_lpspi->watermark = min_t(typeof(fsl_lpspi->watermark),
478+
fsl_lpspi->txfifosize,
479+
t->len);
480480

481481
if (fsl_lpspi_can_dma(controller, spi, t))
482482
fsl_lpspi->usedma = true;

drivers/spi/spi-npcm-fiu.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
#include <linux/vmalloc.h>
1414
#include <linux/regmap.h>
1515
#include <linux/of.h>
16+
#include <linux/minmax.h>
1617
#include <linux/spi/spi-mem.h>
1718
#include <linux/mfd/syscon.h>
1819

@@ -498,10 +499,7 @@ static int npcm_fiu_read(struct spi_mem *mem, const struct spi_mem_op *op)
498499

499500
do {
500501
addr = ((u32)op->addr.val + i);
501-
if (currlen < 16)
502-
readlen = currlen;
503-
else
504-
readlen = 16;
502+
readlen = min_t(int, currlen, 16);
505503

506504
buf_ptr = data + i;
507505
ret = npcm_fiu_uma_read(mem, op, addr, true, buf_ptr,

drivers/spi/spi-pl022.c

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@
3333
#include <linux/pm_runtime.h>
3434
#include <linux/of.h>
3535
#include <linux/pinctrl/consumer.h>
36+
#include <linux/minmax.h>
3637

3738
/*
3839
* This macro is used to define some register default values.
@@ -760,10 +761,9 @@ static void setup_dma_scatter(struct pl022 *pl022,
760761
* we just feed in this, else we stuff in as much
761762
* as we can.
762763
*/
763-
if (bytesleft < (PAGE_SIZE - offset_in_page(bufp)))
764-
mapbytes = bytesleft;
765-
else
766-
mapbytes = PAGE_SIZE - offset_in_page(bufp);
764+
mapbytes = min_t(int, bytesleft,
765+
PAGE_SIZE - offset_in_page(bufp));
766+
767767
sg_set_page(sg, virt_to_page(bufp),
768768
mapbytes, offset_in_page(bufp));
769769
bufp += mapbytes;
@@ -775,10 +775,7 @@ static void setup_dma_scatter(struct pl022 *pl022,
775775
} else {
776776
/* Map the dummy buffer on every page */
777777
for_each_sg(sgtab->sgl, sg, sgtab->nents, i) {
778-
if (bytesleft < PAGE_SIZE)
779-
mapbytes = bytesleft;
780-
else
781-
mapbytes = PAGE_SIZE;
778+
mapbytes = min_t(int, bytesleft, PAGE_SIZE);
782779
sg_set_page(sg, virt_to_page(pl022->dummypage),
783780
mapbytes, 0);
784781
bytesleft -= mapbytes;

0 commit comments

Comments
 (0)