Skip to content

Commit f6cc7f1

Browse files
Timur Kristófalexdeucher
authored andcommitted
drm/amd/display: Only poll analog connectors
Analog connectors may be hot-plugged unlike other connector types that don't support HPD. Stop DRM from polling other connector types that don't support HPD, such as eDP, LVDS, etc. These were wrongly polled when analog connector support was added, causing issues with the seamless boot process. Fixes: c4f3f11 ("drm/amd/display: Poll analog connectors (v3)") Signed-off-by: Timur Kristóf <timur.kristof@gmail.com> Reported-by: Matthew Schwartz <matthew.schwartz@linux.dev> Reviewed-by: Mario Limonciello (AMD) <superm1@kernel.org> Reviewed-by: Harry Wentland <harry.wentland@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com> (cherry picked from commit e924c70)
1 parent 82a401c commit f6cc7f1

1 file changed

Lines changed: 8 additions & 2 deletions

File tree

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -915,13 +915,19 @@ void amdgpu_dm_hpd_init(struct amdgpu_device *adev)
915915
struct amdgpu_dm_connector *amdgpu_dm_connector;
916916
const struct dc_link *dc_link;
917917

918-
use_polling |= connector->polled != DRM_CONNECTOR_POLL_HPD;
919-
920918
if (connector->connector_type == DRM_MODE_CONNECTOR_WRITEBACK)
921919
continue;
922920

923921
amdgpu_dm_connector = to_amdgpu_dm_connector(connector);
924922

923+
/*
924+
* Analog connectors may be hot-plugged unlike other connector
925+
* types that don't support HPD. Only poll analog connectors.
926+
*/
927+
use_polling |=
928+
amdgpu_dm_connector->dc_link &&
929+
dc_connector_supports_analog(amdgpu_dm_connector->dc_link->link_id.id);
930+
925931
dc_link = amdgpu_dm_connector->dc_link;
926932

927933
/*

0 commit comments

Comments
 (0)