Skip to content

Commit fb90dca

Browse files
sourabhjainsmpe
authored andcommitted
fadump: reserve param area if below boot_mem_top
The param area is a memory region where the kernel places additional command-line arguments for fadump kernel. Currently, the param memory area is reserved in fadump kernel if it is above boot_mem_top. However, it should be reserved if it is below boot_mem_top because the fadump kernel already reserves memory from boot_mem_top to the end of DRAM. Currently, there is no impact from not reserving param memory if it is below boot_mem_top, as it is not used after the early boot phase of the fadump kernel. However, if this changes in the future, it could lead to issues in the fadump kernel. Fixes: 3416c9d ("powerpc/fadump: pass additional parameters when fadump is active") Acked-by: Hari Bathini <hbathini@linux.ibm.com> Signed-off-by: Sourabh Jain <sourabhjain@linux.ibm.com> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> Link: https://patch.msgid.link/20241107055817.489795-2-sourabhjain@linux.ibm.com
1 parent f4892c6 commit fb90dca

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

arch/powerpc/kernel/fadump.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ void __init fadump_append_bootargs(void)
153153
if (!fw_dump.dump_active || !fw_dump.param_area_supported || !fw_dump.param_area)
154154
return;
155155

156-
if (fw_dump.param_area >= fw_dump.boot_mem_top) {
156+
if (fw_dump.param_area < fw_dump.boot_mem_top) {
157157
if (memblock_reserve(fw_dump.param_area, COMMAND_LINE_SIZE)) {
158158
pr_warn("WARNING: Can't use additional parameters area!\n");
159159
fw_dump.param_area = 0;

0 commit comments

Comments
 (0)