Skip to content

Commit fbcbd66

Browse files
Ziyue Zhangbjorn-helgaas
authored andcommitted
dt-bindings: PCI: qcom,pcie-sa8775p: Document 'link_down' reset
Each PCIe controller on SA8775P includes a 'link_down' reset line in hardware. This patch documents the reset in the device tree binding. The 'link_down' reset is used to forcefully bring down the PCIe link layer, which is useful in scenarios such as link recovery after errors, power management transitions, and hotplug events. Including this reset line improves robustness and provides finer control over PCIe controller behavior. As the 'link_down' reset was omitted in the initial submission, it is now being documented. While this reset is not required for most of the block's basic functionality, and device trees lacking it will continue to function correctly in most cases, it is necessary to ensure maximum robustness when shutting down or recovering the PCIe core. Therefore, its inclusion is justified despite the minor ABI change. Signed-off-by: Ziyue Zhang <ziyue.zhang@oss.qualcomm.com> Signed-off-by: Manivannan Sadhasivam <mani@kernel.org> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> Reviewed-by: Rob Herring (Arm) <robh@kernel.org> Reviewed-by: Johan Hovold <johan+linaro@kernel.org> Link: https://patch.msgid.link/20250718081718.390790-3-ziyue.zhang@oss.qualcomm.com
1 parent 51e78d9 commit fbcbd66

1 file changed

Lines changed: 8 additions & 3 deletions

File tree

Documentation/devicetree/bindings/pci/qcom,pcie-sa8775p.yaml

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -66,11 +66,14 @@ properties:
6666
- const: global
6767

6868
resets:
69-
maxItems: 1
69+
items:
70+
- description: PCIe controller reset
71+
- description: PCIe link down reset
7072

7173
reset-names:
7274
items:
7375
- const: pci
76+
- const: link_down
7477

7578
required:
7679
- interconnects
@@ -166,8 +169,10 @@ examples:
166169
167170
power-domains = <&gcc PCIE_0_GDSC>;
168171
169-
resets = <&gcc GCC_PCIE_0_BCR>;
170-
reset-names = "pci";
172+
resets = <&gcc GCC_PCIE_0_BCR>,
173+
<&gcc GCC_PCIE_0_LINK_DOWN_BCR>;
174+
reset-names = "pci",
175+
"link_down";
171176
172177
perst-gpios = <&tlmm 2 GPIO_ACTIVE_LOW>;
173178
wake-gpios = <&tlmm 0 GPIO_ACTIVE_HIGH>;

0 commit comments

Comments
 (0)