dmaengine: idxd: Fix not releasing workqueue on .release()

vcgomes · gregkh · commit fc34f199eb57 · 2026-04-02T13:25:53.000+02:00
[ Upstream commit 3d33de3 ] The workqueue associated with an DSA/IAA device is not released when the object is freed. Fixes: 47c16ac ("dmaengine: idxd: fix idxd conf_dev 'struct device' lifetime") Reviewed-by: Dave Jiang <dave.jiang@intel.com> Signed-off-by: Vinicius Costa Gomes <vinicius.gomes@intel.com> Link: https://patch.msgid.link/20260121-idxd-fix-flr-on-kernel-queues-v3-v3-7-7ed70658a9d1@intel.com Signed-off-by: Vinod Koul <vkoul@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
diff --git a/drivers/dma/idxd/sysfs.c b/drivers/dma/idxd/sysfs.c
@@ -1812,6 +1812,7 @@ static void idxd_conf_device_release(struct device *dev)
 {
 	struct idxd_device *idxd = confdev_to_idxd(dev);
 
+	destroy_workqueue(idxd->wq);
 	kfree(idxd->groups);
 	bitmap_free(idxd->wq_enable_map);
 	kfree(idxd->wqs);

Original file line number	Diff line number	Diff line change
`@@ -1812,6 +1812,7 @@ static void idxd_conf_device_release(struct device *dev)`
`1812`	`1812`	`{`
`1813`	`1813`	`struct idxd_device *idxd = confdev_to_idxd(dev);`
`1814`	`1814`
	`1815`	`+ destroy_workqueue(idxd->wq);`
`1815`	`1816`	`kfree(idxd->groups);`
`1816`	`1817`	`bitmap_free(idxd->wq_enable_map);`
`1817`	`1818`	`kfree(idxd->wqs);`