LoongArch: KVM: Fix kvm_device leak in kvm_pch_pic_destroy()

JohnsPony · gregkh · commit fc53a66227af · 2026-01-23T11:21:32.000+01:00
commit 1cf342a upstream. In kvm_ioctl_create_device(), kvm_device has allocated memory, kvm_device->destroy() seems to be supposed to free its kvm_device struct, but kvm_pch_pic_destroy() is not currently doing this, that would lead to a memory leak. So, fix it. Cc: stable@vger.kernel.org Reviewed-by: Bibo Mao <maobibo@loongson.cn> Signed-off-by: Qiang Ma <maqianga@uniontech.com> Signed-off-by: Huacai Chen <chenhuacai@loongson.cn> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
diff --git a/arch/loongarch/kvm/intc/pch_pic.c b/arch/loongarch/kvm/intc/pch_pic.c
@@ -475,6 +475,7 @@ static void kvm_pch_pic_destroy(struct kvm_device *dev)
 	/* unregister pch pic device and free it's memory */
 	kvm_io_bus_unregister_dev(kvm, KVM_MMIO_BUS, &s->device);
 	kfree(s);
+	kfree(dev);
 }
 
 static struct kvm_device_ops kvm_pch_pic_dev_ops = {

Original file line number	Diff line number	Diff line change
`@@ -475,6 +475,7 @@ static void kvm_pch_pic_destroy(struct kvm_device *dev)`
`475`	`475`	`/* unregister pch pic device and free it's memory */`
`476`	`476`	`kvm_io_bus_unregister_dev(kvm, KVM_MMIO_BUS, &s->device);`
`477`	`477`	`kfree(s);`
	`478`	`+ kfree(dev);`
`478`	`479`	`}`
`479`	`480`
`480`	`481`	`static struct kvm_device_ops kvm_pch_pic_dev_ops = {`