Skip to content

Commit fccfa64

Browse files
arndbardbiesheuvel
authored andcommitted
efi/capsule-loader: fix incorrect allocation size
gcc-14 notices that the allocation with sizeof(void) on 32-bit architectures is not enough for a 64-bit phys_addr_t: drivers/firmware/efi/capsule-loader.c: In function 'efi_capsule_open': drivers/firmware/efi/capsule-loader.c:295:24: error: allocation of insufficient size '4' for type 'phys_addr_t' {aka 'long long unsigned int'} with size '8' [-Werror=alloc-size] 295 | cap_info->phys = kzalloc(sizeof(void *), GFP_KERNEL); | ^ Use the correct type instead here. Fixes: f24c4d4 ("efi/capsule-loader: Reinstate virtual capsule mapping") Signed-off-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
1 parent 1ad55ce commit fccfa64

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/firmware/efi/capsule-loader.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -292,7 +292,7 @@ static int efi_capsule_open(struct inode *inode, struct file *file)
292292
return -ENOMEM;
293293
}
294294

295-
cap_info->phys = kzalloc(sizeof(void *), GFP_KERNEL);
295+
cap_info->phys = kzalloc(sizeof(phys_addr_t), GFP_KERNEL);
296296
if (!cap_info->phys) {
297297
kfree(cap_info->pages);
298298
kfree(cap_info);

0 commit comments

Comments
 (0)