Skip to content

Commit fd4ed47

Browse files
Leo-YanSuzuki K Poulose
authored andcommitted
coresight: perf: Use %px for printing pointers
Use "%px" to print a pointer, which is better than casting the pointer to unsigned long and printing it with the "%lx" specifier. Note, the printing format will be updated as 64-bit value: # cat /sys/devices/cs_etm/sinks/trbe0 0x000000003744496a This commit dismisses the following smatch warnings: coresight-etm-perf.c:854 etm_perf_sink_name_show() warn: argument 4 to %lx specifier is cast from pointer coresight-etm-perf.c:946 etm_perf_cscfg_event_show() warn: argument 4 to %lx specifier is cast from pointer Signed-off-by: Leo Yan <leo.yan@arm.com> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com> Link: https://lore.kernel.org/r/20250611-arm_cs_fix_smatch_warning_v1-v1-2-02a66c69b604@arm.com
1 parent 3252ee4 commit fd4ed47

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

drivers/hwtracing/coresight/coresight-etm-perf.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -851,7 +851,7 @@ static ssize_t etm_perf_sink_name_show(struct device *dev,
851851
struct dev_ext_attribute *ea;
852852

853853
ea = container_of(dattr, struct dev_ext_attribute, attr);
854-
return scnprintf(buf, PAGE_SIZE, "0x%lx\n", (unsigned long)(ea->var));
854+
return scnprintf(buf, PAGE_SIZE, "0x%px\n", ea->var);
855855
}
856856

857857
static struct dev_ext_attribute *
@@ -943,7 +943,7 @@ static ssize_t etm_perf_cscfg_event_show(struct device *dev,
943943
struct dev_ext_attribute *ea;
944944

945945
ea = container_of(dattr, struct dev_ext_attribute, attr);
946-
return scnprintf(buf, PAGE_SIZE, "configid=0x%lx\n", (unsigned long)(ea->var));
946+
return scnprintf(buf, PAGE_SIZE, "configid=0x%px\n", ea->var);
947947
}
948948

949949
int etm_perf_add_symlink_cscfg(struct device *dev, struct cscfg_config_desc *config_desc)

0 commit comments

Comments
 (0)