Skip to content

Commit 6e141a7

Browse files
committed
Merge pull request #59 from zalak1612/master
ARBSubscriptionList SearchType of "cardExpiringThisMonth" doesn't work
2 parents e25dd60 + c18640f commit 6e141a7

2 files changed

Lines changed: 23 additions & 4 deletions

File tree

src/main/java/net/authorize/api/controller/ARBGetSubscriptionListController.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,7 @@ protected void validateRequest() {
1717

1818
//validate required fields
1919
if ( null == request.getSearchType()) throw new NullPointerException("SearchType cannot be null");
20-
if ( null == request.getPaging()) throw new NullPointerException("Paging cannot be null");
21-
22-
//validate not-required fields
20+
2321
}
2422

2523
@Override

src/test/java/net/authorize/api/controller/test/ArbSubscriptionTest.java

Lines changed: 22 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,8 +108,27 @@ public void testSubscription() throws Exception {
108108
String subscriptionId = createSubscription(merchantAuthenticationType);
109109
getSubscription(merchantAuthenticationType, subscriptionId);
110110
cancelSubscription(merchantAuthenticationType, subscriptionId);
111+
111112
}
112-
113+
114+
115+
/**
116+
* @Zalak
117+
* Repro and fix test for issue - ARBSubscriptionList SearchType of "cardExpiringThisMonth" doesn't work
118+
*/
119+
@Test
120+
public void ShouldReturnSubsciptionsWhenPagingNotPassedTest()
121+
{
122+
ARBGetSubscriptionListRequest getSubscriptionListRequest = new ARBGetSubscriptionListRequest();
123+
getSubscriptionListRequest.setSearchType(ARBGetSubscriptionListSearchTypeEnum.CARD_EXPIRING_THIS_MONTH);
124+
getSubscriptionListRequest.setMerchantAuthentication(merchantAuthenticationType);
125+
ARBGetSubscriptionListController nullController = new ARBGetSubscriptionListController(getSubscriptionListRequest);
126+
Assert.assertNotNull(nullController);
127+
ARBGetSubscriptionListResponse response = executeTestRequestWithSuccess(getSubscriptionListRequest, ARBGetSubscriptionListController.class, environment);
128+
Assert.assertNotNull(response);
129+
130+
}
131+
113132
private ARBGetSubscriptionListRequest setupSubscriptionListRequest(MerchantAuthenticationType merchantAuthentication) {
114133

115134
ARBGetSubscriptionListSorting sorting = new ARBGetSubscriptionListSorting();
@@ -166,4 +185,6 @@ private String createSubscription( MerchantAuthenticationType merchantAuthentica
166185

167186
return createResponse.getSubscriptionId();
168187
}
188+
189+
169190
}

0 commit comments

Comments
 (0)