Address PR review: nullable tool params, fix year, fix Spanish typos

pamelafox · pamelafox · commit 6f2e5a40485d · 2026-04-06T10:14:05.000-07:00
diff --git a/function_calling_call.py b/function_calling_call.py
@@ -44,11 +44,11 @@ def lookup_weather(city_name=None, zip_code=None):
             "type": "object",
             "properties": {
                 "city_name": {
-                    "type": "string",
+                    "type": ["string", "null"],
                     "description": "The city name",
                 },
                 "zip_code": {
-                    "type": "string",
+                    "type": ["string", "null"],
                     "description": "The zip code",
                 },
             },
diff --git a/function_calling_extended.py b/function_calling_extended.py
@@ -48,11 +48,11 @@ def lookup_weather(city_name=None, zip_code=None):
             "type": "object",
             "properties": {
                 "city_name": {
-                    "type": "string",
+                    "type": ["string", "null"],
                     "description": "The city name",
                 },
                 "zip_code": {
-                    "type": "string",
+                    "type": ["string", "null"],
                     "description": "The zip code",
                 },
             },
diff --git a/spanish/chat.py b/spanish/chat.py
@@ -37,5 +37,5 @@
     store=False,
 )
 
-print(f"Repuesta de {API_HOST}: \n")
+print(f"Respuesta de {API_HOST}: \n")
 print(response.output_text)
diff --git a/spanish/few_shot_examples.py b/spanish/few_shot_examples.py
@@ -53,5 +53,5 @@
 )
 
 
-print(f"Repuesta de {API_HOST}: \n")
+print(f"Respuesta de {API_HOST}: \n")
 print(response.output_text)
diff --git a/spanish/function_calling_call.py b/spanish/function_calling_call.py
@@ -44,11 +44,11 @@ def lookup_weather(city_name=None, zip_code=None):
             "type": "object",
             "properties": {
                 "city_name": {
-                    "type": "string",
+                    "type": ["string", "null"],
                     "description": "El nombre de la ciudad",
                 },
                 "zip_code": {
-                    "type": "string",
+                    "type": ["string", "null"],
                     "description": "El código postal",
                 },
             },
diff --git a/spanish/function_calling_extended.py b/spanish/function_calling_extended.py
@@ -48,11 +48,11 @@ def lookup_weather(city_name=None, zip_code=None):
             "type": "object",
             "properties": {
                 "city_name": {
-                    "type": "string",
+                    "type": ["string", "null"],
                     "description": "The city name",
                 },
                 "zip_code": {
-                    "type": "string",
+                    "type": ["string", "null"],
                     "description": "The zip code",
                 },
             },
diff --git a/spanish/rag_csv.py b/spanish/rag_csv.py
@@ -68,5 +68,5 @@
     store=False,
 )
 
-print(f"\nRespuest de {API_HOST}: \n")
+print(f"\nRespuesta de {API_HOST}: \n")
 print(response.output_text)
diff --git a/spanish/structured_outputs_description.py b/spanish/structured_outputs_description.py
@@ -40,14 +40,14 @@ class CalendarEvent(BaseModel):
     input=[
         {
             "role": "system",
-            "content": "Extrae la info del evento. Si no dice el año, asumí que es este año (2025).",
+            "content": "Extrae la info del evento. Si no dice el año, asumí que es este año (2026).",
         },
         {"role": "user", "content": "Alice y Bob van a ir a una feria de ciencias el 1 de abril."},
     ],
     text_format=CalendarEvent,
     store=False,
 )
-CalendarEvent(name="Feria de Ciencias", date="2025-04-01", participants=["Alice", "Bob"])
+
 if completion.output_parsed:
     event = completion.output_parsed
     rich.print(event)
diff --git a/structured_outputs_description.py b/structured_outputs_description.py
@@ -40,14 +40,13 @@ class CalendarEvent(BaseModel):
     input=[
         {
             "role": "system",
-            "content": "Extract the event information. If no year is specified, assume the current year (2025).",
+            "content": "Extract the event information. If no year is specified, assume the current year (2026).",
         },
         {"role": "user", "content": "Alice and Bob are going to a science fair on the 1st of april."},
     ],
     text_format=CalendarEvent,
     store=False,
 )
-CalendarEvent(name="Science Fair", date="2025-04-01", participants=["Alice", "Bob"])
 
 if completion.output_parsed:
     event = completion.output_parsed

Original file line number	Diff line number	Diff line change
`@@ -37,5 +37,5 @@`
`37`	`37`	`store=False,`
`38`	`38`	`)`
`39`	`39`
`40`		`-print(f"Repuesta de {API_HOST}: \n")`
	`40`	`+print(f"Respuesta de {API_HOST}: \n")`
`41`	`41`	`print(response.output_text)`
Original file line number	Diff line number	Diff line change
`@@ -53,5 +53,5 @@`
`53`	`53`	`)`
`54`	`54`
`55`	`55`
`56`		`-print(f"Repuesta de {API_HOST}: \n")`
	`56`	`+print(f"Respuesta de {API_HOST}: \n")`
`57`	`57`	`print(response.output_text)`
Original file line number	Diff line number	Diff line change
`@@ -68,5 +68,5 @@`
`68`	`68`	`store=False,`
`69`	`69`	`)`
`70`	`70`
`71`		`-print(f"\nRespuest de {API_HOST}: \n")`
	`71`	`+print(f"\nRespuesta de {API_HOST}: \n")`
`72`	`72`	`print(response.output_text)`