You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
## Why make this change?
- #3375
- The CLI and the schema have a mismatch in the
`autoentities.<def-name>.template.mcp.dml-tools`, need to ensure that
they are the same.
- #3335
- Using `dab validate` produces the wrong output message.
## What is this change?
For issue #3375:
- We changed the `AutoConfigOption.cs` file so that it uses the proper
name and changed the name of the variable to also match the schema in
the `ConfigGenerator.cs`.
For issue #3335:
- We changed the log message in `MsSqlMetadataProvider.cs` so that it is
easier for the user to understand the error.
## How was this tested?
- [ ] Integration Tests
- [ ] Unit Tests
- [x] Local Testing
The issues were related to mismatches or to the output of log messages
that can only be tested locally.
## Sample Request(s)
dab auto-config <def-name> --template.mcp.dml-tools true/false
dab validate --config test.json
---------
Co-authored-by: Souvik Ghosh <souvikofficial04@gmail.com>
Co-authored-by: Aniruddh Munde <anmunde@microsoft.com>
Copy file name to clipboardExpand all lines: src/Cli/Commands/AutoConfigOptions.cs
+4-4Lines changed: 4 additions & 4 deletions
Original file line number
Diff line number
Diff line change
@@ -24,7 +24,7 @@ public AutoConfigOptions(
24
24
IEnumerable<string>?patternsInclude=null,
25
25
IEnumerable<string>?patternsExclude=null,
26
26
string?patternsName=null,
27
-
string?templateMcpDmlTool=null,
27
+
string?templateMcpDmlTools=null,
28
28
bool?templateRestEnabled=null,
29
29
bool?templateGraphqlEnabled=null,
30
30
bool?templateCacheEnabled=null,
@@ -39,7 +39,7 @@ public AutoConfigOptions(
39
39
PatternsInclude=patternsInclude;
40
40
PatternsExclude=patternsExclude;
41
41
PatternsName=patternsName;
42
-
TemplateMcpDmlTool=templateMcpDmlTool;
42
+
TemplateMcpDmlTools=templateMcpDmlTools;
43
43
TemplateRestEnabled=templateRestEnabled;
44
44
TemplateGraphqlEnabled=templateGraphqlEnabled;
45
45
TemplateCacheEnabled=templateCacheEnabled;
@@ -61,8 +61,8 @@ public AutoConfigOptions(
61
61
[Option("patterns.name",Required=false,HelpText="Interpolation syntax for entity naming (must be unique for each generated entity). Default: '{object}'")]
Copy file name to clipboardExpand all lines: src/Service.Tests/Configuration/ConfigurationTests.cs
+1-1Lines changed: 1 addition & 1 deletion
Original file line number
Diff line number
Diff line change
@@ -5611,7 +5611,7 @@ public async Task TestAutoentitiesAreGeneratedIntoEntities(bool useEntities, int
5611
5611
/// <returns></returns>
5612
5612
[TestCategory(TestCategory.MSSQL)]
5613
5613
[DataTestMethod]
5614
-
[DataRow("publishers","uniqueSingularPublisher","uniquePluralPublishers","/unique/publisher","Entity with name 'publishers' already exists. Cannot create new entity from autoentities definition 'PublisherAutoEntity'.",DisplayName="Autoentities fail due to entity name")]
5614
+
[DataRow("publishers","uniqueSingularPublisher","uniquePluralPublishers","/unique/publisher","Entity 'publishers' conflicts with autoentity pattern 'PublisherAutoEntity'. Use --patterns.exclude to skip it.",DisplayName="Autoentities fail due to entity name")]
5615
5615
[DataRow("UniquePublisher","publishers","uniquePluralPublishers","/unique/publisher","Entity publishers generates queries/mutation that already exist",DisplayName="Autoentities fail due to graphql singular type")]
5616
5616
[DataRow("UniquePublisher","uniqueSingularPublisher","publishers","/unique/publisher","Entity publishers generates queries/mutation that already exist",DisplayName="Autoentities fail due to graphql plural type")]
5617
5617
[DataRow("UniquePublisher","uniqueSingularPublisher","uniquePluralPublishers","/publishers","The rest path: publishers specified for entity: publishers is already used by another entity.",DisplayName="Autoentities fail due to rest path")]
0 commit comments