Misc. updates

Author: mbabker

.php-cs-fixer.php

@@ -4,15 +4,15 @@
     ->setRules([
         '@Symfony' => true,
         '@Symfony:risky' => true,
-        '@PHP82Migration' => true,
-        '@PHP80Migration:risky' => true,
-        '@PHPUnit84Migration:risky' => true,
+        '@PHP83Migration' => true,
+        '@PHP82Migration:risky' => true,
+        '@PHPUnit91Migration:risky' => true,
         'array_syntax' => ['syntax' => 'short'],
         'blank_line_after_opening_tag' => false,
         'fopen_flags' => false,
         'linebreak_after_opening_tag' => false,
         'no_superfluous_phpdoc_tags' => ['remove_inheritdoc' => true],
-        'nullable_type_declaration_for_default_null_value' => ['use_nullable_type_declaration' => true],
+        'nullable_type_declaration_for_default_null_value' => true,
         'php_unit_test_case_static_method_calls' => ['call_type' => 'self'],
         'single_line_empty_body' => true,
     ])

src/BabDevWebSocketBundle.php

@@ -24,6 +24,7 @@ public function build(ContainerBuilder $container): void
         $extension->addAuthenticationProviderFactory(new SessionAuthenticationProviderFactory());
     }
 
+    #[\Override]
     public function getContainerExtension(): ?ExtensionInterface
     {
         if (null === $this->extension) {
@@ -33,6 +34,7 @@ public function getContainerExtension(): ?ExtensionInterface
         return $this->extension ?: null;
     }
 
+    #[\Override]
     public function getPath(): string
     {
         return \dirname(__DIR__);

src/DependencyInjection/BabDevWebSocketExtension.php

@@ -29,11 +29,13 @@ public function addAuthenticationProviderFactory(AuthenticationProviderFactory $
         $this->authenticationProviderFactories[] = $factory;
     }
 
+    #[\Override]
     public function getConfiguration(array $config, ContainerBuilder $container): Configuration
     {
         return new Configuration($this->authenticationProviderFactories);
     }
 
+    #[\Override]
     public function getAlias(): string
     {
         return 'babdev_websocket';

src/Routing/Loader/AttributeLoader.php

@@ -29,6 +29,7 @@ public function __construct(?string $env = null)
      *
      * @throws \InvalidArgumentException When the route can't be parsed
      */
+    #[\Override]
     public function load(mixed $class, ?string $type = null): RouteCollection
     {
         if (!class_exists($class)) {
@@ -118,6 +119,7 @@ protected function configureRoute(Route $route, \ReflectionClass $class, \Reflec
      *
      * @param \ReflectionClass<AsMessageHandler> $class
      */
+    #[\Override]
     protected function getDefaultRouteName(\ReflectionClass $class, ?\ReflectionMethod $method = null): string
     {
         $name = str_replace('\\', '_', $class->name);

tests/Authentication/Provider/SessionAuthenticationProviderTest.php

@@ -16,7 +16,7 @@
 
 final class SessionAuthenticationProviderTest extends TestCase
 {
-    private const FIREWALLS = ['main'];
+    private const array FIREWALLS = ['main'];
 
     private readonly MockObject&TokenStorage $tokenStorage;
 

tests/PeriodicManager/ArrayPeriodicManagerRegistryTest.php

@@ -25,7 +25,7 @@ public function testAddsAndRemovesAManager(): void
 
         $registry->removeManager($manager);
 
-        self::assertCount(0, $registry->getManagers());
+        self::assertEmpty($registry->getManagers());
     }
 
     public function testMultipleManagersWithTheSameNameAreNotAllowed(): void

tests/PeriodicManager/PingDoctrineDBALConnectionsPeriodicManagerTest.php

@@ -18,8 +18,6 @@ final class PingDoctrineDBALConnectionsPeriodicManagerTest extends TestCase
      */
     private readonly array $connections;
 
-    private readonly TestLogger $logger;
-
     private readonly PingDoctrineDBALConnectionsPeriodicManager $manager;
 
     protected function setUp(): void
@@ -30,10 +28,8 @@ protected function setUp(): void
             $this->createMock(Connection::class),
         ];
 
-        $this->logger = new TestLogger();
-
         $this->manager = new PingDoctrineDBALConnectionsPeriodicManager($this->connections);
-        $this->manager->setLogger($this->logger);
+        $this->manager->setLogger(new TestLogger());
     }
 
     protected function tearDown(): void