Drop PHP 8.3

Author: mbabker

.github/workflows/run-tests.yml

@@ -9,12 +9,12 @@ jobs:
     strategy:
       fail-fast: true
       matrix:
-        php: ['8.3', '8.4']
+        php: ['8.4']
         symfony: ['6.4.*', '7.3.*']
         composer-flags: ['--prefer-stable']
         can-fail: [false]
         include:
-          - php: '8.3'
+          - php: '8.4'
             symfony: '6.4.*'
             composer-flags: '--prefer-stable --prefer-lowest'
             can-fail: false

.php-cs-fixer.php

@@ -4,9 +4,9 @@
     ->setRules([
         '@Symfony' => true,
         '@Symfony:risky' => true,
-        '@PHP83Migration' => true,
-        '@PHP82Migration:risky' => true,
-        '@PHPUnit100Migration:risky' => true,
+        '@PHP8x4Migration' => true,
+        '@PHP8x2Migration:risky' => true,
+        '@PHPUnit10x0Migration:risky' => true,
         'array_syntax' => ['syntax' => 'short'],
         'blank_line_after_opening_tag' => false,
         'fopen_flags' => false,

composer.json

@@ -10,7 +10,7 @@
     ],
     "license": "MIT",
     "require": {
-        "php": "8.3.* || 8.4.* || 8.5.*",
+        "php": "8.4.* || 8.5.*",
         "ext-pcntl": "*",
         "babdev/websocket-server": "0.1.*",
         "symfony/config": "^6.4 || ^7.3",

docs/intro.md

@@ -15,4 +15,4 @@ The below table shows the supported PHP and Symfony versions for this bundle.
 
 | Version | Status         | PHP Versions | Symfony Versions |
 |---------|----------------|--------------|------------------|
-| 1.x     | In Development | 8.3-8.5      | 6.4, 7.3         |
+| 1.x     | In Development | 8.4-8.5      | 6.4, 7.3         |

rector.php

@@ -3,7 +3,6 @@
 use Rector\Config\RectorConfig;
 use Rector\Php81\Rector\Array_\FirstClassCallableRector;
 use Rector\PHPUnit\CodeQuality\Rector\Class_\PreferPHPUnitThisCallRector;
-use Rector\Symfony\Set\SymfonySetList;
 
 return RectorConfig::configure()
     ->withPaths([
@@ -34,8 +33,4 @@
         __DIR__.'/phpstan.neon',
     ])
     ->withPhpSets()
-    ->withPreparedSets(codeQuality: true, phpunitCodeQuality: true)
-    ->withSets([
-        SymfonySetList::SYMFONY_64,
-    ])
-    ->withPreparedSets(codeQuality: true);
+    ->withPreparedSets(codeQuality: true, phpunitCodeQuality: true);

tests/Authentication/DefaultAuthenticatorTest.php

@@ -25,7 +25,7 @@ public function testTheAuthenticatorDoesNotAuthenticateAConnectionWhenItHasNoPro
         $tokenStorage->expects(self::never())
             ->method('addToken');
 
-        (new DefaultAuthenticator([], $tokenStorage))->authenticate($connection);
+        new DefaultAuthenticator([], $tokenStorage)->authenticate($connection);
     }
 
     public function testTheAuthenticatorAuthenticatesAConnectionWhenItHasOneProvider(): void
@@ -59,7 +59,7 @@ public function testTheAuthenticatorAuthenticatesAConnectionWhenItHasOneProvider
             ->with($connection)
             ->willReturn($token);
 
-        (new DefaultAuthenticator([$authenticationProvider], $tokenStorage))->authenticate($connection);
+        new DefaultAuthenticator([$authenticationProvider], $tokenStorage)->authenticate($connection);
     }
 
     public function testTheAuthenticatorAuthenticatesAConnectionUsingTheFirstSupportedProvider(): void
@@ -111,6 +111,6 @@ public function testTheAuthenticatorAuthenticatesAConnectionUsingTheFirstSupport
         $authenticationProvider3->expects(self::never())
             ->method('authenticate');
 
-        (new DefaultAuthenticator([$authenticationProvider1, $authenticationProvider2, $authenticationProvider3], $tokenStorage))->authenticate($connection);
+        new DefaultAuthenticator([$authenticationProvider1, $authenticationProvider2, $authenticationProvider3], $tokenStorage)->authenticate($connection);
     }
 }

tests/CacheWarmer/RouterCacheWarmerTest.php

@@ -30,7 +30,7 @@ public function testWarmUpWithNoBuildDir(): void
         self::assertSame([
             UrlGenerator::class,
             UrlMatcher::class,
-        ], (new RouterCacheWarmer($innerCacheWarmer, $cacheFolder))->warmUp($cacheDir, null));
+        ], new RouterCacheWarmer($innerCacheWarmer, $cacheFolder)->warmUp($cacheDir, null));
     }
 
     public function testWarmUpWithBuildDir(): void
@@ -53,6 +53,6 @@ public function testWarmUpWithBuildDir(): void
         self::assertSame([
             UrlGenerator::class,
             UrlMatcher::class,
-        ], (new RouterCacheWarmer($innerCacheWarmer, $cacheFolder))->warmUp($cacheDir, $buildDir));
+        ], new RouterCacheWarmer($innerCacheWarmer, $cacheFolder)->warmUp($cacheDir, $buildDir));
     }
 }

tests/Server/ServiceBasedMiddlewareStackBuilderTest.php

@@ -15,13 +15,13 @@ public function testReturnsInjectedMiddlewareStack(): void
         /** @var MockObject&ServerMiddleware $middleware */
         $middleware = $this->createMock(ServerMiddleware::class);
 
-        self::assertSame($middleware, (new ServiceBasedMiddlewareStackBuilder($middleware))->build());
+        self::assertSame($middleware, new ServiceBasedMiddlewareStackBuilder($middleware)->build());
     }
 
     public function testRaisesAnErrorWhenTheMiddlewareIsNotInjected(): void
     {
         $this->expectException(MiddlewareNotConfigured::class);
 
-        (new ServiceBasedMiddlewareStackBuilder())->build();
+        new ServiceBasedMiddlewareStackBuilder()->build();
     }
 }