You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: README.md
+2-82Lines changed: 2 additions & 82 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -7,86 +7,6 @@ This is the official website of the Programming Club at IIITDM Jabalpur
7
7
- Frontend - React
8
8
- Backend - Express (nodejs)
9
9
10
-
## Fixing issues
10
+
## Want to contribute?
11
11
12
-
### Step 1: Pick an issue
13
-
14
-
After selecting an issue
15
-
16
-
1. Comment on the issue saying that you are working on the issue.
17
-
2. We expect you to discuss the approach by comments.
18
-
3. Updates or progress on the issue would be nice.
19
-
20
-
### Step 2: Follow branch policies
21
-
22
-
1. Create a new branch and switch to it (make sure you are on master before doing this).
23
-
24
-
```
25
-
git branch mybranch
26
-
git checkout mybranch
27
-
```
28
-
29
-
'mybranch' can be replaced by your preferred name for the branch or the issue for which it was created.
30
-
The above two commands are equivalent to the following
31
-
32
-
```
33
-
git checkout -b mybranch
34
-
```
35
-
36
-
2. Make your changes and then execute the tests to make sure you didn't break anything.
37
-
38
-
```
39
-
python3 manage.py test
40
-
```
41
-
42
-
Ensure that you follow [PEP8](https://www.python.org/dev/peps/pep-0008/#descriptive-naming-styles) style guide for python code while naming functions or classes.
43
-
44
-
Then stage them and commit them.
45
-
Check out Chris Beams's guide to writing good commit messages [here](https://chris.beams.io/posts/git-commit/).
46
-
47
-
_A small description of your changes is must in the commit messages._
48
-
49
-
3. After you are done making changes, push the branch to your fork.
50
-
```
51
-
git push -u myfork mybranch
52
-
```
53
-
The **-u** option is required only the first time you push the branch.
54
-
55
-
Make sure your branch is up-to-date with the latest version of the master. Else you are required to do a rebase to place your changes above master branch.
56
-
57
-
### Step 3: Follow Coding policy
58
-
59
-
1. Please help us follow the best practice to make it easy for the reviewer as well as the contributor. We want to focus on the code quality more than on managing pull request ethics.
60
-
2. Single commit per pull request
61
-
3. For writing commit messages please adhere to the Commit style guidelines.
62
-
4. Follow uniform design practices.
63
-
5. The pull request will not get merged until and unless the commits are squashed. In case there are multiple commits on the PR, the commit author needs to squash them and not the maintainers cherrypicking and merging squashes.
64
-
6. If the PR is related to any front end change, please attach relevant screenshots in the pull request description.
65
-
66
-
### Step 4: Submitting a Pull request
67
-
68
-
Once a PR is opened, try and complete it within 2 weeks, or at least stay actively working on it. Inactivity for a long period may necessitate a closure of the PR. As mentioned earlier updates would be nice.
69
-
70
-
### Step 5: Code Review
71
-
72
-
Your code will be reviewed, by :
73
-
74
-
1. Reviewer: A core team member will review your pull request and approve it or he will suggest changes.
75
-
76
-
### Step 6: Help us by reviewing other Pull Requests!
77
-
78
-
If you have the time and the knowledge then you must review other Pull Requests. This would stop Pull Requests from stacking up and will definitely mean your Pull Request would be reviewed faster.
79
-
80
-
**Things to keep in mind while reviewing a Pull Request:**
81
-
82
-
If any of the following questions has a **YES** for an answer then the request shall **NOT** be approved.
83
-
84
-
- Will the referenced issue **NOT** be fixed with the Pull Request?
85
-
- Is the commit message **NOT** good?
86
-
- Are there unnecessary changes?
87
-
- Is a rebase required?
88
-
- Is the fix dirty / hacky?
89
-
90
-
## License
91
-
92
-
This website is licensed under [GPL V3+](https://www.gnu.org/licenses/gpl-3.0.fr.html)
0 commit comments