You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 61bf09e
Browse filesBrowse the repository at this point in the historyBrowse files
The wrapApprove PA-rebuild (the onchain-multisig server-leg approval) failed
verification: verifyMultisigWrapApproveTransaction demanded txParams.wrapParams
(tokenName + amount) — but the PA-rebuild path carries no caller wrapParams (the
PA's buildParams store only the type; the intent's wrapParams live in the
journey). The verify's own doc comment contemplates the skip for the
pendingApproval re-sign paths; the rebuild's merged txParams accidentally
triggered the full check.
Restructure verifyMultisigWrapApproveTransaction to be self-sufficient on the
PA-rebuild path:
- the wrapParams cross-check demand: skipped when txParams.pendingApprovalId is
present (the PA-rebuild)
- the pair resolved from the tx's own calldata: the approve's spender decoded →
the reverse lookup over the registered ERC-7984 pairs on the network (by the
wrapper address → the pair's tokenName)
- the bounded checks preserved: the inner target = the pair's underlying ERC-20,
no native value inside sendMultiSig, the spender = the wrapper, the
prebuild-recipients mirror
- the wrapParams cross-check (the amount vs the intent) runs only on the
direct-sign path where the caller carries the intent
Validated in staging: the wrapApprove PA approval — the rebuild 200, the verify
passed (isPaRebuild: true, hasWrapParams: false), the tx signed, the approval
PUT reached WP and the policy resolved.
Ticket: CHALO-2010
0 commit comments