From f79c67264ad77cb73d8a630e19de32ada5748c1d Mon Sep 17 00:00:00 2001 From: Ravi Hegde Date: Tue, 27 Oct 2026 13:27:37 +0530 Subject: [PATCH] feat(sdk-coin-canton): serialize custodial ledger-time metadata in broadcast transactions Ticket: CHALO-1969 --- modules/sdk-coin-canton/src/lib/iface.ts | 18 ++++++++--- .../src/lib/transaction/transaction.ts | 2 +- modules/sdk-coin-canton/test/unit/canton.ts | 32 +++++++++++++++++++ 3 files changed, 46 insertions(+), 6 deletions(-) diff --git a/modules/sdk-coin-canton/src/lib/iface.ts b/modules/sdk-coin-canton/src/lib/iface.ts index ed7b16f17e..c3acbc4454 100644 --- a/modules/sdk-coin-canton/src/lib/iface.ts +++ b/modules/sdk-coin-canton/src/lib/iface.ts @@ -179,6 +179,17 @@ export interface UTXOInfo { value: string; } +export interface CantonMinLedgerTime { + time: { Empty: Record } | { MinLedgerTimeAbs: { value: string } }; +} + +export interface CantonCustodialTiming { + minLedgerTime: { time: { MinLedgerTimeAbs: { value: string } } }; + broadcastNotBefore: string; + broadcastTarget: string; + broadcastExpiresAt: string; +} + export interface CantonPrepareCommandResponse { preparedTransaction?: string; preparedTransactionHash: string; @@ -186,6 +197,7 @@ export interface CantonPrepareCommandResponse { hashingDetails?: string | null; utxoInfo?: UTXOInfo[]; isOneStepTransfer?: boolean; + custodialTiming?: CantonCustodialTiming; } export interface PreparedParty { @@ -262,11 +274,7 @@ export interface TransactionBroadcastData { }; submissionId: string; hashingSchemeVersion?: string; - minLedgerTime?: { - time: { - Empty: Record; - }; - }; + minLedgerTime?: CantonMinLedgerTime; } export interface CantonOneStepEnablementRequest extends CantonPrepareCommandRequest { diff --git a/modules/sdk-coin-canton/src/lib/transaction/transaction.ts b/modules/sdk-coin-canton/src/lib/transaction/transaction.ts index 7ea5ee7bc7..a0bb08e7cf 100644 --- a/modules/sdk-coin-canton/src/lib/transaction/transaction.ts +++ b/modules/sdk-coin-canton/src/lib/transaction/transaction.ts @@ -157,7 +157,7 @@ export class Transaction extends BaseTransaction { }, submissionId: this.id, hashingSchemeVersion: HASHING_SCHEME_VERSION, - minLedgerTime: { + minLedgerTime: this._prepareCommand.custodialTiming?.minLedgerTime ?? { time: { Empty: {}, }, diff --git a/modules/sdk-coin-canton/test/unit/canton.ts b/modules/sdk-coin-canton/test/unit/canton.ts index b28fdb34a4..4d4545d583 100644 --- a/modules/sdk-coin-canton/test/unit/canton.ts +++ b/modules/sdk-coin-canton/test/unit/canton.ts @@ -1,3 +1,4 @@ +import assert from 'assert'; import 'should'; import { BitGoAPI } from '@bitgo/sdk-api'; import { TestBitGo, TestBitGoAPI } from '@bitgo/sdk-test'; @@ -81,6 +82,37 @@ describe('Canton coin:', function () { }); }); +describe('Canton custodial timing serialization:', function () { + it('serializes and round-trips absolute minLedgerTime metadata', function () { + const timing = { + minLedgerTime: { + time: { MinLedgerTimeAbs: { value: '2026-10-27T12:10:00.000Z' } }, + }, + broadcastNotBefore: '2026-10-27T12:09:00.000Z', + broadcastTarget: '2026-10-27T12:09:30.000Z', + broadcastExpiresAt: '2026-10-27T12:11:00.000Z', + }; + const tx = new Transaction(coins.get('tcanton')); + tx.id = 'custodial-accept-command'; + tx.transactionType = TransactionType.OneStepPreApproval; + tx.prepareCommand = { + ...OneStepPreApprovalPrepareResponse, + custodialTiming: timing, + }; + + const serialized = tx.toBroadcastFormat(); + const payload = JSON.parse(Buffer.from(serialized, 'base64').toString('utf8')); + assert.deepStrictEqual(payload.minLedgerTime, timing.minLedgerTime); + assert.deepStrictEqual(payload.prepareCommandResponse.custodialTiming, timing); + + const parsed = new Transaction(coins.get('tcanton')); + parsed.fromRawTransaction(serialized); + assert.deepStrictEqual(parsed.prepareCommand.custodialTiming, timing); + const roundTrip = JSON.parse(Buffer.from(parsed.toBroadcastFormat(), 'base64').toString('utf8')); + assert.deepStrictEqual(roundTrip.minLedgerTime, timing.minLedgerTime); + }); +}); + describe('Canton verifyTransaction:', function () { let bitgo: TestBitGoAPI; let basecoin: Canton;