Add tests and test aux files, fix the README and fix jsoncoonfigparser

Author: BrunoSilvaAndrade

README.md

@@ -66,7 +66,12 @@ except ConfigException as e:
 
 #to access your config you need just:
 logging.getLogger(__name__)
-logging.basicConfig(format=config.core.logging.format, datefmt=config.core.logging.datefmt, level=20)# look this, at this point I'm already using the config variable
+
+logging.basicConfig(
+    format=config.core.logging.format, #look this, at this point I'm already using the config variable
+    datefmt=config.core.logging.datefmt, #here again
+    level=20
+)
 
 #the list of object example:
 

config.json

@@ -0,0 +1,8 @@
+{
+    "core":{
+        "logging":{
+            "format": "format",
+            "datefmt": "datefmt"
+        }
+    }
+}

jsonconfigparser.py

@@ -6,29 +6,36 @@ class Config(object):
 
     __instance = None
 
-    def __new__(cls,schema:dict = None, path_file:str = "config.json"):
-        if cls.__instance is None:
+    def __new__(cls, schema:dict = None, path_file:str = "config.json"):
+        if cls.__instance is None or schema is not None:
             cls.__create_new_instace(schema, path_file)
         return cls.__instance
 
     @classmethod
-    def __create_new_instace(cls,schema:dict, path_file:str):
-        if not path.isfile(path_file):
-            raise ConfigException("Wasn't possible find the config file: {}".format(path_file))
-        
-        with  open(path_file, "r") as f:
-            file_buff = f.read()
-            f.close()
+    def __create_new_instace(cls, schema, path_file:str):
+        if type(schema) is not dict:
+            raise ConfigError("The first config's element should be a Map")
+
+        file_buff = cls.__get_file_buff(path_file)
 
         try:
             config = Schema(schema).validate(json.loads(file_buff))
-            if type(config) is not dict:
-                raise ConfigException("The first config's element should be a Map")
             cls.__instance = cls.__dict_2_obj(config)
         except json.JSONDecodeError:
-            raise ConfigException("Wasn't possible to decode the json file:{}".format(path_file))
+            raise ConfigFileDecodeError("Wasn't possible to decode the json file:{}".format(path_file))
         except SchemaError as e:
-            raise ConfigException(str(e))
+            raise ConfigFileModelError(str(e))
+
+    @classmethod
+    def __get_file_buff(cls, path_file:str):
+        if not path.isfile(path_file):
+            raise ConfigFileNotFoundError("Wasn't find the config file: {}".format(path_file))
+
+        try:
+            with  open(path_file, "r") as f:
+                return f.read()
+        except Exception as e:
+            raise 
 
     @classmethod
     def __dict_2_obj(cls, data:any):
@@ -50,6 +57,21 @@ def __dict_2_obj(cls, data:any):
         else:
             return data
 
-class ConfigException(Exception):
-    def __init__(self, *args, **kwargs):
-        super().__init__(*args, **kwargs)
+
+class ConfigError(Exception):
+    pass
+
+class ConfigFileModelError(ConfigError):
+    pass
+
+class ConfigFileDecodeError(ConfigError):
+    pass
+
+class ConfigSchemaModelError(ConfigError):
+    pass
+
+class ConfigFileOpenReadError(ConfigError):
+    pass
+
+class ConfigFileNotFoundError(ConfigError):
+    pass

schema_config_test.py

@@ -0,0 +1,8 @@
+SIMPLE_SCHEMA_CONFIG = {
+    "core":{
+        "logging":{
+            "format": str,
+            "datefmt": str
+        }
+    }
+}

test_jsonconfigparser.py

@@ -0,0 +1,22 @@
+import unittest
+from jsonconfigparser import *
+from schema_config_test import SIMPLE_SCHEMA_CONFIG
+
+
+class ConfigTestCase(unittest.TestCase):
+
+    def test_config_without_file(self):
+        self.assertRaises(ConfigFileNotFoundError, Config, SIMPLE_SCHEMA_CONFIG, "some_non_exists_file.json")
+
+    def test_config_with_wrong_json_model(self):
+        self.assertRaises(ConfigFileModelError, Config, SIMPLE_SCHEMA_CONFIG, "wrong_model.json")
+
+    def test_to_access_attr_from_config(self):
+        config = Config(SIMPLE_SCHEMA_CONFIG)
+        self.assertEqual(config.core.logging.format, "format")
+        self.assertEqual(config.core.logging.datefmt, "datefmt")
+
+    def test_access_fake_attr(self):
+        config = Config(SIMPLE_SCHEMA_CONFIG)
+        self.assertRaises(AttributeError, lambda:config.fake_attr)
+

wrong_model.json

@@ -0,0 +1,8 @@
+{
+    "core":{
+        "logging":{
+            "format": 1,
+            "datefmt": ""
+        }
+    }
+}