Skip to content

Commit f1d4066

Browse files
committed
perf: filter application
1 parent 679eacf commit f1d4066

1 file changed

Lines changed: 1 addition & 4 deletions

File tree

src/context/filterContext.tsx

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,6 @@ export const FilterProvider: React.FC<FilterProviderProps> = ({ children, subjec
169169
semester: string[],
170170
anskey: boolean,
171171
) => {
172-
// Update URL for bookmarking/sharing (use replace to avoid navigation/re-fetch)
173172
let pushContent = "/catalogue";
174173
if (subject) pushContent += `?subject=${encodeURIComponent(subject)}`;
175174
if (exams.length > 0)
@@ -184,17 +183,15 @@ export const FilterProvider: React.FC<FilterProviderProps> = ({ children, subjec
184183
pushContent += `&semester=${encodeURIComponent(semester.join(","))}`;
185184
if (anskey) pushContent += "&answerkey=true";
186185

187-
// Use replace instead of push to avoid triggering navigation/re-render
188186
router.replace(pushContent, { scroll: false });
189187

190-
// Update filter state (filtering happens in useEffect in CatalogueContent)
191188
setSelectedExams(exams);
192189
setSelectedSlots(slots);
193190
setSelectedYears(years);
194191
setSelectedCampuses(campus);
195192
setSelectedSemesters(semester);
196193
setSelectedAnswerKeyIncluded(anskey);
197-
setCurrentPage(1); // Reset to first page when filters change
194+
setCurrentPage(1);
198195
},
199196
[router, subject, setSelectedExams, setSelectedSlots, setSelectedYears, setSelectedCampuses, setSelectedSemesters, setSelectedAnswerKeyIncluded, setCurrentPage],
200197
);

0 commit comments

Comments
 (0)