Streamlined UI getting rid of the notifications popover in favor of the notification overlay UI previously just used for temporary notifications.

Author: austincondiff

CodeEdit.xcodeproj/project.pbxproj

@@ -4471,7 +4471,6 @@
 				6C578D8729CD345900DC73B2 /* ExtensionSceneView.swift in Sources */,
 				617DB3D02C25AFAE00B58BFE /* TaskNotificationHandler.swift in Sources */,
 				77EF6C052C57DE4B00984B69 /* URL+ResouceValues.swift in Sources */,
-				B68DE5E72D5A7D62009A43EF /* NotificationBannerEnvironment.swift in Sources */,
 				B640A9A129E2188F00715F20 /* View+NavigationBarBackButtonVisible.swift in Sources */,
 				587B9E7929301D8F00AC7927 /* GitHubIssueRouter.swift in Sources */,
 				B67700F92D2A2662004FD61F /* WorkspacePanelView.swift in Sources */,

CodeEdit/Features/InspectorArea/FileInspector/FileInspectorView.swift

@@ -59,6 +59,33 @@ struct FileInspectorView: View {
                         widthOptions
                         wrapLinesToggle
                     }
+                    Section("Test Notifications") {
+                        Button("Add Test Notification") {
+                            NotificationManager.shared.post(
+                                iconSymbol: "bell.badge.fill",
+                                iconColor: .red,
+                                title: "Test Notification",
+                                description: "This is a test notification",
+                                actionButtonTitle: "Action",
+                                action: {
+                                    print("Test notification action triggered")
+                                }
+                            )
+                        }
+                        Button("Add Sticky Notification") {
+                            NotificationManager.shared.post(
+                                iconSymbol: "pin.fill",
+                                iconColor: .orange,
+                                title: "Sticky Notification",
+                                description: "This notification will stay until dismissed",
+                                actionButtonTitle: "Acknowledge",
+                                action: {
+                                    print("Sticky notification acknowledged")
+                                },
+                                isSticky: true
+                            )
+                        }
+                    }
                 }
             } else {
                 NoSelectionInspectorView()

CodeEdit/Features/Notifications/NotificationManager.swift

@@ -22,9 +22,34 @@ final class NotificationManager: NSObject, ObservableObject {
     @Published private(set) var notifications: [CENotification] = []
 
     private var isAppActive: Bool = true
-    private var hiddenStickyNotifications: [CENotification] = []
-    private var hiddenNonStickyNotifications: [CENotification] = []
-    private var dismissedNotificationIds: Set<UUID> = [] // Track dismissed notifications
+
+    /// Whether notifications were manually shown via toolbar
+    @Published private(set) var isManuallyShown: Bool = false
+
+    /// Set of hidden notification IDs
+    private var hiddenNotificationIds: Set<UUID> = []
+
+    /// Whether any non-sticky notifications are currently hidden
+    private var hasHiddenNotifications: Bool {
+        activeNotifications.contains { notification in
+            !notification.isSticky && !isNotificationVisible(notification)
+        }
+    }
+
+    /// Whether a notification should be visible in the overlay
+    func isNotificationVisible(_ notification: CENotification) -> Bool {
+        if notification.isBeingDismissed {
+            return true // Always show notifications being dismissed
+        }
+        if notification.isSticky {
+            return true // Always show sticky notifications
+        }
+        if isManuallyShown {
+            return true // Show all notifications when manually shown
+        }
+        // Otherwise, show if not hidden and has active timer
+        return !hiddenNotificationIds.contains(notification.id) && timers[notification.id] != nil
+    }
 
     /// Number of unread notifications
     var unreadCount: Int {

CodeEdit/Features/Notifications/Views/NotificationBannerEnvironment.swift

@@ -17,6 +17,8 @@ struct NotificationBannerView: View {
     @Environment(\.colorScheme)
     private var colorScheme
 
+    @ObservedObject private var notificationManager = NotificationManager.shared
+
     let notification: CENotification
     let onDismiss: () -> Void
     let onAction: () -> Void

CodeEdit/Features/Notifications/Views/NotificationBannerView.swift

@@ -13,34 +13,73 @@ struct NotificationOverlayView: View {
 
     @ObservedObject private var notificationManager = NotificationManager.shared
 
-    @Namespace private var animation
+    // ID for the top anchor
+    private let topID = "top"
 
-    var body: some View {
-        VStack(spacing: 10) {
+    // Fixed width for notifications
+    private let notificationWidth: CGFloat = 320 // 300 + 10 padding on each side
+
+    var notifications: some View {
+        VStack(spacing: 8) {
             ForEach(notificationManager.activeNotifications, id: \.id) { notification in
                 if controlActiveState == .active || controlActiveState == .key {
                     NotificationBannerView(
                         notification: notification,
-                        namespace: animation,
                         onDismiss: {
                             notificationManager.dismissNotification(notification)
                         },
                         onAction: {
                             notification.action()
                             notificationManager.dismissNotification(notification)
+                            // Only hide if manually shown
+                            if notificationManager.isManuallyShown {
+                                notificationManager.toggleNotificationsVisibility()
+                            }
                         }
                     )
-                    .environment(\.isOverlay, true)
-                    .transition(
-                        .asymmetric(
-                            insertion: .opacity.combined(with: .move(edge: .bottom)),
-                            removal: .opacity.combined(with: .move(edge: .top))
-                        )
-                    )
+                    .transition(.asymmetric(
+                        insertion: .move(edge: .trailing),
+                        removal: .opacity
+                    ))
+                }
+            }
+        }
+        .padding(10)
+    }
+
+    var body: some View {
+        ViewThatFits(in: .vertical) {
+            notifications
+                .border(.red)
+            GeometryReader { geometry in
+                HStack {
+                    Spacer() // Push content to trailing edge
+                    ScrollViewReader { proxy in
+                        ScrollView(.vertical, showsIndicators: false) {
+                            VStack(spacing: 0) {
+                                // Invisible anchor view at the top to scroll back to when closed
+                                Color.clear.frame(height: 0).id(topID)
+                                notifications
+                            }
+                            .padding(.bottom, 30) // Account for the status bar
+                        }
+                        .frame(width: notificationWidth)
+                        .frame(maxHeight: geometry.size.height)
+                        .scrollDisabled(!notificationManager.isManuallyShown)
+                        .onChange(of: notificationManager.isManuallyShown) { isShown in
+                            if !isShown {
+                                // Delay scroll animation until after notifications are hidden
+                                DispatchQueue.main.asyncAfter(deadline: .now() + 0.3) {
+                                    withAnimation(.easeOut(duration: 0.3)) {
+                                        proxy.scrollTo(topID, anchor: .top)
+                                    }
+                                }
+                            }
+                        }
+                    }
                 }
+                .animation(.easeInOut(duration: 0.3), value: notificationManager.activeNotifications)
             }
         }
-        .padding(8)
-        .animation(.easeInOut(duration: 0.2), value: notificationManager.activeNotifications)
     }
 }