Fixed animation glitch when taking action on a notification while notification panel is presented. Removed notification tests and made the notification test in the dev inspector more configurable.

Author: austincondiff

CodeEdit/AppDelegate.swift

@@ -26,21 +26,6 @@ final class AppDelegate: NSObject, NSApplicationDelegate, ObservableObject {
 
         NSApp.closeWindow(.welcome, .about)
 
-        // Add test notification
-        DispatchQueue.main.asyncAfter(deadline: .now() + 5.0) {
-            NotificationManager.shared.post(
-                iconText: "👋",
-                iconTextColor: .white,
-                iconColor: .indigo,
-                title: "Welcome to CodeEdit",
-                description: "This is a test notification to demonstrate the notification system.",
-                actionButtonTitle: "Learn More...",
-                action: {
-                    print("Action button clicked!")
-                }
-            )
-        }
-
         DispatchQueue.main.async {
             var needToHandleOpen = true
 

CodeEdit/Features/InspectorArea/FileInspector/FileInspectorView.swift

@@ -59,71 +59,6 @@ struct FileInspectorView: View {
                         widthOptions
                         wrapLinesToggle
                     }
-                    Section("Test Notifications") {
-                        Button("Add Notification") {
-                            let (iconSymbol, iconColor) = randomSymbolAndColor()
-                            NotificationManager.shared.post(
-                                iconSymbol: iconSymbol,
-                                iconColor: iconColor,
-                                title: "Test Notification",
-                                description: "This is a test notification.",
-                                actionButtonTitle: "Action",
-                                action: {
-                                    print("Test notification action triggered")
-                                }
-                            )
-                        }
-                        Button("Add Sticky Notification") {
-                            NotificationManager.shared.post(
-                                iconSymbol: "pin.fill",
-                                iconColor: .orange,
-                                title: "Sticky Notification",
-                                description: "This notification will stay until dismissed.",
-                                actionButtonTitle: "Acknowledge",
-                                action: {
-                                    print("Sticky notification acknowledged")
-                                },
-                                isSticky: true
-                            )
-                        }
-                        Button("Add Image Notification") {
-                            NotificationManager.shared.post(
-                                iconImage: randomImage(),
-                                title: "Test Notification with Image",
-                                description: "This is a test notification with a custom image.",
-                                actionButtonTitle: "Action",
-                                action: {
-                                    print("Test notification action triggered")
-                                }
-                            )
-                        }
-                        Button("Add Text Notification") {
-                            NotificationManager.shared.post(
-                                iconText: randomLetter(),
-                                iconTextColor: .white,
-                                iconColor: randomColor(),
-                                title: "Text Notification",
-                                description: "This is a test notification with text.",
-                                actionButtonTitle: "Acknowledge",
-                                action: {
-                                    print("Test notification action triggered")
-                                }
-                            )
-                        }
-                        Button("Add Emoji Notification") {
-                            NotificationManager.shared.post(
-                                iconText: randomEmoji(),
-                                iconTextColor: .white,
-                                iconColor: randomColor(),
-                                title: "Emoji Notification",
-                                description: "This is a test notification with an emoji.",
-                                actionButtonTitle: "Acknowledge",
-                                action: {
-                                    print("Test notification action triggered")
-                                }
-                            )
-                        }
-                    }
                 }
             } else {
                 NoSelectionInspectorView()
@@ -146,62 +81,6 @@ struct FileInspectorView: View {
         }
     }
 
-    func randomColor() -> Color {
-        let colors: [Color] = [
-            .red, .orange, .yellow, .green, .mint, .cyan,
-            .teal, .blue, .indigo, .purple, .pink, .gray
-        ]
-        return colors.randomElement() ?? .black
-    }
-
-    func randomSymbolAndColor() -> (String, Color) {
-        let symbols: [(String, Color)] = [
-            ("bell.fill", .red),
-            ("bell.badge.fill", .red),
-            ("exclamationmark.triangle.fill", .orange),
-            ("info.circle.fill", .blue),
-            ("checkmark.seal.fill", .green),
-            ("xmark.octagon.fill", .red),
-            ("bubble.left.fill", .teal),
-            ("envelope.fill", .blue),
-            ("phone.fill", .green),
-            ("megaphone.fill", .pink),
-            ("clock.fill", .gray),
-            ("calendar", .red),
-            ("flag.fill", .green),
-            ("bookmark.fill", .orange),
-            ("bolt.fill", .indigo),
-            ("shield.lefthalf.fill", .red),
-            ("gift.fill", .purple),
-            ("heart.fill", .pink),
-            ("star.fill", .orange),
-            ("curlybraces", .cyan),
-        ]
-        return symbols.randomElement() ?? ("bell.fill", .red)
-    }
-
-    func randomEmoji() -> String {
-        let emoji: [String] = [
-            "🔔", "🚨", "⚠️", "👋", "😍", "😎", "😘", "😜", "😝", "😀", "😁",
-            "😂", "🤣", "😃", "😄", "😅", "😆", "😇", "😉", "😊", "😋", "😌"
-        ]
-        return emoji.randomElement() ?? "🔔"
-    }
-
-    func randomImage() -> Image {
-        let images: [Image] = [
-            Image("GitHubIcon"),
-            Image("BitBucketIcon"),
-            Image("GitLabIcon")
-        ]
-        return images.randomElement() ?? Image("GitHubIcon")
-    }
-
-    func randomLetter() -> String {
-        let letters = "ABCDEFGHIJKLMNOPQRSTUVWXYZ".map { String($0) }
-        return letters.randomElement() ?? "A"
-    }
-
     @ViewBuilder private var fileNameField: some View {
         @State var isValid: Bool = true
 

CodeEdit/Features/Notifications/ViewModels/NotificationOverlayViewModel.swift

@@ -181,14 +181,21 @@ final class NotificationOverlayViewModel: ObservableObject {
     }
 
     /// Dismisses a specific notification
-    func dismissNotification(_ notification: CENotification) {
+    func dismissNotification(_ notification: CENotification, disableAnimation: Bool = false) {
         // Clean up timers
         timers[notification.id]?.invalidate()
         timers[notification.id] = nil
         hiddenNotificationIds.remove(notification.id)
 
         // Mark as being dismissed for animation
         if let index = activeNotifications.firstIndex(where: { $0.id == notification.id }) {
+            if disableAnimation {
+                self.activeNotifications.removeAll(where: { $0.id == notification.id })
+                NotificationManager.shared.markAsRead(notification)
+                NotificationManager.shared.dismissNotification(notification)
+                return
+            }
+
             var dismissingNotification = activeNotifications[index]
             dismissingNotification.isBeingDismissed = true
             activeNotifications[index] = dismissingNotification

CodeEdit/Features/Notifications/Views/NotificationOverlayView.swift

@@ -46,9 +46,11 @@ struct NotificationOverlayView: View {
                     },
                     onAction: {
                         notification.action()
-                        workspace.notificationOverlay.dismissNotification(notification)
                         if workspace.notificationOverlay.isManuallyShown {
                             workspace.notificationOverlay.toggleNotificationsVisibility()
+                            workspace.notificationOverlay.dismissNotification(notification, disableAnimation: true)
+                        } else {
+                            workspace.notificationOverlay.dismissNotification(notification)
                         }
                     }
                 )