From 5913263151130957a25b90ba59b582aec2b8ef9a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Thomas=20M=C3=BCller?=
 <1005065+DeepDiver1975@users.noreply.github.com>
Date: Thu, 27 Aug 2026 21:42:07 +0200
Subject: [PATCH] fix(views): unify Funkrufname fields to AutoCompleteBox
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Roles (Funktionen add-row + transfer panel) and Scba (Atemschutz) had
Funkrufname as a bare ComboBox with no PlaceholderText, rendering as a blank
box with only a dropdown arrow. Meanwhile ETB, the operator's own call-sign
field, and Forces' Funkrufname already use AutoCompleteBox, since a call
sign might not be in Stammdaten yet (mutual aid, ad-hoc units) and the field
must stay enterable. Convert the three remaining ComboBox instances to the
same free-text-with-suggestions AutoCompleteBox pattern, with a "z. B. ..."
placeholder like every other input field. NewCallSign/TransferCallSign were
already plain string properties, so this is a XAML-only change.

Closes #92

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EgFDVXVsJVKJAw1fxBETFR
Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
---
 src/LageBuch.App.Shared/Views/RolesView.axaml | 16 ++++++++++++++--
 src/LageBuch.App.Shared/Views/ScbaView.axaml  | 10 ++++++++--
 2 files changed, 22 insertions(+), 4 deletions(-)

diff --git a/src/LageBuch.App.Shared/Views/RolesView.axaml b/src/LageBuch.App.Shared/Views/RolesView.axaml
index b3ddfc8..cc44f9a 100644
--- a/src/LageBuch.App.Shared/Views/RolesView.axaml
+++ b/src/LageBuch.App.Shared/Views/RolesView.axaml
@@ -43,8 +43,15 @@
                    PlaceholderText="{x:Static md:AnonymizedExampleData.SectionPlaceholder}"
                    Text="{Binding NewSection}" />
         </HeaderedContentControl>
+        <!-- Suggestion list, not a closed set: an ad-hoc or mutual-aid call sign must stay
+             enterable, so this is an AutoCompleteBox rather than a ComboBox (#92). -->
         <HeaderedContentControl Classes="field" Header="FUNKRUFNAME">
-          <ComboBox Width="150" ItemsSource="{Binding CallSignOptions}" SelectedItem="{Binding NewCallSign}" />
+          <AutoCompleteBox Width="150"
+                           PlaceholderText="{x:Static md:AnonymizedExampleData.CallSignPlaceholder}"
+                           ItemsSource="{Binding CallSignOptions}"
+                           FilterMode="ContainsOrdinal"
+                           MinimumPrefixLength="0"
+                           Text="{Binding NewCallSign}" />
         </HeaderedContentControl>
         <HeaderedContentControl Classes="field" Header="HANDYNUMMER">
           <TextBox x:Name="PhoneBox" Width="150"
@@ -83,7 +90,12 @@
                              b:EnterSubmit.Command="{Binding ConfirmTransferCommand}" />
           </HeaderedContentControl>
           <HeaderedContentControl Classes="field" Header="FUNKRUFNAME">
-            <ComboBox x:Name="TransferCallSignBox" Width="150" ItemsSource="{Binding CallSignOptions}" SelectedItem="{Binding TransferCallSign}" />
+            <AutoCompleteBox x:Name="TransferCallSignBox" Width="150"
+                             PlaceholderText="{x:Static md:AnonymizedExampleData.SecondCallSignPlaceholder}"
+                             ItemsSource="{Binding CallSignOptions}"
+                             FilterMode="ContainsOrdinal"
+                             MinimumPrefixLength="0"
+                             Text="{Binding TransferCallSign}" />
           </HeaderedContentControl>
           <HeaderedContentControl Classes="field" Header="HANDYNUMMER">
             <TextBox x:Name="TransferPhoneBox" Width="150"
diff --git a/src/LageBuch.App.Shared/Views/ScbaView.axaml b/src/LageBuch.App.Shared/Views/ScbaView.axaml
index 9361001..5131153 100644
--- a/src/LageBuch.App.Shared/Views/ScbaView.axaml
+++ b/src/LageBuch.App.Shared/Views/ScbaView.axaml
@@ -70,9 +70,15 @@
                            Text="{Binding NewZweiterTruppmann}"
                            b:EnterSubmit.Command="{Binding AddTruppCommand}" />
         </HeaderedContentControl>
+        <!-- Suggestion list, not a closed set: an ad-hoc or mutual-aid call sign must stay
+             enterable, so this is an AutoCompleteBox rather than a ComboBox (#92). -->
         <HeaderedContentControl Classes="field" Header="FUNKRUFNAME">
-          <ComboBox Width="140" ItemsSource="{Binding CallSignOptions}"
-                    SelectedItem="{Binding NewCallSign}" />
+          <AutoCompleteBox Width="140"
+                           PlaceholderText="{x:Static md:AnonymizedExampleData.CallSignPlaceholder}"
+                           ItemsSource="{Binding CallSignOptions}"
+                           FilterMode="ContainsOrdinal"
+                           MinimumPrefixLength="0"
+                           Text="{Binding NewCallSign}" />
         </HeaderedContentControl>
         <HeaderedContentControl Classes="field" Header="EINSATZZEIT">
           <StackPanel Orientation="Horizontal" Spacing="6">