From 5c5e63d08d8436d2b3b862eb9e2b4e565573e3eb Mon Sep 17 00:00:00 2001 From: JanefrancessC Date: Wed, 1 Jul 2026 16:40:54 +0100 Subject: [PATCH] feat: optimise code with precomputing --- .../common_prefix/common_prefix.py | 16 +++++++++++----- .../count_letters/count_letters.py | 10 ++++------ 2 files changed, 15 insertions(+), 11 deletions(-) diff --git a/Sprint-2/improve_with_precomputing/common_prefix/common_prefix.py b/Sprint-2/improve_with_precomputing/common_prefix/common_prefix.py index f4839e7..7d8b318 100644 --- a/Sprint-2/improve_with_precomputing/common_prefix/common_prefix.py +++ b/Sprint-2/improve_with_precomputing/common_prefix/common_prefix.py @@ -7,12 +7,18 @@ def find_longest_common_prefix(strings: List[str]): In the event that an empty list, a list containing one string, or a list of strings with no common prefixes is passed, the empty string will be returned. """ + + if len(strings) < 2: + return "" + + strings = sorted(strings) + longest = "" - for string_index, string in enumerate(strings): - for other_string in strings[string_index+1:]: - common = find_common_prefix(string, other_string) - if len(common) > len(longest): - longest = common + + for i in range(len(strings) - 1): + common = find_common_prefix(strings[i], strings[i + 1]) + if len(common) > len(longest): + longest = common return longest diff --git a/Sprint-2/improve_with_precomputing/count_letters/count_letters.py b/Sprint-2/improve_with_precomputing/count_letters/count_letters.py index 62c3ec0..d8030a3 100644 --- a/Sprint-2/improve_with_precomputing/count_letters/count_letters.py +++ b/Sprint-2/improve_with_precomputing/count_letters/count_letters.py @@ -2,13 +2,11 @@ def count_letters(s: str) -> int: """ count_letters returns the number of letters which only occur in upper case in the passed string. """ + letters = set(s) only_upper = set() + for letter in s: - if is_upper_case(letter): - if letter.lower() not in s: + if letter.isupper(): + if letter.lower() not in letters: only_upper.add(letter) return len(only_upper) - - -def is_upper_case(letter: str) -> bool: - return letter == letter.upper()