add validation and tests historical passwords and more other tests

Author: tomdu3

Sprint-3/4-stretch/password-validator.js

@@ -7,13 +7,14 @@ function passwordValidator(password) {
         - Have at least one of the following non-alphanumeric symbols: ("!", "#", "$", "%", ".", "*", "&")
         - Must not be any previous password in the passwords array. 
   */
-
+  const passwords = ["pa$$w0rd", "Qwerty1#", "Adm1n2#", "$3cr4t"];
   if (
     password.length < 5 ||
     !/[A-Z]/.test(password) ||
     !/[a-z]/.test(password) ||
     !/[0-9]/.test(password) ||
-    !/[!#\$%\.\*&]/.test(password)
+    !/[!#\$%\.\*&]/.test(password) ||
+    passwords.includes(password)
   ) {
     return false;
   }

Sprint-3/4-stretch/password-validator.test.js

@@ -24,6 +24,15 @@ test("password has at least 5 characters", () => {
   expect(result).toEqual(true);
 });
 
+test("password with less than 5 characters is invalid", () => {
+  // Arrange
+  const password = "1Aa%";
+  // Act
+  const result = isValidPassword(password);
+  // Assert
+  expect(result).toEqual(false);
+});
+
 test("password has at least one English uppercase letter (A-Z)", () => {
   // Arrange
   const password = "1234bA$";
@@ -33,6 +42,15 @@ test("password has at least one English uppercase letter (A-Z)", () => {
   expect(result).toEqual(true);
 });
 
+test("password with no uppercase letters is invalid", () => {
+  // Arrange
+  const password = "1234ab$";
+  // Act
+  const result = isValidPassword(password);
+  // Assert
+  expect(result).toEqual(false);
+});
+
 test("password has at least one English lowercase letter (a-z)", () => {
   // Arrange
   const password = "1234Aa%";
@@ -42,6 +60,15 @@ test("password has at least one English lowercase letter (a-z)", () => {
   expect(result).toEqual(true);
 });
 
+test("password with no lowercase letters is invalid", () => {
+  // Arrange
+  const password = "1234AB$";
+  // Act
+  const result = isValidPassword(password);
+  // Assert
+  expect(result).toEqual(false);
+});
+
 test("password has at least one number (0-9)", () => {
   // Arrange
   const password = "1234Aa&";
@@ -51,6 +78,15 @@ test("password has at least one number (0-9)", () => {
   expect(result).toEqual(true);
 });
 
+test("password with no numbers is invalid", () => {
+  // Arrange
+  const password = "passWord!";
+  // Act
+  const result = isValidPassword(password);
+  // Assert
+  expect(result).toEqual(false);
+});
+
 test("password has at least one non-alphanumeric symbol: (!, #, $, %, ., *, &)", () => {
   // Arrange
   const password = "1234aA#";
@@ -59,3 +95,21 @@ test("password has at least one non-alphanumeric symbol: (!, #, $, %, ., *, &)",
   // Assert
   expect(result).toEqual(true);
 });
+
+test("must not be any previous password in the passwords array.", () => {
+  // Arrange
+  const password = "pas$W0rd";
+  // Act
+  const result = isValidPassword(password);
+  // Assert
+  expect(result).toEqual(true);
+});
+
+test("previous passwords in the passwords array are invalid", () => {
+  // Arrange
+  const password = "Qwerty1#";
+  // Act
+  const result = isValidPassword(password);
+  // Assert
+  expect(result).toEqual(false);
+});