made several improvements to the code in Sprint-1, including fixing errors and improving clarity

Author: Yonatanteklemariam

Sprint-1/1-key-exercises/2-initials.js

@@ -8,5 +8,3 @@ let lastName = "Johnson";
 let initials = `${firstName[0]}${middleName[0]}${lastName[0]}`;
 
 console.log(initials);
-
-// https://www.google.com/search?q=get+first+character+of+string+mdn

Sprint-1/2-mandatory-errors/0.js

@@ -1,3 +1,3 @@
-This is just an instruction for the first activity - but it is just for human consumption
-We don't want the computer to run these 2 lines - how can we solve this problem?
-// by adding a comment symbol in front of the lines, so that the computer ignores them when running the code.
+//This is just an instruction for the first activity - but it is just for human consumption
+// We don't want the computer to run these 2 lines - how can we solve this problem?
+// by adding a comment symbol in front of the lines, so that the computer ignores them when running the code.

Sprint-1/2-mandatory-errors/1.js

@@ -1,7 +1,7 @@
 // trying to create an age variable and then reassign the value by 1
 
-const age = 33;
+/* const age = 33;
 age = age + 1; // this line will cause an error because age is declared as constant and cannot be reassigned.
-
+*/
 let age = 33;
 age += 1; // this line will work because age is declared as a variable and can be reassigned.

Sprint-1/2-mandatory-errors/3.js

@@ -12,6 +12,6 @@ const last4Digits = `${cardNumber.slice(-4)}`;
 // Consider: Why does it give this error? Is this what I predicted? If not, what's different?
 // At first I thought the error would be that last4Digits is not defined, but I learned that the error is actually because the slice method is being called on a number, which doesn't have that method.
 // Then try updating the expression last4Digits is assigned to, in order to get the correct value
-const last4Digits = cardNumber.toString().slice(-4); // first option
-const last4Digits = String(cardNumber).slice(-4); // second option
-const last4Digits = `${cardNumber}`.slice(-4); // third option
+const last4Digits = cardNumber.toString().slice(-4); // as slice is a string method, we need to convert the number to a string so that we can use the slice method on it. This can be done by using the toString() method or by using String(cardNumber) or by using template literals as shown in the code snippet
+const last4Digits = String(cardNumber).slice(-4);
+const last4Digits = `${cardNumber}`.slice(-4);

Sprint-1/2-mandatory-errors/4.js

@@ -1,2 +1,4 @@
-const 12HourClockTime = "8:53pm"; // this will throw an error because the variable name started with a number where it shouldn't be.
-const 24hourClockTime = "20:53"; // the same happens here as well.
+// const 12HourClockTime = "8:53pm"; // this will throw an error because the variable name started with a number where it shouldn't be.
+//const 24hourClockTime = "20:53"; // the same happens here as well.
+const hourClockTime12 = "8:53pm"; // this will work because the variable name starts with a letter and not a number.
+const hourClockTime24 = "20:53"; // this will work as well because the variable name starts with a letter and not a number.

Sprint-1/3-mandatory-interpret/2-time-format.js

@@ -1,13 +1,11 @@
-const movieLength = 8784; // length of movie in seconds
-
-const remainingSeconds = movieLength % 60;
-const totalMinutes = (movieLength - remainingSeconds) / 60;
-
-const remainingMinutes = totalMinutes % 60;
-const totalHours = (totalMinutes - remainingMinutes) / 60;
-
-const result = `${totalHours}:${remainingMinutes}:${remainingSeconds}`;
-console.log(result);
+function clockFormatter(movieLength) {
+  const remainingSeconds = movieLength % 60;
+  const totalMinutes = (movieLength - remainingSeconds) / 60;
+  const remainingMinutes = totalMinutes % 60;
+  const totalHours = (totalMinutes - remainingMinutes) / 60;
+  const result = `${totalHours}:${remainingMinutes}:${remainingSeconds}`;
+  return result;
+}
 
 // For the piece of code above, read the code and then answer the following questions
 
@@ -20,15 +18,20 @@ console.log(result);
 // c) Using documentation, explain what the expression movieLength % 60 represents
 // https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Arithmetic_Operators
 /* movieLength % 60 represents the remaining seconds when the movie length of 8784 is divided by 60, thus giving the leftover seconds that don't fit into a full minute.
-*/
+ */
 
 // d) Interpret line 4, what does the expression assigned to totalMinutes mean?
 /* The expression subtracts the leftover seconds from the movie length and divides it by 60 to give the full minutes. Here's a simple formula to understand the logic, movie length = full minutes + leftover seconds
-*/
+ */
 
 // e) What do you think the variable result represents? Can you think of a better name for this variable?
-/* The variable result outputs the time in a formatted time string of hours:minutes:seconds
-It could be more clear to give it a better name like duration or movieDuration.
+// The variable result outputs the time in a formatted time string of hours:minutes:seconds
+// It could be more clear to give it a better name like duration or movieDuration.
 
 // f) Try experimenting with different values of movieLength. Will this code work for all values of movieLength? Explain your answer
-// I think it works for any positive number of seconds.
+console.log(clockFormatter(0));
+console.log(clockFormatter(69));
+console.log(clockFormatter(15000));
+console.log(clockFormatter(-10));
+console.log(clockFormatter(20.4));
+// yes, it worked for all values of movieLength, including 0, negative numbers, and decimal numbers. The code will work for any number, but the output may not be meaningful for negative or decimal values.

Sprint-1/3-mandatory-interpret/3-to-pounds.js

@@ -42,6 +42,7 @@ The last 2 digits represent pence.
 
 Everything before that represents pounds.
 So we take from the start (0) up to (but not including) the position where the last 2 digits begin.
+*/
 /* line 14 Extract the pence part and make sure it’s always 2 digits.
 
 length is 3.
@@ -59,3 +60,4 @@ For "99" → stays "99".
 Pence must always be shown as two digits (like £3.05, not £3.5).
 // To begin, we can start with
 // 1. const penceString = "399p": initialises a string variable with the value "399p"
+*/