solving time convert exercsie

Author: AbdennourHachemi

format-clock-edge-cases/timeConverter.js

@@ -1,11 +1,77 @@
+// function formatAs12HourClock(time) {
+//   //extract digits representing hours
+//   const hours = Number(time.slice(0, 2));
+//   //if houre value over 12, subtract 12
+//   //if hour value under 12 , continue
+//   if (time === "00:00") {
+//     return `12:00 am`;
+//   }
+//   if (hours > 12) {
+//     // add pm and reurn value
+//     return `${hours - 12}:00 pm`;
+//   }
+//   //add am or pm
+//   //return new value
+//   return `${time} am`;
+// }
+
 function formatAs12HourClock(time) {
 
+  console.log(time.length)
+  
+  if (time.length == 4) {
+    console.log("got here")
+    time=time.padStart(5, "0")
+  }
+  
+   if (typeof time !== "string") {
+     return "nccorect timing format";
+   }
+
+   const match = time.match(/^(\d{1,2}):(\d{2})$/);
+
+   if (!match) {
+     return "Inccorect timing format";
+   }
+
+ 
+  
   const hours = Number(time.slice(0, 2));
+  const minutes = Number(time.slice(3, 5));
+  console.log(hours + ` <------------look here hour`);
+  console.log(time + ` <------------look here time`);
+  
+
+  if (time === "00:00") {
+    return `12:00 am`;
+  }
+  if (time === "12:00") {
+    return `12:00 pm`;
+  }
+ 
 
-  if (hours > 12) {
-    return `${hours - 12}:00 pm`;
+  if (hours < 12) {
+    return `${time} am`;
+  } else if (hours == 12) {
+    return `${time} am`;
+  } else if (hours == 24) {
+    return `12:00 am`;
+  }
+
+  if (hours > 12 && hours < 22 && minutes < 10) {
+    return `${(hours - 12).toString().padStart(2, "0")}:${minutes.toString().padStart(2, "0")} pm`;
+  }
+  if (hours > 12 && hours < 22 && minutes >= 10) {
+    return `${(hours - 12).toString().padStart(2, "0")}:${minutes} pm`;
+  }
+  if (hours >= 22 && minutes < 10) {
+    return `${hours - 12}:${minutes.toString().padStart(2, "0")} pm`;
+  }
+  if (hours >= 22 && minutes >= 10) {
+    return `${hours - 12}:${minutes} pm`;
   }
-  return `${time} am`;
 }
 
-export {formatAs12HourClock};
+export { formatAs12HourClock };
+
+

format-clock-edge-cases/timeConverter.test.js

@@ -1,11 +1,47 @@
-import {formatAs12HourClock} from "./timeConverter.js";
+import { formatAs12HourClock } from "./timeConverter.js";
 import assert from "node:assert";
 import test from "node:test";
 
-test("correctly convert time after 12:00", function(){
-    assert.equal(formatAs12HourClock("23:00"), "11:00 pm");
+test("correctly convert time after 12:00", function () {
+  assert.equal(formatAs12HourClock("23:00"), "11:00 pm");
 });
 
-test("can correctly convert morning time", function() {
-    assert.equal(formatAs12HourClock("08:00"), "08:00 am");
+test("can correctly convert morning time", function () {
+  assert.equal(formatAs12HourClock("08:00"), "08:00 am");
 });
+
+test("can corectly convert midnight", () =>
+  assert.equal(formatAs12HourClock("00:00"), "12:00 am"));
+
+test("can corectly convert mid-day", () =>
+  assert.equal(formatAs12HourClock("12:00"), "12:00 pm"));
+
+test("can corectly convert half an hour passed midnight", () =>
+  assert.equal(formatAs12HourClock("00:30"), "00:30 am"));
+
+test("can correctly convert time with missing leading zero", function () {
+  assert.equal(formatAs12HourClock("9:00"), "09:00 am");
+});
+
+test("can correctly handel non digit format entries", function () {
+  assert.equal(formatAs12HourClock("nineOclock"), "Inccorect timing format");
+});
+/* ************************       Edge cases  Minutes     *****************************************************/
+/*   over one hour <- 60                         30                                       0 -> negative number  */
+/*   <----------------|---------------------------|---------------------------------------|-------------------> */
+/* **************************************************************************************************************/
+
+/* ************************       Edge cases  Hours     *****************************************************/
+/*   over one day <- 24                          12                                       0 -> negative number  */
+/*   <----------------|---------------------------|---------------------------------------|-------------------> */
+/* **************************************************************************************************************/
+
+/*--------------------------------------------|
+  |        Hours      |     Minures           | 
+  |         00        |        00             |
+  |___________________|___________________ ___|
+            
+  
+ * 
+
+ */