Skip to content

Commit 6681cfa

Browse files
Simplify getCardValue implementation
1 parent 6f25207 commit 6681cfa

1 file changed

Lines changed: 7 additions & 10 deletions

File tree

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -22,20 +22,17 @@
2222
// execute the code to ensure all tests pass.
2323

2424
function getCardValue(card) {
25-
if (card === "A♠" || card === "A♥" || card === "A♦" || card === "A♣") {
25+
26+
// Check for number cards
27+
const rank = card.slice(0, -1);
28+
29+
if (rank === "A"){
2630
return 11;
2731
}
28-
if (card === "J♠" || card === "J♥" || card === "J♦" || card === "J♣") {
29-
return 10;
30-
}
31-
if (card === "Q♠" || card === "Q♥" || card === "Q♦" || card === "Q♣") {
32-
return 10;
33-
}
34-
if (card === "K♠" || card === "K♥" || card === "K♦" || card === "K♣") {
32+
33+
if (["J", "Q", "K"].includes(rank)) {
3534
return 10;
3635
}
37-
// Check for number cards
38-
const rank = card.slice(0, -1);
3936
const value = parseInt(rank);
4037
if (!isNaN(value) && value >= 2 && value <= 10) {
4138
return value;

0 commit comments

Comments
 (0)