Fix Proper Fraction

Author: Niangh-Ciang

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js

@@ -11,11 +11,7 @@
 // execute the code to ensure all tests pass.
 
 function isProperFraction(numerator, denominator) {
-  if (numerator > 0 && denominator > 0 && numerator < denominator) {
-    return true;
-  } else {
-    return false;
-  }
+  return Math.abs(numerator) < Math.abs(denominator) && denominator !== 0;
 }
 
 // The line below allows us to load the isProperFraction function into tests in other files.
@@ -37,7 +33,9 @@ function assertEquals(actualOutput, targetOutput) {
 assertEquals(isProperFraction(1, 2), true);
 assertEquals(isProperFraction(5, 10), true);
 assertEquals(isProperFraction(2, 3), true);
-assertEquals(isProperFraction(-2, 4), false);
+assertEquals(isProperFraction(-2, 4), true);
 assertEquals(isProperFraction(4, 4), false);
-assertEquals(isProperFraction(2, -5), false);
-assertEquals(isProperFraction(0, 2), false);
+assertEquals(isProperFraction(2, -5), true);
+assertEquals(isProperFraction(0, 2), true);
+assertEquals(isProperFraction(-8, 4), false);
+assertEquals(isProperFraction(4, 0), false);

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

@@ -16,16 +16,16 @@ test("should return true when numerator < denominator and both positive", () =>
   expect(isProperFraction(3, 5)).toEqual(true);
 });
 test("should return false when numerator is negative", () => {
-  expect(isProperFraction(-2, 5)).toEqual(false);
+  expect(isProperFraction(-2, 5)).toEqual(true);
 });
 test("should return false when denominator is negative", () => {
-  expect(isProperFraction(2, -5)).toEqual(false);
+  expect(isProperFraction(2, -5)).toEqual(true);
 });
 test("should return false when numerator is greater than denominator", () => {
   expect(isProperFraction(4, 2)).toEqual(false);
 });
 test("should return false when numerator is zero", () => {
-  expect(isProperFraction(0, 5)).toEqual(false);
+  expect(isProperFraction(0, 5)).toEqual(true);
 });
 test("should return false when numerator equals denominator", () => {
   expect(isProperFraction(4, 4)).toEqual(false);