Fix inconsistencies across assertion traits

Author: TavoNiievez

src/Codeception/Module/Symfony/BrowserAssertionsTrait.php

@@ -21,6 +21,8 @@
 use Symfony\Component\HttpFoundation\Test\Constraint\ResponseIsUnprocessable;
 use Symfony\Component\HttpFoundation\Test\Constraint\ResponseStatusCodeSame;
 
+use function class_exists;
+use function count;
 use function sprintf;
 
 trait BrowserAssertionsTrait

src/Codeception/Module/Symfony/ConsoleAssertionsTrait.php

@@ -9,6 +9,7 @@
 use Symfony\Component\Console\Tester\CommandTester;
 use Symfony\Component\HttpKernel\KernelInterface;
 
+use function is_int;
 use function sprintf;
 
 trait ConsoleAssertionsTrait

src/Codeception/Module/Symfony/FormAssertionsTrait.php

@@ -7,6 +7,8 @@
 use Symfony\Component\Form\Extension\DataCollector\FormDataCollector;
 use Symfony\Component\VarDumper\Cloner\Data;
 
+use function count;
+use function implode;
 use function is_array;
 use function is_int;
 use function is_numeric;

src/Codeception/Module/Symfony/LoggerAssertionsTrait.php

@@ -7,6 +7,12 @@
 use Symfony\Component\HttpKernel\DataCollector\LoggerDataCollector;
 use Symfony\Component\VarDumper\Cloner\Data;
 
+use function array_map;
+use function count;
+use function implode;
+use function is_scalar;
+use function is_string;
+use function json_encode;
 use function sprintf;
 
 trait LoggerAssertionsTrait

src/Codeception/Module/Symfony/MimeAssertionsTrait.php

@@ -9,6 +9,8 @@
 use Symfony\Component\Mime\Email;
 use Symfony\Component\Mime\Test\Constraint as MimeConstraint;
 
+use function sprintf;
+
 trait MimeAssertionsTrait
 {
     /**

src/Codeception/Module/Symfony/NotifierAssertionsTrait.php

@@ -13,7 +13,7 @@
 use Symfony\Component\Notifier\Message\MessageInterface;
 use Symfony\Component\Notifier\Test\Constraint as NotifierConstraint;
 
-use function end;
+use function array_key_last;
 use function version_compare;
 
 trait NotifierAssertionsTrait
@@ -163,10 +163,9 @@ public function dontSeeNotificationIsSent(): void
      */
     public function grabLastSentNotification(): ?MessageInterface
     {
-        $notification = $this->getNotifierMessages();
-        $lastNotification = end($notification);
+        $notifications = $this->getNotifierMessages();
 
-        return $lastNotification ?: null;
+        return $notifications ? $notifications[array_key_last($notifications)] : null;
     }
 
     /**
@@ -205,7 +204,7 @@ public function seeNotificationIsSent(int $expectedCount = 1): void
     }
 
     /** @return MessageEvent[] */
-    public function getNotifierEvents(?string $transportName = null): array
+    protected function getNotifierEvents(?string $transportName = null): array
     {
         return $this->getNotificationEvents()->getEvents($transportName);
     }
@@ -224,7 +223,7 @@ public function getNotifierEvent(int $index = 0, ?string $transportName = null):
     }
 
     /** @return MessageInterface[] */
-    public function getNotifierMessages(?string $transportName = null): array
+    protected function getNotifierMessages(?string $transportName = null): array
     {
         return $this->getNotificationEvents()->getMessages($transportName);
     }

src/Codeception/Module/Symfony/SessionAssertionsTrait.php

@@ -46,6 +46,15 @@ public function amLoggedInAs(UserInterface $user, string $firewallName = 'main',
         $this->amLoggedInWithToken($this->createAuthenticationToken($user, $firewallName), $firewallName, $firewallContext);
     }
 
+    /**
+     * Login with the given authentication token.
+     * If you have more than one firewall or firewall context, you can specify the desired one as a parameter.
+     *
+     * ```php
+     * <?php
+     * $I->amLoggedInWithToken($token);
+     * ```
+     */
     public function amLoggedInWithToken(TokenInterface $token, string $firewallName = 'main', ?string $firewallContext = null): void
     {
         $this->getTokenStorage()->setToken($token);

src/Codeception/Module/Symfony/TimeAssertionsTrait.php

@@ -37,7 +37,7 @@ public function seeRequestTimeIsLessThan(int|float $expectedMilliseconds): void
             $expectedMilliseconds,
             $actualMilliseconds,
             sprintf(
-                'The request duration was expected to be less than %d ms, but it was actually %d ms.',
+                'The request duration was expected to be less than %.2f ms, but it was actually %.2f ms.',
                 $expectedMilliseconds,
                 $actualMilliseconds
             )

src/Codeception/Module/Symfony/ValidatorAssertionsTrait.php

@@ -7,6 +7,10 @@
 use Symfony\Component\Validator\ConstraintViolationInterface;
 use Symfony\Component\Validator\Validator\ValidatorInterface;
 
+use function array_filter;
+use function iterator_to_array;
+use function str_contains;
+
 trait ValidatorAssertionsTrait
 {
     /**
@@ -71,7 +75,7 @@ public function seeViolatedConstraintMessage(string $expected, object $subject,
         $violations = $this->getViolationsForSubject($subject, $propertyPath);
         $containsExpected = false;
         foreach ($violations as $violation) {
-            if ($violation->getPropertyPath() === $propertyPath && str_contains((string) $violation->getMessage(), $expected)) {
+            if (str_contains((string) $violation->getMessage(), $expected)) {
                 $containsExpected = true;
                 break;
             }
@@ -93,7 +97,6 @@ protected function getViolationsForSubject(object $subject, ?string $propertyPat
                 $violations,
                 static fn(ConstraintViolationInterface $violation): bool => $violation->getConstraint() !== null
                     && $violation->getConstraint()::class === $constraint
-                    && ($propertyPath === null || $violation->getPropertyPath() === $propertyPath)
             );
         }