Skip to content

Commit 6cffef1

Browse files
committed
fix selectedCellEditor type
1 parent 548fc22 commit 6cffef1

3 files changed

Lines changed: 13 additions & 15 deletions

File tree

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1654,7 +1654,7 @@ interface RenderRowProps<TRow, TSummaryRow = unknown> {
16541654
gridRowStart: number;
16551655
lastFrozenColumnIndex: number;
16561656
draggedOverCellIdx: number | undefined;
1657-
selectedCellEditor: ReactElement<RenderEditCellContentProps<TRow>> | undefined;
1657+
selectedCellEditor: ReactElement<EditCellProps<TRow, TSummaryRow>> | undefined;
16581658
onRowChange: (column: CalculatedColumn<TRow, TSummaryRow>, rowIdx: number, newRow: TRow) => void;
16591659
rowClass: Maybe<(row: TRow, rowIdx: number) => Maybe<string>>;
16601660
// ... and event handlers

src/EditCell.tsx

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { useEffectEvent, useLayoutEffect, useRef } from 'react';
22
import { css } from 'ecij';
33

44
import { createCellEvent, getCellClassname, getCellStyle, onEditorNavigation } from './utils';
5-
import type { CellKeyboardEvent, RenderCellProps, EditCellKeyDownArgs, Maybe } from './types';
5+
import type { EditCellProps } from './types';
66

77
declare global {
88
const scheduler: Scheduler | undefined;
@@ -43,18 +43,6 @@ const cellEditing = css`
4343
}
4444
`;
4545

46-
type SharedRenderCellProps<R, SR> = Pick<
47-
RenderCellProps<R, SR>,
48-
'column' | 'colSpan' | 'row' | 'rowIdx'
49-
>;
50-
51-
interface EditCellProps<R, SR> extends SharedRenderCellProps<R, SR> {
52-
onRowChange: (row: R, commitChanges: boolean, shouldFocusCell: boolean) => void;
53-
closeEditor: (shouldFocusCell: boolean) => void;
54-
navigate: (event: React.KeyboardEvent<HTMLDivElement>) => void;
55-
onKeyDown: Maybe<(args: EditCellKeyDownArgs<R, SR>, event: CellKeyboardEvent) => void>;
56-
}
57-
5846
export default function EditCell<R, SR>({
5947
column,
6048
colSpan,

src/types.ts

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,6 +186,16 @@ export interface RenderCellProps<TRow, TSummaryRow> extends BaseRenderCellProps<
186186
onRowChange: (column: CalculatedColumn<TRow, TSummaryRow>, newRow: TRow) => void;
187187
}
188188

189+
export interface EditCellProps<R, SR> extends Pick<
190+
RenderCellProps<R, SR>,
191+
'column' | 'colSpan' | 'row' | 'rowIdx'
192+
> {
193+
onRowChange: (row: R, commitChanges: boolean, shouldFocusCell: boolean) => void;
194+
closeEditor: (shouldFocusCell: boolean) => void;
195+
navigate: (event: React.KeyboardEvent<HTMLDivElement>) => void;
196+
onKeyDown: Maybe<(args: EditCellKeyDownArgs<R, SR>, event: CellKeyboardEvent) => void>;
197+
}
198+
189199
export type CellEvent<E extends React.SyntheticEvent<HTMLDivElement>> = E & {
190200
preventGridDefault: () => void;
191201
isGridDefaultPrevented: () => boolean;
@@ -254,7 +264,7 @@ export interface RenderRowProps<TRow, TSummaryRow = unknown> extends BaseRenderR
254264
row: TRow;
255265
lastFrozenColumnIndex: number;
256266
draggedOverCellIdx: number | undefined;
257-
selectedCellEditor: ReactElement<RenderEditCellContentProps<TRow>> | undefined;
267+
selectedCellEditor: ReactElement<EditCellProps<TRow, TSummaryRow>> | undefined;
258268
onRowChange: (column: CalculatedColumn<TRow, TSummaryRow>, rowIdx: number, newRow: TRow) => void;
259269
rowClass: Maybe<(row: TRow, rowIdx: number) => Maybe<string>>;
260270
isTreeGrid: boolean;

0 commit comments

Comments
 (0)