tests: enable printConsoleTrace, add failOnConsole.ts (#3956)

* tests: enable printConsoleTrace, add failOnConsole.ts

* fix biome config

---------

Co-authored-by: Aman Mahajan <amahajan@stratag.com>

Author: nstepien

biome.json

@@ -360,6 +360,16 @@
         }
       }
     },
+    {
+      "includes": ["test/failOnConsole.ts"],
+      "linter": {
+        "rules": {
+          "suspicious": {
+            "noConsole": "off"
+          }
+        }
+      }
+    },
     {
       "includes": ["**/*.js", "**/rolldown.config.ts"],
       "linter": {

eslint.config.js

@@ -630,8 +630,8 @@ export default defineConfig([
       'vitest/no-disabled-tests': 0,
       'vitest/no-done-callback': 1,
       'vitest/no-duplicate-hooks': 1,
-      'vitest/no-focused-tests': 1,
-      'vitest/no-hooks': 1,
+      'vitest/no-focused-tests': [1, { fixable: false }],
+      'vitest/no-hooks': 0,
       'vitest/no-identical-title': 1,
       'vitest/no-import-node-test': 1,
       'vitest/no-importing-vitest-globals': 1,
@@ -741,6 +741,16 @@ export default defineConfig([
     }
   },
 
+  {
+    name: 'tools',
+
+    files: ['test/failOnConsole.ts'],
+
+    rules: {
+      'no-console': 0
+    }
+  },
+
   {
     name: 'node',
 

test/failOnConsole.ts

@@ -0,0 +1,38 @@
+let consoleErrorOrConsoleWarnWereCalled = false;
+
+beforeAll(() => {
+  // replace instead of mutating `console` to avoid infinite loops
+  globalThis.console = {
+    ...console,
+    error(...params) {
+      if (
+        params[0] instanceof Error &&
+        params[0].message === 'ResizeObserver loop completed with undelivered notifications.'
+      ) {
+        return;
+      }
+
+      consoleErrorOrConsoleWarnWereCalled = true;
+      console.log(...params);
+    },
+    warn(...params) {
+      consoleErrorOrConsoleWarnWereCalled = true;
+      console.log(...params);
+    }
+  };
+});
+
+afterEach(() => {
+  if (!consoleErrorOrConsoleWarnWereCalled) {
+    return;
+  }
+
+  consoleErrorOrConsoleWarnWereCalled = false;
+
+  // Errors thrown in `afterEach` will short-circuit subsequent `afterEach` hooks,
+  // thus preventing tests from being cleaned up properly and affecting other tests.
+  // We must therefore wait for tests to "finish" before throwing the error.
+  onTestFinished(() => {
+    throw new Error('console.error() and/or console.warn() were called during the test');
+  });
+});

vite.config.ts

@@ -124,6 +124,7 @@ export default defineConfig(
     test: {
       dir: 'test',
       globals: true,
+      printConsoleTrace: true,
       coverage: {
         provider: 'istanbul',
         enabled: isCI,
@@ -156,7 +157,7 @@ export default defineConfig(
               headless: true,
               screenshotFailures: !isCI
             },
-            setupFiles: ['test/setupBrowser.ts']
+            setupFiles: ['test/setupBrowser.ts', 'test/failOnConsole.ts']
           }
         },
         {
@@ -171,15 +172,16 @@ export default defineConfig(
               headless: true,
               screenshotFailures: false
             },
-            setupFiles: ['test/setupBrowser.ts']
+            setupFiles: ['test/setupBrowser.ts', 'test/failOnConsole.ts']
           }
         },
         {
           extends: true,
           test: {
             name: 'node',
             include: ['node/**/*.test.*'],
-            environment: 'node'
+            environment: 'node',
+            setupFiles: ['test/failOnConsole.ts']
           }
         }
       ]