Bug: Units::getFocusPenalty crashes on soulless units

[quietust]

The function Units::getFocusPenalty dereferences unit->status.current_soul without verifying that it is non-null; as such, if you call it on a unit which has no soul (which seems to include certain types of undead), the game will crash.

It seems this can happen if such a creature becomes a member of your fortress and you have idle-crafting enabled.

[lordmuff]

hi, person with the crash here;

i have since disabled idle-crafting and the crash seems to persist; checking what other DFHack scripts i have right now. i have one or two i'm subbed to on the workshop so it may be their fault and not directly the fault of an official DFHack script. will report back.

[lordmuff]

fixed the crash on my end; made the offending script (it was immortal-cravings) error on execution, so i could load into the save, make it valid again, then disable it and save. this probably isn't relevant at all but i wanted to have it be a matter of public record so end users will know how to fix it if it happens to them too

[chdoc]

It is entirely expected that immortal-cravings causes the same type of crash, because it uses the same underlying functionality to determine the unit's needs.

[lordmuff]

yeah no dont worry, i realize. i just thought i would put it on the public record so end users could find a solution on Google. that's the last thing i'll add