From 0ae69e7dea85e85ac8a53352db8dd3f545b096b4 Mon Sep 17 00:00:00 2001 From: Dave Rogers Date: Tue, 11 Aug 2026 01:13:27 -0700 Subject: [PATCH 1/3] ci: read node version from .nvmrc in github workflows (#4919) Co-Authored-By: Claude Fable 5 --- .github/workflows/run-checks.yml | 2 +- .github/workflows/run-playwright-tests-anvil-catalog.yml | 2 +- .github/workflows/run-playwright-tests-anvil-cmg.yml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/run-checks.yml b/.github/workflows/run-checks.yml index db866b2d2..191163d6a 100644 --- a/.github/workflows/run-checks.yml +++ b/.github/workflows/run-checks.yml @@ -8,7 +8,7 @@ jobs: - uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0 - uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0 with: - node-version: "22.12.0" + node-version-file: ".nvmrc" - run: | npm ci npm run check-format diff --git a/.github/workflows/run-playwright-tests-anvil-catalog.yml b/.github/workflows/run-playwright-tests-anvil-catalog.yml index 8013522f7..ff8cafeed 100644 --- a/.github/workflows/run-playwright-tests-anvil-catalog.yml +++ b/.github/workflows/run-playwright-tests-anvil-catalog.yml @@ -12,7 +12,7 @@ jobs: - uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0 - uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0 with: - node-version: "22.12.0" + node-version-file: ".nvmrc" - name: Install dependencies run: | npm ci diff --git a/.github/workflows/run-playwright-tests-anvil-cmg.yml b/.github/workflows/run-playwright-tests-anvil-cmg.yml index fad58eedf..1906d308c 100644 --- a/.github/workflows/run-playwright-tests-anvil-cmg.yml +++ b/.github/workflows/run-playwright-tests-anvil-cmg.yml @@ -12,7 +12,7 @@ jobs: - uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0 - uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0 with: - node-version: "22.12.0" + node-version-file: ".nvmrc" - name: Install dependencies run: | npm ci From 5355d8d930f3fd7368966a38c24cc8e267f91290 Mon Sep 17 00:00:00 2001 From: Dave Rogers Date: Tue, 11 Aug 2026 01:30:36 -0700 Subject: [PATCH 2/3] ci: cache npm, align deploy scripts and docs with .nvmrc (#4919) Co-Authored-By: Claude Fable 5 --- .github/workflows/run-checks.yml | 4 ++++ .github/workflows/run-playwright-tests-anvil-catalog.yml | 4 ++++ .github/workflows/run-playwright-tests-anvil-cmg.yml | 2 ++ README.md | 2 +- cc-anvil-catalog-dev-deploy.sh | 2 +- cc-data-browser.lungmap.dev.clevercanary.com-deploy.sh | 2 +- cc-explore.anvilproject.dev.clevercanary.com-deploy.sh | 2 +- cgl-anvil-catalog-prod-deploy.sh | 2 +- 8 files changed, 15 insertions(+), 5 deletions(-) diff --git a/.github/workflows/run-checks.yml b/.github/workflows/run-checks.yml index 191163d6a..b2a26a9e2 100644 --- a/.github/workflows/run-checks.yml +++ b/.github/workflows/run-checks.yml @@ -9,6 +9,10 @@ jobs: - uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0 with: node-version-file: ".nvmrc" + cache: "npm" + cache-dependency-path: | + package-lock.json + files/package-lock.json - run: | npm ci npm run check-format diff --git a/.github/workflows/run-playwright-tests-anvil-catalog.yml b/.github/workflows/run-playwright-tests-anvil-catalog.yml index ff8cafeed..d32e12893 100644 --- a/.github/workflows/run-playwright-tests-anvil-catalog.yml +++ b/.github/workflows/run-playwright-tests-anvil-catalog.yml @@ -13,6 +13,10 @@ jobs: - uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0 with: node-version-file: ".nvmrc" + cache: "npm" + cache-dependency-path: | + package-lock.json + files/package-lock.json - name: Install dependencies run: | npm ci diff --git a/.github/workflows/run-playwright-tests-anvil-cmg.yml b/.github/workflows/run-playwright-tests-anvil-cmg.yml index 1906d308c..f7fd55151 100644 --- a/.github/workflows/run-playwright-tests-anvil-cmg.yml +++ b/.github/workflows/run-playwright-tests-anvil-cmg.yml @@ -13,6 +13,8 @@ jobs: - uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0 with: node-version-file: ".nvmrc" + cache: "npm" + cache-dependency-path: "package-lock.json" - name: Install dependencies run: | npm ci diff --git a/README.md b/README.md index ed67e3db0..e823a6e2d 100644 --- a/README.md +++ b/README.md @@ -6,7 +6,7 @@ The HCA Data Browser is built using [Next.js](https://nextjs.org/). ## Prerequisites -Node.js 22.12.0 is required to run the app. +Node.js 22.13.0 (see `.nvmrc`) is required to run the app. ### 1. Clone the Repo diff --git a/cc-anvil-catalog-dev-deploy.sh b/cc-anvil-catalog-dev-deploy.sh index 642d966db..9e68acad0 100755 --- a/cc-anvil-catalog-dev-deploy.sh +++ b/cc-anvil-catalog-dev-deploy.sh @@ -6,7 +6,7 @@ rm -rf ./out echo \"Deleting ./build/\" rm -rf ./build -n 22.12.0 +n $(cat .nvmrc) npm ci export NEXT_PUBLIC_BASE_PATH="/data" diff --git a/cc-data-browser.lungmap.dev.clevercanary.com-deploy.sh b/cc-data-browser.lungmap.dev.clevercanary.com-deploy.sh index 4f6fa9af6..412229c3b 100755 --- a/cc-data-browser.lungmap.dev.clevercanary.com-deploy.sh +++ b/cc-data-browser.lungmap.dev.clevercanary.com-deploy.sh @@ -5,7 +5,7 @@ set -e echo \"Deleting ./out/\" rm -rf ./out -n 22.12.0 +n $(cat .nvmrc) npm ci # Build diff --git a/cc-explore.anvilproject.dev.clevercanary.com-deploy.sh b/cc-explore.anvilproject.dev.clevercanary.com-deploy.sh index e54307c48..8e85bf097 100755 --- a/cc-explore.anvilproject.dev.clevercanary.com-deploy.sh +++ b/cc-explore.anvilproject.dev.clevercanary.com-deploy.sh @@ -8,7 +8,7 @@ rm -rf ./out echo \"Deleting ./build/\" rm -rf ./build -n 22.12.0 +n $(cat .nvmrc) npm ci mkdir -p build/explore/anvil-cmg diff --git a/cgl-anvil-catalog-prod-deploy.sh b/cgl-anvil-catalog-prod-deploy.sh index bdb997e82..ce6183bdb 100755 --- a/cgl-anvil-catalog-prod-deploy.sh +++ b/cgl-anvil-catalog-prod-deploy.sh @@ -8,7 +8,7 @@ rm -rf ./out echo \"Deleting ./build/\" rm -rf ./build -n 22.12.0 +n $(cat .nvmrc) npm ci export NEXT_PUBLIC_BASE_PATH="/data" From d470c30660a2f503356df0186babdf098b053dde Mon Sep 17 00:00:00 2001 From: Dave Rogers Date: Tue, 11 Aug 2026 01:35:36 -0700 Subject: [PATCH 3/3] ci: quote .nvmrc read in deploy scripts, add set -e to dev deploy (#4919) Co-Authored-By: Claude Fable 5 --- cc-anvil-catalog-dev-deploy.sh | 4 +++- cc-data-browser.lungmap.dev.clevercanary.com-deploy.sh | 2 +- cc-explore.anvilproject.dev.clevercanary.com-deploy.sh | 2 +- cgl-anvil-catalog-prod-deploy.sh | 2 +- 4 files changed, 6 insertions(+), 4 deletions(-) diff --git a/cc-anvil-catalog-dev-deploy.sh b/cc-anvil-catalog-dev-deploy.sh index 9e68acad0..61472a7af 100755 --- a/cc-anvil-catalog-dev-deploy.sh +++ b/cc-anvil-catalog-dev-deploy.sh @@ -1,4 +1,6 @@ #!/usr/bin/env bash +# Set the script to exit immediately on error +set -e echo \"Deleting ./out/\" rm -rf ./out @@ -6,7 +8,7 @@ rm -rf ./out echo \"Deleting ./build/\" rm -rf ./build -n $(cat .nvmrc) +n "$(cat .nvmrc)" npm ci export NEXT_PUBLIC_BASE_PATH="/data" diff --git a/cc-data-browser.lungmap.dev.clevercanary.com-deploy.sh b/cc-data-browser.lungmap.dev.clevercanary.com-deploy.sh index 412229c3b..bc0be9f00 100755 --- a/cc-data-browser.lungmap.dev.clevercanary.com-deploy.sh +++ b/cc-data-browser.lungmap.dev.clevercanary.com-deploy.sh @@ -5,7 +5,7 @@ set -e echo \"Deleting ./out/\" rm -rf ./out -n $(cat .nvmrc) +n "$(cat .nvmrc)" npm ci # Build diff --git a/cc-explore.anvilproject.dev.clevercanary.com-deploy.sh b/cc-explore.anvilproject.dev.clevercanary.com-deploy.sh index 8e85bf097..ff420cc7a 100755 --- a/cc-explore.anvilproject.dev.clevercanary.com-deploy.sh +++ b/cc-explore.anvilproject.dev.clevercanary.com-deploy.sh @@ -8,7 +8,7 @@ rm -rf ./out echo \"Deleting ./build/\" rm -rf ./build -n $(cat .nvmrc) +n "$(cat .nvmrc)" npm ci mkdir -p build/explore/anvil-cmg diff --git a/cgl-anvil-catalog-prod-deploy.sh b/cgl-anvil-catalog-prod-deploy.sh index ce6183bdb..3765c24a9 100755 --- a/cgl-anvil-catalog-prod-deploy.sh +++ b/cgl-anvil-catalog-prod-deploy.sh @@ -8,7 +8,7 @@ rm -rf ./out echo \"Deleting ./build/\" rm -rf ./build -n $(cat .nvmrc) +n "$(cat .nvmrc)" npm ci export NEXT_PUBLIC_BASE_PATH="/data"