-
Notifications
You must be signed in to change notification settings - Fork 331
Expand file tree
/
Copy pathConfigInversionLinter.kt
More file actions
468 lines (405 loc) · 19.3 KB
/
ConfigInversionLinter.kt
File metadata and controls
468 lines (405 loc) · 19.3 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
package datadog.gradle.plugin.config
import com.github.javaparser.ParserConfiguration
import com.github.javaparser.StaticJavaParser
import com.github.javaparser.ast.CompilationUnit
import com.github.javaparser.ast.Modifier
import com.github.javaparser.ast.body.ClassOrInterfaceDeclaration
import com.github.javaparser.ast.body.FieldDeclaration
import com.github.javaparser.ast.body.MethodDeclaration
import com.github.javaparser.ast.body.VariableDeclarator
import com.github.javaparser.ast.expr.StringLiteralExpr
import com.github.javaparser.ast.nodeTypes.NodeWithModifiers
import com.github.javaparser.ast.stmt.ExplicitConstructorInvocationStmt
import com.github.javaparser.ast.stmt.ReturnStmt
import org.gradle.api.DefaultTask
import org.gradle.api.GradleException
import org.gradle.api.Plugin
import org.gradle.api.Project
import org.gradle.api.file.ConfigurableFileCollection
import org.gradle.api.provider.Property
import org.gradle.api.tasks.Input
import org.gradle.api.tasks.InputFiles
import org.gradle.api.tasks.SourceSet
import org.gradle.api.tasks.SourceSetContainer
import org.gradle.api.tasks.TaskAction
import org.gradle.kotlin.dsl.getByType
import java.net.URLClassLoader
import java.nio.file.Path
class ConfigInversionLinter : Plugin<Project> {
override fun apply(target: Project) {
val extension = target.extensions.create("supportedTracerConfigurations", SupportedTracerConfigurations::class.java)
registerLogEnvVarUsages(target, extension)
registerCheckEnvironmentVariablesUsage(target)
registerCheckConfigStringsTask(target, extension)
registerCheckInstrumenterModuleConfigurations(target, extension)
registerCheckDecoratorAnalyticsConfigurations(target, extension)
}
}
// Data class for fields from generated class
data class LoadedConfigFields(
val supported: Set<String>,
val aliasMapping: Map<String, String> = emptyMap(),
val aliases: Map<String, List<String>> = emptyMap()
)
// Cache for fields from generated class
private var cachedConfigFields: LoadedConfigFields? = null
// Helper function to load fields from the generated class
private fun loadConfigFields(
mainSourceSetOutput: org.gradle.api.file.FileCollection,
generatedClassName: String
): LoadedConfigFields {
return cachedConfigFields ?: run {
val urls = mainSourceSetOutput.files.map { it.toURI().toURL() }.toTypedArray()
URLClassLoader(urls, LoadedConfigFields::class.java.classLoader).use { cl ->
val clazz = Class.forName(generatedClassName, true, cl)
val supportedField = clazz.getField("SUPPORTED").get(null)
@Suppress("UNCHECKED_CAST")
val supportedSet = when (supportedField) {
is Set<*> -> supportedField as Set<String>
is Map<*, *> -> supportedField.keys as Set<String>
else -> throw IllegalStateException("SUPPORTED field must be either Set<String> or Map<String, Any>, but was ${supportedField?.javaClass}")
}
@Suppress("UNCHECKED_CAST")
val aliasMappingMap = clazz.getField("ALIAS_MAPPING").get(null) as Map<String, String>
@Suppress("UNCHECKED_CAST")
val aliasesMap = clazz.getField("ALIASES").get(null) as Map<String, List<String>>
LoadedConfigFields(supportedSet, aliasMappingMap, aliasesMap)
}.also { cachedConfigFields = it }
}
}
/** Registers `logEnvVarUsages` (scan for DD_/OTEL_ tokens and fail if unsupported). */
private fun registerLogEnvVarUsages(target: Project, extension: SupportedTracerConfigurations) {
val ownerPath = extension.configOwnerPath
val generatedFile = extension.className
// token check that uses the generated class instead of JSON
target.tasks.register("logEnvVarUsages") {
group = "verification"
description = "Scan Java files for DD_/OTEL_ tokens and fail if unsupported (using generated constants)"
val mainSourceSetOutput = ownerPath.map {
target.project(it)
.extensions.getByType<SourceSetContainer>()
.named(SourceSet.MAIN_SOURCE_SET_NAME)
.map { main -> main.output }
}
inputs.files(mainSourceSetOutput)
// inputs for incrementality (your own source files, not the owner’s)
val javaFiles = target.fileTree(target.projectDir) {
include("**/src/main/java/**/*.java")
exclude("**/build/**", "**/dd-smoke-tests/**")
// Undertow uses DD_UNDERTOW_CONTINUATION as a legacy key to store an AgentScope. It is not related to an environment variable
exclude("dd-java-agent/instrumentation/undertow/undertow-common/src/main/java/datadog/trace/instrumentation/undertow/UndertowDecorator.java")
}
inputs.files(javaFiles)
outputs.upToDateWhen { true }
doLast {
// 1) Load configuration fields from the generated class
val configFields = loadConfigFields(mainSourceSetOutput.get().get(), generatedFile.get())
val supported = configFields.supported
// 2) Scan our sources and compare
val repoRoot = target.projectDir.toPath()
val tokenRegex = Regex("\"(?:DD_|OTEL_)[A-Za-z0-9_]+\"")
val violations = buildList {
javaFiles.files.forEach { f ->
val rel = repoRoot.relativize(f.toPath()).toString()
var inBlock = false
f.readLines().forEachIndexed { i, raw ->
val trimmed = raw.trim()
if (trimmed.startsWith("//")) return@forEachIndexed
if (!inBlock && trimmed.contains("/*")) inBlock = true
if (inBlock) {
if (trimmed.contains("*/")) inBlock = false
return@forEachIndexed
}
tokenRegex.findAll(raw).forEach { m ->
val token = m.value.trim('"')
if (token !in supported) add("$rel:${i + 1} -> Unsupported token '$token'")
}
}
}
}
if (violations.isNotEmpty()) {
violations.forEach { target.logger.error(it) }
throw GradleException("Unsupported DD_/OTEL_ tokens found! See errors above.")
} else {
target.logger.info("All DD_/OTEL_ tokens are supported.")
}
}
}
}
/** Registers `checkEnvironmentVariablesUsage` (forbid EnvironmentVariables.get(...)). */
private fun registerCheckEnvironmentVariablesUsage(project: Project) {
project.tasks.register("checkEnvironmentVariablesUsage") {
group = "verification"
description = "Scans src/main/java for direct usages of EnvironmentVariables.get(...)"
doLast {
val repoRoot: Path = project.projectDir.toPath()
val javaFiles = project.fileTree(project.projectDir) {
include("**/src/main/java/**/*.java")
exclude("**/build/**")
exclude("utils/config-utils/src/main/java/datadog/trace/config/inversion/ConfigHelper.java")
exclude("dd-java-agent/agent-bootstrap/**")
exclude("dd-java-agent/src/main/java/datadog/trace/bootstrap/**")
}
val pattern = Regex("""EnvironmentVariables\.get\s*\(""")
val matches = buildList {
javaFiles.forEach { f ->
val relative = repoRoot.relativize(f.toPath())
f.readLines().forEachIndexed { idx, line ->
if (pattern.containsMatchIn(line)) {
add("$relative:${idx + 1} -> ${line.trim()}")
}
}
}
}
if (matches.isNotEmpty()) {
project.logger.lifecycle("\nFound forbidden usages of EnvironmentVariables.get(...):")
matches.forEach { project.logger.lifecycle(it) }
throw GradleException("Forbidden usage of EnvironmentVariables.get(...) found in Java files.")
} else {
project.logger.info("No forbidden EnvironmentVariables.get(...) usages found in src/main/java.")
}
}
}
}
// Helper functions for checking Config Strings
private fun normalize(configValue: String) =
"DD_" + configValue.uppercase().replace("-", "_").replace(".", "_")
// Checking "public" "static" "final"
private fun NodeWithModifiers<*>.hasModifiers(vararg mods: Modifier.Keyword) =
mods.all { hasModifier(it) }
/** Registers `checkConfigStrings` to validate config definitions against documented supported configurations. */
private fun registerCheckConfigStringsTask(project: Project, extension: SupportedTracerConfigurations) {
val ownerPath = extension.configOwnerPath
val generatedFile = extension.className
project.tasks.register("checkConfigStrings") {
group = "verification"
description = "Validates that all config definitions in `dd-trace-api/src/main/java/datadog/trace/api/config` exist in `metadata/supported-configurations.json`"
val mainSourceSetOutput = ownerPath.map {
project.project(it)
.extensions.getByType<SourceSetContainer>()
.named(SourceSet.MAIN_SOURCE_SET_NAME)
.map { main -> main.output }
}
inputs.files(mainSourceSetOutput)
doLast {
val repoRoot: Path = project.rootProject.projectDir.toPath()
val configDir = repoRoot.resolve("dd-trace-api/src/main/java/datadog/trace/api/config").toFile()
if (!configDir.exists()) {
throw GradleException("Config directory not found: ${configDir.absolutePath}")
}
val configFields = loadConfigFields(mainSourceSetOutput.get().get(), generatedFile.get())
val supported = configFields.supported
val aliasMapping = configFields.aliasMapping
var parserConfig = ParserConfiguration()
parserConfig.setLanguageLevel(ParserConfiguration.LanguageLevel.JAVA_8)
StaticJavaParser.setConfiguration(parserConfig)
val violations = buildList {
configDir.listFiles()?.forEach { file ->
val fileName = file.name
val cu: CompilationUnit = StaticJavaParser.parse(file)
cu.findAll(VariableDeclarator::class.java).forEach { varDecl ->
varDecl.parentNode
.map { it as? FieldDeclaration }
.ifPresent { field ->
if (field.hasModifiers(Modifier.Keyword.PUBLIC, Modifier.Keyword.STATIC, Modifier.Keyword.FINAL) &&
varDecl.typeAsString == "String") {
val fieldName = varDecl.nameAsString
if (fieldName.endsWith("_DEFAULT")) return@ifPresent
val init = varDecl.initializer.orElse(null) ?: return@ifPresent
if (init !is StringLiteralExpr) return@ifPresent
val rawValue = init.value
val normalized = normalize(rawValue)
if (normalized !in supported && normalized !in aliasMapping) {
val line = varDecl.range.map { it.begin.line }.orElse(1)
add("$fileName:$line -> Config '$rawValue' normalizes to '$normalized' " +
"which is missing from '${extension.jsonFile.get()}'")
}
}
}
}
}
}
if (violations.isNotEmpty()) {
logger.error("\nFound config definitions not in '${extension.jsonFile.get()}':")
violations.forEach { logger.lifecycle(it) }
throw GradleException("Undocumented Environment Variables found. Please add the above Environment Variables to '${extension.jsonFile.get()}'.")
} else {
logger.info("All config strings are present in '${extension.jsonFile.get()}'.")
}
}
}
}
/** Collects violations for [key] against [supported] and [aliases], checking that all [expectedAliases] are values of that alias entry. */
private fun collectMissingKeysAndAliases(
key: String,
expectedAliases: List<String>,
supported: Set<String>,
aliases: Map<String, List<String>>,
location: String,
context: String
): List<String> = buildList {
if (key !in supported) {
add("$location -> $context: '$key' is missing from SUPPORTED")
}
if (key !in aliases) {
add("$location -> $context: '$key' is missing from ALIASES")
} else {
val aliasValues = aliases[key] ?: emptyList()
for (expected in expectedAliases) {
if (expected !in aliasValues) {
add("$location -> $context: '$expected' is missing from ALIASES['$key']")
}
}
}
}
/** Abstract base for tasks that scan instrumentation source files against the generated config class. */
abstract class InstrumentationConfigCheckTask : DefaultTask() {
@get:InputFiles
abstract val mainSourceSetOutput: ConfigurableFileCollection
@get:InputFiles
abstract val instrumentationFiles: ConfigurableFileCollection
@get:Input
abstract val generatedClassName: Property<String>
@get:Input
abstract val errorHeader: Property<String>
@get:Input
abstract val errorMessage: Property<String>
@get:Input
abstract val successMessage: Property<String>
@TaskAction
fun execute() {
val configFields = loadConfigFields(mainSourceSetOutput, generatedClassName.get())
val parserConfig = ParserConfiguration()
parserConfig.setLanguageLevel(ParserConfiguration.LanguageLevel.JAVA_8)
StaticJavaParser.setConfiguration(parserConfig)
val repoRoot = project.rootProject.projectDir.toPath()
val violations = instrumentationFiles.files.flatMap { file ->
val rel = repoRoot.relativize(file.toPath()).toString()
val cu: CompilationUnit = try {
StaticJavaParser.parse(file)
} catch (_: Exception) {
return@flatMap emptyList()
}
collectPropertyViolations(configFields, rel, cu)
}
if (violations.isNotEmpty()) {
logger.error(errorHeader.get())
violations.forEach { logger.lifecycle(it) }
throw GradleException(errorMessage.get())
} else {
logger.info(successMessage.get())
}
}
protected abstract fun collectPropertyViolations(
configFields: LoadedConfigFields, relativePath: String, cu: CompilationUnit
): List<String>
}
/** Checks that InstrumenterModule integration names have proper entries in SUPPORTED and ALIASES. */
abstract class CheckInstrumenterModuleConfigTask : InstrumentationConfigCheckTask() {
override fun collectPropertyViolations(
configFields: LoadedConfigFields, relativePath: String, cu: CompilationUnit
): List<String> {
val violations = mutableListOf<String>()
cu.findAll(ClassOrInterfaceDeclaration::class.java).forEach classLoop@{ classDecl ->
val extendsModule = classDecl.extendedTypes.any { it.toString().startsWith("InstrumenterModule") }
if (!extendsModule) return@classLoop
classDecl.findAll(ExplicitConstructorInvocationStmt::class.java)
.filter { !it.isThis }
.forEach { superCall ->
val names = superCall.arguments
.filterIsInstance<StringLiteralExpr>()
.map { it.value }
val line = superCall.range.map { it.begin.line }.orElse(1)
for (name in names) {
val normalized = name.uppercase().replace("-", "_").replace(".", "_")
val enabledKey = "DD_TRACE_${normalized}_ENABLED"
val context = "Integration '$name' (super arg)"
val location = "$relativePath:$line"
violations.addAll(collectMissingKeysAndAliases(
enabledKey,
listOf("DD_TRACE_INTEGRATION_${normalized}_ENABLED", "DD_INTEGRATION_${normalized}_ENABLED"),
configFields.supported, configFields.aliases, location, context
))
}
}
}
return violations
}
}
/** Checks that Decorator instrumentationNames have proper analytics entries in SUPPORTED and ALIASES. */
abstract class CheckDecoratorAnalyticsConfigTask : InstrumentationConfigCheckTask() {
override fun collectPropertyViolations(
configFields: LoadedConfigFields, relativePath: String, cu: CompilationUnit
): List<String> {
val violations = mutableListOf<String>()
cu.findAll(MethodDeclaration::class.java)
.filter { it.nameAsString == "instrumentationNames" && it.parameters.isEmpty() }
.forEach { method ->
val names = method.findAll(ReturnStmt::class.java).flatMap { ret ->
ret.expression.map { it.findAll(StringLiteralExpr::class.java).map { s -> s.value } }
.orElse(emptyList())
}
val line = method.range.map { it.begin.line }.orElse(1)
for (name in names) {
val normalized = name.uppercase().replace("-", "_").replace(".", "_")
val context = "Decorator instrumentationName '$name'"
val location = "$relativePath:$line"
violations.addAll(collectMissingKeysAndAliases(
"DD_TRACE_${normalized}_ANALYTICS_ENABLED",
listOf("DD_${normalized}_ANALYTICS_ENABLED"),
configFields.supported, configFields.aliases, location, context
))
violations.addAll(collectMissingKeysAndAliases(
"DD_TRACE_${normalized}_ANALYTICS_SAMPLE_RATE",
listOf("DD_${normalized}_ANALYTICS_SAMPLE_RATE"),
configFields.supported, configFields.aliases, location, context
))
}
}
return violations
}
}
/** Registers `checkInstrumenterModuleConfigurations` to verify each InstrumenterModule's integration name has proper entries in SUPPORTED and ALIASES. */
private fun registerCheckInstrumenterModuleConfigurations(project: Project, extension: SupportedTracerConfigurations) {
val ownerPath = extension.configOwnerPath
val generatedFile = extension.className
project.tasks.register("checkInstrumenterModuleConfigurations", CheckInstrumenterModuleConfigTask::class.java) {
group = "verification"
description = "Validates that InstrumenterModule integration names have corresponding entries in SUPPORTED and ALIASES"
mainSourceSetOutput.from(ownerPath.map {
project.project(it)
.extensions.getByType<SourceSetContainer>()
.named(SourceSet.MAIN_SOURCE_SET_NAME)
.map { main -> main.output }
})
instrumentationFiles.from(project.fileTree(project.rootProject.projectDir) {
include("dd-java-agent/instrumentation/**/src/main/java/**/*.java")
})
generatedClassName.set(generatedFile)
errorHeader.set("\nFound InstrumenterModule integration names with missing SUPPORTED/ALIASES entries:")
errorMessage.set("InstrumenterModule integration names are missing from SUPPORTED or ALIASES in '${extension.jsonFile.get()}'.")
successMessage.set("All InstrumenterModule integration names have proper SUPPORTED and ALIASES entries.")
}
}
/** Registers `checkDecoratorAnalyticsConfigurations` to verify each BaseDecorator subclass's instrumentationNames have proper analytics entries in SUPPORTED and ALIASES. */
private fun registerCheckDecoratorAnalyticsConfigurations(project: Project, extension: SupportedTracerConfigurations) {
val ownerPath = extension.configOwnerPath
val generatedFile = extension.className
project.tasks.register("checkDecoratorAnalyticsConfigurations", CheckDecoratorAnalyticsConfigTask::class.java) {
group = "verification"
description = "Validates that Decorator instrumentationNames have corresponding analytics entries in SUPPORTED and ALIASES"
mainSourceSetOutput.from(ownerPath.map {
project.project(it)
.extensions.getByType<SourceSetContainer>()
.named(SourceSet.MAIN_SOURCE_SET_NAME)
.map { main -> main.output }
})
instrumentationFiles.from(project.fileTree(project.rootProject.projectDir) {
include("dd-java-agent/instrumentation/**/src/main/java/**/*.java")
})
generatedClassName.set(generatedFile)
errorHeader.set("\nFound Decorator instrumentationNames with missing analytics SUPPORTED/ALIASES entries:")
errorMessage.set("Decorator instrumentationNames are missing analytics entries from SUPPORTED or ALIASES in '${extension.jsonFile.get()}'.")
successMessage.set("All Decorator instrumentationNames have proper analytics SUPPORTED and ALIASES entries.")
}
}