fix: Dont throw when user agent construction fails

Author: JanEbbing

CHANGELOG.md

@@ -5,6 +5,11 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
 
+## Unreleased
+### Fixed
+* Catch failures while constructing the user agent string.
+
+
 ## [1.15.0] - 2023-06-09
 ### Fixed
 * Removed `CHANGELOG.md` and `SECURITY.md` from the python package. The `LICENSE` file is no longer installed, but still included in package tarball and wheel files.

deepl/http_client.py

@@ -8,10 +8,12 @@
 import platform
 import random
 import requests
+import traceback
 import time
 from functools import lru_cache
 from typing import Dict, Optional, Tuple, Union
 from .util import log_info
+from deepl import util
 
 
 user_agent = None
@@ -247,11 +249,17 @@ def _generate_user_agent(
     else:
         library_info_str = f"deepl-python/{version.VERSION}"
         if send_platform_info:
-            library_info_str += (
-                f" ({platform.platform()}) "
-                f"python/{platform.python_version()} "
-                f"requests/{requests.__version__}"
-            )
+            try:
+                library_info_str += (
+                    f" ({platform.platform()}) "
+                    f"python/{platform.python_version()} "
+                    f"requests/{requests.__version__}"
+                )
+            except Exception:
+                util.log_info(
+                    "Exception when querying platform information:\n"
+                    + traceback.format_exc()
+                )
     if app_info_name and app_info_version:
         library_info_str += f" {app_info_name}/{app_info_version}"
     return library_info_str

tests/test_general.py

@@ -168,6 +168,20 @@ def test_custom_user_agent_with_app_info(mock_send):
     deepl.http_client.user_agent = old_user_agent
 
 
+@patch("requests.adapters.HTTPAdapter.send")
+@patch("platform.platform")
+def test_user_agent_exception(platform_mock, mock_send):
+    mock_send.return_value = _build_test_response()
+    platform_mock.side_effect = OSError("mocked test exception")
+    translator = deepl.Translator(os.environ["DEEPL_AUTH_KEY"])
+    translator.translate_text(example_text["EN"], target_lang="DA")
+    ua_header = mock_send.call_args[0][0].headers["User-agent"]
+    assert "deepl-python" in ua_header
+    assert "requests/" not in ua_header
+    assert " python/" not in ua_header
+    assert "(" not in ua_header
+
+
 @needs_mock_proxy_server
 def test_proxy_usage(
     server,