missingCheckedExceptionInThrows: true

Author: ondrejmirtes

build/phpstan.neon

@@ -34,6 +34,8 @@ parameters:
 		- ../tests/PHPStan/Command/IgnoredRegexValidatorTest.php
 		- ../src/Command/IgnoredRegexValidator.php
 	exceptions:
+		uncheckedExceptionRegexes:
+			- '~^Exception$~'
 		uncheckedExceptionClasses:
 			- 'PHPStan\ShouldNotHappenException'
 			- 'Symfony\Component\Console\Exception\InvalidArgumentException'
@@ -44,8 +46,26 @@ parameters:
 			- 'PHPStan\DependencyInjection\ParameterNotFoundException'
 			- 'PHPStan\Analyser\UndefinedVariableException'
 			- 'RuntimeException'
+			- 'Nette\Neon\Exception'
+			- 'Nette\Utils\JsonException'
+			- 'PHPStan\File\CouldNotReadFileException'
+			- 'PHPStan\File\CouldNotWriteFileException'
+			- 'PHPStan\Parser\ParserErrorsException'
+			- 'ReflectionException'
+			- 'Nette\Utils\AssertionException'
+			- 'PHPStan\File\PathNotFoundException'
+			- 'PHPStan\Broker\ClassNotFoundException'
+			- 'PHPStan\Broker\FunctionNotFoundException'
+			- 'PHPStan\Broker\ConstantNotFoundException'
+			- 'PHPStan\Reflection\MissingMethodFromReflectionException'
+			- 'PHPStan\Reflection\MissingPropertyFromReflectionException'
+			- 'PHPStan\Reflection\MissingConstantFromReflectionException'
+			- 'PHPStan\Type\CircularTypeAliasDefinitionException'
+			- 'PHPStan\Broker\ClassAutoloadingException'
+			- 'LogicException'
+			- 'TypeError'
 		check:
-			missingCheckedExceptionInThrows: false
+			missingCheckedExceptionInThrows: true
 			tooWideThrowType: true
 	featureToggles:
 		readComposerPhpVersion: false

src/Command/FixerApplication.php

@@ -268,6 +268,9 @@ public function log(string $message): void
 		return 0;
 	}
 
+	/**
+	 * @throws FixerProcessException
+	 */
 	private function getFixerProcess(OutputInterface $output, int $serverPort): Process
 	{
 		if (!@mkdir($this->fixerTmpDir, 0777) && !is_dir($this->fixerTmpDir)) {

src/Parser/Parser.php

@@ -8,12 +8,14 @@ interface Parser
 	/**
 	 * @param string $file path to a file to parse
 	 * @return \PhpParser\Node\Stmt[]
+	 * @throws \PHPStan\Parser\ParserErrorsException
 	 */
 	public function parseFile(string $file): array;
 
 	/**
 	 * @param string $sourceCode
 	 * @return \PhpParser\Node\Stmt[]
+	 * @throws \PHPStan\Parser\ParserErrorsException
 	 */
 	public function parseString(string $sourceCode): array;
 

src/PhpDoc/PhpDocStringResolver.php

@@ -24,7 +24,7 @@ public function resolve(string $phpDocString): PhpDocNode
 	{
 		$tokens = new TokenIterator($this->phpDocLexer->tokenize($phpDocString));
 		$phpDocNode = $this->phpDocParser->parse($tokens);
-		$tokens->consumeTokenType(Lexer::TOKEN_END);
+		$tokens->consumeTokenType(Lexer::TOKEN_END); // @phpstan-ignore-line
 
 		return $phpDocNode;
 	}

src/PhpDoc/TypeStringResolver.php

@@ -28,7 +28,7 @@ public function resolve(string $typeString, ?NameScope $nameScope = null): Type
 	{
 		$tokens = new TokenIterator($this->typeLexer->tokenize($typeString));
 		$typeNode = $this->typeParser->parse($tokens);
-		$tokens->consumeTokenType(Lexer::TOKEN_END);
+		$tokens->consumeTokenType(Lexer::TOKEN_END); // @phpstan-ignore-line
 
 		return $this->typeNodeResolver->resolve($typeNode, $nameScope ?? new NameScope(null, []));
 	}

src/Reflection/BetterReflection/SourceLocator/FileReadTrapStreamWrapper.php

@@ -160,7 +160,7 @@ public function stream_stat()
 	public function url_stat($path, $flags)
 	{
 		if (self::$registeredStreamWrapperProtocols === null) {
-			throw new \LogicException(self::class . ' not registered: cannot operate. Do not call this method directly.');
+			throw new \PHPStan\ShouldNotHappenException(self::class . ' not registered: cannot operate. Do not call this method directly.');
 		}
 
 		foreach (self::$registeredStreamWrapperProtocols as $protocol) {

src/Testing/ErrorFormatterTestCase.php

@@ -61,7 +61,7 @@ protected function getOutputContent(): string
 	protected function getAnalysisResult(int $numFileErrors, int $numGenericErrors): AnalysisResult
 	{
 		if ($numFileErrors > 4 || $numFileErrors < 0 || $numGenericErrors > 2 || $numGenericErrors < 0) {
-			throw new \Exception();
+			throw new \PHPStan\ShouldNotHappenException();
 		}
 
 		$fileErrors = array_slice([

tests/PHPStan/Command/CommandHelperTest.php

@@ -233,6 +233,7 @@ public function dataResolveRelativePaths(): array
 	 * @dataProvider dataResolveRelativePaths
 	 * @param string $configFile
 	 * @param array<string, string> $expectedParameters
+	 * @throws \PHPStan\Command\InceptionNotSuccessfulException
 	 */
 	public function testResolveRelativePaths(
 		string $configFile,

tests/PHPStan/Tests/AssertionClass.php

@@ -5,30 +5,33 @@
 class AssertionClass
 {
 
+	/** @throws \PHPStan\Tests\AssertionException */
 	public function assertString(?string $arg): bool
 	{
 		if ($arg === null) {
-			throw new \Exception();
+			throw new \PHPStan\Tests\AssertionException();
 		}
 		return true;
 	}
 
+	/** @throws AssertionException */
 	public static function assertInt(?int $arg): bool
 	{
 		if ($arg === null) {
-			throw new \Exception();
+			throw new \PHPStan\Tests\AssertionException();
 		}
 		return true;
 	}
 
 	/**
 	 * @param mixed $arg
 	 * @return bool
+	 * @throws AssertionException
 	 */
 	public function assertNotInt($arg): bool
 	{
 		if (is_int($arg)) {
-			throw new \Exception();
+			throw new \PHPStan\Tests\AssertionException();
 		}
 
 		return true;

tests/PHPStan/Tests/AssertionException.php

@@ -0,0 +1,8 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Tests;
+
+class AssertionException extends \Exception
+{
+
+}