Improve memory consumption

Author: ondrejmirtes

conf/config.neon

@@ -1514,6 +1514,12 @@ services:
 		autowired: no
 
 	currentPhpVersionSimpleParser:
+		class: PHPStan\Parser\CleaningParser
+		arguments:
+			wrappedParser: @currentPhpVersionSimpleDirectParser
+		autowired: no
+
+	currentPhpVersionSimpleDirectParser:
 		class: PHPStan\Parser\SimpleParser
 		arguments:
 			parser: @currentPhpVersionPhpParser

src/Command/CommandHelper.php

@@ -375,11 +375,16 @@ public static function begin(
 		/** @var FileFinder $fileFinder */
 		$fileFinder = $container->getService('fileFinderAnalyse');
 
+		$pathRoutingParser = $container->getService('pathRoutingParser');
+
 		/** @var \Closure(): (array{string[], bool}) $filesCallback */
-		$filesCallback = static function () use ($fileFinder, $paths): array {
+		$filesCallback = static function () use ($fileFinder, $pathRoutingParser, $paths): array {
 			$fileFinderResult = $fileFinder->findFiles($paths);
+			$files = $fileFinderResult->getFiles();
+
+			$pathRoutingParser->setAnalysedFiles($files);
 
-			return [$fileFinderResult->getFiles(), $fileFinderResult->isOnlyFiles()];
+			return [$files, $fileFinderResult->isOnlyFiles()];
 		};
 
 		return new InceptionResult(

src/Parser/CleaningParser.php

@@ -0,0 +1,42 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Parser;
+
+use PhpParser\Node\Stmt;
+use PhpParser\NodeTraverser;
+
+class CleaningParser implements Parser
+{
+
+	private Parser $wrappedParser;
+
+	private NodeTraverser $traverser;
+
+	public function __construct(Parser $wrappedParser)
+	{
+		$this->wrappedParser = $wrappedParser;
+		$this->traverser = new NodeTraverser();
+		$this->traverser->addVisitor(new CleaningVisitor());
+	}
+
+	public function parseFile(string $file): array
+	{
+		return $this->clean($this->wrappedParser->parseFile($file));
+	}
+
+	public function parseString(string $sourceCode): array
+	{
+		return $this->clean($this->wrappedParser->parseString($sourceCode));
+	}
+
+	/**
+	 * @param Stmt[] $ast
+	 * @return Stmt[]
+	 */
+	private function clean(array $ast): array
+	{
+		/** @var Stmt[] */
+		return $this->traverser->traverse($ast);
+	}
+
+}

src/Parser/CleaningVisitor.php

@@ -0,0 +1,31 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Parser;
+
+use PhpParser\Node;
+use PhpParser\NodeVisitorAbstract;
+
+class CleaningVisitor extends NodeVisitorAbstract
+{
+
+	public function enterNode(Node $node): ?Node
+	{
+		if ($node instanceof Node\Stmt\Function_) {
+			$node->stmts = [];
+			return $node;
+		}
+
+		if ($node instanceof Node\Stmt\ClassMethod) {
+			$node->stmts = [];
+			return $node;
+		}
+
+		if ($node instanceof Node\Expr\Closure) {
+			$node->stmts = [];
+			return $node;
+		}
+
+		return null;
+	}
+
+}

src/Parser/PathRoutingParser.php

@@ -15,6 +15,9 @@ class PathRoutingParser implements Parser
 
 	private Parser $php8Parser;
 
+	/** @var bool[] filePath(string) => bool(true) */
+	private array $analysedFiles = [];
+
 	public function __construct(
 		FileHelper $fileHelper,
 		Parser $currentPhpVersionRichParser,
@@ -28,13 +31,25 @@ public function __construct(
 		$this->php8Parser = $php8Parser;
 	}
 
+	/**
+	 * @param string[] $files
+	 */
+	public function setAnalysedFiles(array $files): void
+	{
+		$this->analysedFiles = array_fill_keys($files, true);
+	}
+
 	public function parseFile(string $file): array
 	{
 		$file = $this->fileHelper->normalizePath($file, '/');
 		if (strpos($file, 'vendor/jetbrains/phpstorm-stubs') !== false) {
 			return $this->php8Parser->parseFile($file);
 		}
 
+		if (!isset($this->analysedFiles[$file])) {
+			return $this->currentPhpVersionSimpleParser->parseFile($file);
+		}
+
 		return $this->currentPhpVersionRichParser->parseFile($file);
 	}
 

src/PhpDoc/StubValidator.php

@@ -89,6 +89,9 @@ public function validate(array $stubFiles, bool $debug): array
 		$nodeScopeResolver = $container->getByType(NodeScopeResolver::class);
 		$nodeScopeResolver->setAnalysedFiles($stubFiles);
 
+		$pathRoutingParser = $container->getService('pathRoutingParser');
+		$pathRoutingParser->setAnalysedFiles($stubFiles);
+
 		$analysedFiles = array_fill_keys($stubFiles, true);
 
 		$errors = [];

src/Reflection/Php/PhpClassReflectionExtension.php

@@ -935,7 +935,7 @@ private function inferAndCachePropertyTypes(
 		}
 
 		$methodNode = $this->findConstructorNode($constructor->getName(), $classNode->stmts);
-		if ($methodNode === null || $methodNode->stmts === null) {
+		if ($methodNode === null || $methodNode->stmts === null || count($methodNode->stmts) === 0) {
 			return $this->propertyTypesCache[$declaringClass->getName()] = [];
 		}
 

src/Reflection/Php/PhpFunctionReflection.php

@@ -170,7 +170,7 @@ private function isVariadic(): bool
 				if ($modifiedTime === false) {
 					$modifiedTime = time();
 				}
-				$variableCacheKey = sprintf('%d-v1', $modifiedTime);
+				$variableCacheKey = sprintf('%d-v2', $modifiedTime);
 				$key = sprintf('variadic-function-%s-%s', $functionName, $fileName);
 				$cachedResult = $this->cache->load($key, $variableCacheKey);
 				if ($cachedResult === null) {

src/Reflection/Php/PhpMethodReflection.php

@@ -274,7 +274,7 @@ private function isVariadic(): bool
 				$modifiedTime = time();
 			}
 			$key = sprintf('variadic-method-%s-%s-%s', $declaringClass->getName(), $this->reflection->getName(), $filename);
-			$variableCacheKey = sprintf('%d-v2', $modifiedTime);
+			$variableCacheKey = sprintf('%d-v3', $modifiedTime);
 			$cachedResult = $this->cache->load($key, $variableCacheKey);
 			if ($cachedResult === null || !is_bool($cachedResult)) {
 				$nodes = $this->parser->parseFile($filename);

src/Testing/TestCase.neon

@@ -4,3 +4,5 @@ services:
 	cacheStorage:
 		class: PHPStan\Cache\MemoryCacheStorage
 		arguments!: []
+	pathRoutingParser!:
+		factory: @currentPhpVersionRichParser