From 614a10bce6dfe68a940359edf25f4866cdbe9a46 Mon Sep 17 00:00:00 2001
From: Kaleb Sitton <kalebsitton@gmail.com>
Date: Thu, 11 Jun 2026 12:53:01 -0500
Subject: [PATCH] fix(ui): add missing "solid" keyword to disclaimer border in
 new UI

The disclaimer warning box set its border as border:1px #003333 -- a shorthand
with width and color but no style keyword. Per the CSS spec, border-style
defaults to "none", so the border never renders. Adding "solid" makes the
intended border visible. This is engine-agnostic (applies to both the on-screen
views and the report/PDF output).

Fixed across the new UI (dojo/templates/):
- Interactive views: view_test.html, form_fields.html, findings_list_snippet.html
- Report templates: custom_html_report.html and the *_pdf_report.html set
  (endpoint, engagement, finding, product, product_endpoint, product_type, test)

Out of scope here (same bug, deliberately separate):
- Classic UI (dojo/templates_classic/) -- being deprecated.
- Email notification templates (.tpl) -- different rendering engine.
---
 dojo/templates/dojo/custom_html_report.html          | 2 +-
 dojo/templates/dojo/endpoint_pdf_report.html         | 2 +-
 dojo/templates/dojo/engagement_pdf_report.html       | 2 +-
 dojo/templates/dojo/finding_pdf_report.html          | 2 +-
 dojo/templates/dojo/findings_list_snippet.html       | 2 +-
 dojo/templates/dojo/form_fields.html                 | 2 +-
 dojo/templates/dojo/product_endpoint_pdf_report.html | 2 +-
 dojo/templates/dojo/product_pdf_report.html          | 2 +-
 dojo/templates/dojo/product_type_pdf_report.html     | 2 +-
 dojo/templates/dojo/test_pdf_report.html             | 2 +-
 dojo/templates/dojo/view_test.html                   | 2 +-
 11 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/dojo/templates/dojo/custom_html_report.html b/dojo/templates/dojo/custom_html_report.html
index aa091eb3ec6..cc14b56cf57 100644
--- a/dojo/templates/dojo/custom_html_report.html
+++ b/dojo/templates/dojo/custom_html_report.html
@@ -5,7 +5,7 @@
     {{ block.super }}
     <div class="container" id="html_report">
         {% if include_disclaimer %}
-            <div style="background-color:#DADCE2; border:1px #003333; padding:.8em; ">
+            <div style="background-color:#DADCE2; border:1px solid #003333; padding:.8em; ">
                 <span style="font-size:16pt;  font-family: 'Cambria','times new roman','garamond',serif; color:#ff0000;">Disclaimer</span><br/>
                 <p style="font-size:11pt; line-height:10pt; font-family: 'Cambria','times roman',serif;">{{ disclaimer | bleach_with_a_tags }}</p>
             </div>
diff --git a/dojo/templates/dojo/endpoint_pdf_report.html b/dojo/templates/dojo/endpoint_pdf_report.html
index f5b18548c17..96d76d0b71f 100644
--- a/dojo/templates/dojo/endpoint_pdf_report.html
+++ b/dojo/templates/dojo/endpoint_pdf_report.html
@@ -79,7 +79,7 @@ <h5>
             </div>
         {% endif %}
         {% if include_disclaimer%}
-            <div style="background-color:#DADCE2; border:1px #003333; padding:.8em; ">
+            <div style="background-color:#DADCE2; border:1px solid #003333; padding:.8em; ">
                 <span style="font-size:16pt;  font-family: 'Cambria','times new roman','garamond',serif; color:#ff0000;">Disclaimer</span><br/>
                 <p style="font-size:11pt; line-height:10pt; font-family: 'Cambria','times roman',serif;">{{ disclaimer | bleach_with_a_tags }}</p>
             </div>
diff --git a/dojo/templates/dojo/engagement_pdf_report.html b/dojo/templates/dojo/engagement_pdf_report.html
index 93f750fe96e..8b0dd906af2 100644
--- a/dojo/templates/dojo/engagement_pdf_report.html
+++ b/dojo/templates/dojo/engagement_pdf_report.html
@@ -158,7 +158,7 @@ <h5>
             </div>
         {% endif %}
         {% if include_disclaimer%}
-            <div style="background-color:#DADCE2; border:1px #003333; padding:.8em; ">
+            <div style="background-color:#DADCE2; border:1px solid #003333; padding:.8em; ">
                 <span style="font-size:16pt;  font-family: 'Cambria','times new roman','garamond',serif; color:#ff0000;">Disclaimer</span><br/>
                 <p style="font-size:11pt; line-height:10pt; font-family: 'Cambria','times roman',serif;">{{ disclaimer | bleach_with_a_tags }}</p>
             </div>
diff --git a/dojo/templates/dojo/finding_pdf_report.html b/dojo/templates/dojo/finding_pdf_report.html
index f4c6a73b216..7035b1c4a61 100644
--- a/dojo/templates/dojo/finding_pdf_report.html
+++ b/dojo/templates/dojo/finding_pdf_report.html
@@ -55,7 +55,7 @@ <h5>
             </div>
         {% endif %}
         {% if include_disclaimer%}
-            <div style="background-color:#DADCE2; border:1px #003333; padding:.8em; ">
+            <div style="background-color:#DADCE2; border:1px solid #003333; padding:.8em; ">
                 <span style="font-size:16pt;  font-family: 'Cambria','times new roman','garamond',serif; color:#ff0000;">Disclaimer</span><br/>
                 <p style="font-size:11pt; line-height:10pt; font-family: 'Cambria','times roman',serif;">{{ disclaimer | bleach_with_a_tags }}</p>
             </div>
diff --git a/dojo/templates/dojo/findings_list_snippet.html b/dojo/templates/dojo/findings_list_snippet.html
index 393d009ab36..eb8d3db7edb 100644
--- a/dojo/templates/dojo/findings_list_snippet.html
+++ b/dojo/templates/dojo/findings_list_snippet.html
@@ -248,7 +248,7 @@ <h3 class="has-filters">
                                         <label style="display: block">{% trans "Tags" %}</label>
                                         {{ bulk_edit_form.tags }}
                                         {% if bulk_edit_form.disclaimer %}
-                                            <div style="background-color:#DADCE2; border:1px #003333; padding:.3em; margin:.1em; ">
+                                            <div style="background-color:#DADCE2; border:1px solid #003333; padding:.3em; margin:.1em; ">
                                                 <div style="color:#ff0000;">Disclaimer</div>
                                                 <div>{{ bulk_edit_form.disclaimer }}</div>
                                             </div>
diff --git a/dojo/templates/dojo/form_fields.html b/dojo/templates/dojo/form_fields.html
index f80fdbb3109..69b3d0b4539 100644
--- a/dojo/templates/dojo/form_fields.html
+++ b/dojo/templates/dojo/form_fields.html
@@ -84,7 +84,7 @@
 {% endfor %}
 
 {% if form.disclaimer %}
-    <div class="form-group" style="background-color:#DADCE2; border:1px #003333; padding:.8em; margin:.8em; ">
+    <div class="form-group" style="background-color:#DADCE2; border:1px solid #003333; padding:.8em; margin:.8em; ">
         <div class="col-sm-2" style="color:#ff0000;">Disclaimer</div>
         <div class="col-sm-10">{{ form.disclaimer }}</div>
     </div>
diff --git a/dojo/templates/dojo/product_endpoint_pdf_report.html b/dojo/templates/dojo/product_endpoint_pdf_report.html
index bd48d09a353..b86e2860267 100644
--- a/dojo/templates/dojo/product_endpoint_pdf_report.html
+++ b/dojo/templates/dojo/product_endpoint_pdf_report.html
@@ -117,7 +117,7 @@ <h5>Finding Age</h5>
             </div>
         {% endif %}
         {% if include_disclaimer%}
-            <div style="background-color:#DADCE2; border:1px #003333; padding:.8em; ">
+            <div style="background-color:#DADCE2; border:1px solid #003333; padding:.8em; ">
                 <span style="font-size:16pt;  font-family: 'Cambria','times new roman','garamond',serif; color:#ff0000;">Disclaimer</span><br/>
                 <p style="font-size:11pt; line-height:10pt; font-family: 'Cambria','times roman',serif;">{{ disclaimer | bleach_with_a_tags }}</p>
             </div>
diff --git a/dojo/templates/dojo/product_pdf_report.html b/dojo/templates/dojo/product_pdf_report.html
index b942187e894..a25e0084192 100644
--- a/dojo/templates/dojo/product_pdf_report.html
+++ b/dojo/templates/dojo/product_pdf_report.html
@@ -140,7 +140,7 @@ <h5>Finding Age</h5>
             </div>
         {% endif %}
         {% if include_disclaimer%}
-            <div style="background-color:#DADCE2; border:1px #003333; padding:.8em; ">
+            <div style="background-color:#DADCE2; border:1px solid #003333; padding:.8em; ">
                 <span style="font-size:16pt;  font-family: 'Cambria','times new roman','garamond',serif; color:#ff0000;">Disclaimer</span><br/>
                 <p style="font-size:11pt; line-height:10pt; font-family: 'Cambria','times roman',serif;">{{ disclaimer | bleach_with_a_tags }}</p>
             </div>
diff --git a/dojo/templates/dojo/product_type_pdf_report.html b/dojo/templates/dojo/product_type_pdf_report.html
index 411c0940cf0..11eeb095e48 100644
--- a/dojo/templates/dojo/product_type_pdf_report.html
+++ b/dojo/templates/dojo/product_type_pdf_report.html
@@ -112,7 +112,7 @@ <h4>
             </div>
         {% endif %}
         {% if include_disclaimer%}
-            <div style="background-color:#DADCE2; border:1px #003333; padding:.8em; ">
+            <div style="background-color:#DADCE2; border:1px solid #003333; padding:.8em; ">
                 <span style="font-size:16pt;  font-family: 'Cambria','times new roman','garamond',serif; color:#ff0000;">Disclaimer</span><br/>
                 <p style="font-size:11pt; line-height:10pt; font-family: 'Cambria','times roman',serif;">{{ disclaimer | bleach_with_a_tags }}</p>
             </div>
diff --git a/dojo/templates/dojo/test_pdf_report.html b/dojo/templates/dojo/test_pdf_report.html
index dbc4b3cdc11..c86684da0c6 100644
--- a/dojo/templates/dojo/test_pdf_report.html
+++ b/dojo/templates/dojo/test_pdf_report.html
@@ -144,7 +144,7 @@ <h5>
             </div>
         {% endif %}
         {% if include_disclaimer%}
-            <div style="background-color:#DADCE2; border:1px #003333; padding:.8em; ">
+            <div style="background-color:#DADCE2; border:1px solid #003333; padding:.8em; ">
                 <span style="font-size:16pt;  font-family: 'Cambria','times new roman','garamond',serif; color:#ff0000;">Disclaimer</span><br/>
                 <p style="font-size:11pt; line-height:10pt; font-family: 'Cambria','times roman',serif;">{{ disclaimer | bleach_with_a_tags }}</p>
             </div>
diff --git a/dojo/templates/dojo/view_test.html b/dojo/templates/dojo/view_test.html
index 761244196a0..1472d6c42e1 100644
--- a/dojo/templates/dojo/view_test.html
+++ b/dojo/templates/dojo/view_test.html
@@ -867,7 +867,7 @@ <h4 class="has-filters">
                                 {{ bulk_edit_form.media.js }}
                                 {{ bulk_edit_form.tags }}
                                 {% if bulk_edit_form.disclaimer %}
-                                    <div style="background-color:#DADCE2; border:1px #003333; padding:.3em; margin:.1em; ">
+                                    <div style="background-color:#DADCE2; border:1px solid #003333; padding:.3em; margin:.1em; ">
                                         <div style="color:#ff0000;">Disclaimer</div>
                                         <div>{{ bulk_edit_form.disclaimer }}</div>
                                     </div>