Fix logic error causing panic storing nil (#15)

johnmaguire · web-flow · commit b7534ee1675d · 2024-06-19T10:38:57.000-04:00
diff --git a/client.go b/client.go
@@ -357,8 +357,9 @@ func (c *Client) streamingPostDNClient(ctx context.Context, reqType string, valu
 			}
 			if err := json.Unmarshal(respBody, &errors); err != nil {
 				sc.err.Store(fmt.Errorf("dnclient endpoint returned bad status code '%d', body: %s", resp.StatusCode, respBody))
+			} else {
+				sc.err.Store(errors.Errors.ToError())
 			}
-			sc.err.Store(errors.Errors.ToError())
 		}
 	}()
 

Original file line number	Diff line number	Diff line change
`@@ -357,8 +357,9 @@ func (c *Client) streamingPostDNClient(ctx context.Context, reqType string, valu`
`357`	`357`	`}`
`358`	`358`	`if err := json.Unmarshal(respBody, &errors); err != nil {`
`359`	`359`	`sc.err.Store(fmt.Errorf("dnclient endpoint returned bad status code '%d', body: %s", resp.StatusCode, respBody))`
	`360`	`+ } else {`
	`361`	`+ sc.err.Store(errors.Errors.ToError())`
`360`	`362`	`}`
`361`		`- sc.err.Store(errors.Errors.ToError())`
`362`	`363`	`}`
`363`	`364`	`}()`
`364`	`365`