Skip to content

Commit d8f168c

Browse files
committed
Fix Windows smoke 14e + soak latency threshold
- Phase 14: copy binary with .exe suffix on Windows (was creating non-.exe copy that uninstall didn't remove) - Phase 14e: check both .exe and non-.exe paths - Soak latency: exclude index_repository from max query latency (indexing 377 files is legitimately slow on Windows/MSYS2)
1 parent 988d975 commit d8f168c

2 files changed

Lines changed: 15 additions & 9 deletions

File tree

scripts/smoke-test.sh

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1024,10 +1024,15 @@ if [ -n "${SMOKE_DOWNLOAD_URL:-}" ]; then
10241024
# ── 14a-f: Real update command against local HTTP server ──
10251025
UPDATE_HOME=$(mktemp -d)
10261026
mkdir -p "$UPDATE_HOME/.claude" "$UPDATE_HOME/.local/bin"
1027-
cp "$BINARY" "$UPDATE_HOME/.local/bin/codebase-memory-mcp"
1028-
chmod 755 "$UPDATE_HOME/.local/bin/codebase-memory-mcp"
1029-
if [ "$(uname -s)" = "Darwin" ]; then
1030-
codesign --sign - --force "$UPDATE_HOME/.local/bin/codebase-memory-mcp" 2>/dev/null || true
1027+
if [[ "$BINARY" == *.exe ]]; then
1028+
cp "$BINARY" "$UPDATE_HOME/.local/bin/codebase-memory-mcp.exe"
1029+
chmod 755 "$UPDATE_HOME/.local/bin/codebase-memory-mcp.exe"
1030+
else
1031+
cp "$BINARY" "$UPDATE_HOME/.local/bin/codebase-memory-mcp"
1032+
chmod 755 "$UPDATE_HOME/.local/bin/codebase-memory-mcp"
1033+
if [ "$(uname -s)" = "Darwin" ]; then
1034+
codesign --sign - --force "$UPDATE_HOME/.local/bin/codebase-memory-mcp" 2>/dev/null || true
1035+
fi
10311036
fi
10321037

10331038
# Pre-install agent config with a WRONG binary path (simulates stale config)
@@ -1079,7 +1084,7 @@ if [ -n "${SMOKE_DOWNLOAD_URL:-}" ]; then
10791084
HOME="$UPDATE_HOME" "$BINARY" uninstall -y 2>&1 || true
10801085

10811086
# 14e: Verify binary removed
1082-
if [ -f "$UPDATE_HOME/.local/bin/codebase-memory-mcp" ]; then
1087+
if [ -f "$UPDATE_HOME/.local/bin/codebase-memory-mcp" ] || [ -f "$UPDATE_HOME/.local/bin/codebase-memory-mcp.exe" ]; then
10831088
echo "FAIL 14e: binary still exists after uninstall"
10841089
exit 1
10851090
fi

scripts/soak-test.sh

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -433,11 +433,12 @@ if [ "${IDLE_INT:-0}" -gt 5 ] 2>/dev/null; then
433433
PASS=false
434434
fi
435435

436-
# Check 4: Max query latency
437-
MAX_LATENCY=$(awk -F, 'NR>1 { if ($3>max) max=$3 } END { print max+0 }' "$LATENCY_CSV")
438-
echo "Max query latency: ${MAX_LATENCY}ms" | tee -a "$SUMMARY"
436+
# Check 4: Max query latency (exclude index_repository — indexing is legitimately slow)
437+
MAX_LATENCY=$(awk -F, 'NR>1 && $2!="index_repository" { if ($3>max) max=$3 } END { print max+0 }' "$LATENCY_CSV")
438+
MAX_INDEX=$(awk -F, 'NR>1 && $2=="index_repository" { if ($3>max) max=$3 } END { print max+0 }' "$LATENCY_CSV")
439+
echo "Max query latency: ${MAX_LATENCY}ms (index: ${MAX_INDEX}ms)" | tee -a "$SUMMARY"
439440
if [ "${MAX_LATENCY:-0}" -gt 10000 ] 2>/dev/null; then
440-
echo "FAIL: max latency ${MAX_LATENCY}ms > 10s" | tee -a "$SUMMARY"
441+
echo "FAIL: max query latency ${MAX_LATENCY}ms > 10s" | tee -a "$SUMMARY"
441442
PASS=false
442443
fi
443444

0 commit comments

Comments
 (0)