reduce telemetry events (exeeds quota)

Author: DonJayamanne

src/client/providers/completionProvider.ts

@@ -49,7 +49,6 @@ export class PythonCompletionItemProvider implements vscode.CompletionItemProvid
 
         const source = document.getText();
         const cmd: proxy.ICommand<proxy.ICommandResult> = {
-            telemetryEvent: telemetryContracts.IDE.Completion,
             command: type,
             fileName: filename,
             columnIndex: columnIndex,

src/client/providers/definitionProvider.ts

@@ -34,7 +34,6 @@ export class PythonDefinitionProvider implements vscode.DefinitionProvider {
         var range = document.getWordRangeAtPosition(position);
         var columnIndex = range.isEmpty ? position.character : range.end.character;
         var cmd: proxy.ICommand<proxy.IDefinitionResult> = {
-            telemetryEvent: telemetryContracts.IDE.Definition,
             command: proxy.CommandType.Definitions,
             fileName: filename,
             columnIndex: columnIndex,

src/client/providers/hoverProvider.ts

@@ -26,7 +26,6 @@ export class PythonHoverProvider implements vscode.HoverProvider {
         }
         var columnIndex = range.start.character < range.end.character ? range.start.character + 2 : range.end.character;
         var cmd: proxy.ICommand<proxy.ICompletionResult> = {
-            telemetryEvent: telemetryContracts.IDE.HoverDefinition,
             command: proxy.CommandType.Completions,
             fileName: filename,
             columnIndex: columnIndex,

src/client/providers/jediProxy.ts

@@ -266,7 +266,7 @@ function spawnProcess(dir: string) {
                 var index = commandQueue.indexOf(cmd.id);
                 commandQueue.splice(index, 1);
 
-                if (cmd.delays) {
+                if (cmd.delays && typeof cmd.telemetryEvent === 'string') {
                     cmd.delays.stop();
                     telemetryHelper.sendTelemetryEvent(cmd.telemetryEvent, null, cmd.delays.toMeasures());
                 }
@@ -396,7 +396,9 @@ function sendCommand<T extends ICommandResult>(cmd: ICommand<T>): Promise<T> {
     var executionCmd = <IExecutionCommand<T>>cmd;
     var payload = createPayload(executionCmd);
     executionCmd.deferred = createDeferred<ICommandResult>();
-    executionCmd.delays = new telemetryHelper.Delays();
+    if (typeof executionCmd.telemetryEvent === 'string') {
+        executionCmd.delays = new telemetryHelper.Delays();
+    }
     try {
         proc.stdin.write(JSON.stringify(payload) + "\n");
         commands.set(executionCmd.id, executionCmd);
@@ -520,7 +522,7 @@ function getConfig() {
 }
 
 export interface ICommand<T extends ICommandResult> {
-    telemetryEvent: string;
+    telemetryEvent?: string;
     command: CommandType;
     source?: string;
     fileName: string;
@@ -532,7 +534,7 @@ interface IExecutionCommand<T extends ICommandResult> extends ICommand<T> {
     id?: number;
     deferred?: Deferred<T>;
     token: vscode.CancellationToken;
-    delays: telemetryHelper.Delays;
+    delays?: telemetryHelper.Delays;
 }
 
 export interface ICommandError {

src/client/providers/lintProvider.ts

@@ -160,10 +160,11 @@ export class LintProvider extends vscode.Disposable {
             if (!linter.isEnabled()) {
                 return Promise.resolve([]);
             }
-            let delays = new telemetryHelper.Delays();
+            // turn off telemetry for linters (at least for now)
+            //let delays = new telemetryHelper.Delays();
             return linter.runLinter(document).then(results => {
-                delays.stop();
-                telemetryHelper.sendTelemetryEvent(telemetryContracts.IDE.Lint, { Lint_Provider: linter.Id }, delays.toMeasures());
+                //delays.stop();
+                //telemetryHelper.sendTelemetryEvent(telemetryContracts.IDE.Lint, { Lint_Provider: linter.Id }, delays.toMeasures());
                 return results;
             });
         });

src/client/providers/referenceProvider.ts

@@ -43,7 +43,6 @@ export class PythonReferenceProvider implements vscode.ReferenceProvider {
         var range = document.getWordRangeAtPosition(position);
         var columnIndex = range.isEmpty ? position.character : range.end.character;
         var cmd: proxy.ICommand<proxy.IReferenceResult> = {
-            telemetryEvent: telemetryContracts.IDE.Reference,
             command: proxy.CommandType.Usages,
             fileName: filename,
             columnIndex: columnIndex,

src/client/providers/signatureProvider.ts

@@ -81,7 +81,6 @@ export class PythonSignatureProvider implements vscode.SignatureHelpProvider {
     }
     provideSignatureHelp(document: TextDocument, position: Position, token: CancellationToken): Thenable<SignatureHelp> {
         let cmd: proxy.ICommand<proxy.IArgumentsResult> = {
-            telemetryEvent: telemetryContracts.IDE.Symbol,
             command: proxy.CommandType.Arguments,
             fileName: document.fileName,
             columnIndex: position.character,

src/client/providers/symbolProvider.ts

@@ -26,7 +26,6 @@ export class PythonSymbolProvider implements vscode.DocumentSymbolProvider {
         var filename = document.fileName;
 
         var cmd: proxy.ICommand<proxy.ISymbolResult> = {
-            telemetryEvent: telemetryContracts.IDE.Symbol,
             command: proxy.CommandType.Symbols,
             fileName: filename,
             columnIndex: 0,