display errors when tests don't run #459

Author: DonJayamanne

src/client/unittests/display/main.ts

@@ -62,6 +62,10 @@ export class TestResultDisplay {
         this.statusBar.text = statusText.length === 0 ? 'No Tests Ran' : statusText.join(' ');
         this.statusBar.color = foreColor;
         this.statusBar.command = constants.Commands.Tests_View_UI;
+
+        if (statusText.length === 0){
+            vscode.window.showWarningMessage('No tests ran, please check the configuration settings for the tests.');
+        }
         return tests;
     }
 
@@ -105,33 +109,31 @@ export class TestResultDisplay {
         this.discoverCounter = 0;
     }
 
-    public DisplayDiscoverStatus(tests: Promise<Tests>, quietMode: boolean = false) {
+    public DisplayDiscoverStatus(tests: Promise<Tests>) {
         this.displayProgress('Discovering Tests', 'Discovering Tests (Click to Stop)', constants.Commands.Tests_Ask_To_Stop_Discovery);
         return tests.then(tests => {
-            this.updateWithDiscoverSuccess(tests, quietMode);
+            this.updateWithDiscoverSuccess(tests);
             return tests;
         }).catch(reason => {
-            this.updateWithDiscoverFailure(reason, quietMode);
+            this.updateWithDiscoverFailure(reason);
             return Promise.reject(reason);
         });
     }
 
-    private updateWithDiscoverSuccess(tests: Tests, quietMode: boolean = false) {
+    private updateWithDiscoverSuccess(tests: Tests) {
         this.clearProgressTicker();
         const haveTests = tests && (tests.testFunctions.length > 0);
         this.statusBar.text = haveTests ? '$(zap) Run Tests' : 'No Tests';
         this.statusBar.tooltip = haveTests ? 'Run Tests' : 'No Tests discovered';
         this.statusBar.command = haveTests ? constants.Commands.Tests_View_UI : constants.Commands.Tests_Discover;
         this.statusBar.show();
 
-        if (!haveTests && !quietMode) {
-            // TODO: show an option that will invoke a command 'python.test.configureTest' or similar
-            // This will be hanlded by main.ts that will capture input from user and configure the tests
-            vscode.window.showInformationMessage('No Tests discovered');
+        if (!haveTests) {
+            vscode.window.showInformationMessage('No tests discovered, please check the configuration settings for the tests.');
         }
     }
 
-    private updateWithDiscoverFailure(reason: any, quietMode: boolean = false) {
+    private updateWithDiscoverFailure(reason: any) {
         this.clearProgressTicker();
         this.statusBar.text = `$(zap) Discover Tests`;
         this.statusBar.tooltip = 'Discover Tests';
@@ -142,10 +144,10 @@ export class TestResultDisplay {
             this.statusBar.text = `$(alert) Test discovery failed`;
             this.statusBar.tooltip = `Discovering Tests failed (view 'Python Test Log' output panel for details)`;
             // TODO: ignore this quitemode, always display the error message (inform the user)
-            if (!isNotInstalledError(reason) && !quietMode) {
+            if (!isNotInstalledError(reason)) {
                 // TODO: show an option that will invoke a command 'python.test.configureTest' or similar
                 // This will be hanlded by main.ts that will capture input from user and configure the tests
-                vscode.window.showErrorMessage('There was an error in discovering tests');
+                vscode.window.showErrorMessage('There was an error in discovering tests, please check the configuration settings for the tests.');
             }
         }
     }

src/client/unittests/main.ts

@@ -27,12 +27,15 @@ export function activate(context: vscode.ExtensionContext, outputChannel: vscode
     outChannel = outputChannel;
     let disposables = registerCommands();
     context.subscriptions.push(...disposables);
-    // Ignore the exceptions returned
-    // This function is invoked via a command which will be invoked else where in the extension
-    discoverTests(true, true).catch(() => {
-        // Ignore the errors
-        let x = '';
-    });
+
+    if (settings.unitTest.nosetestsEnabled || settings.unitTest.pyTestEnabled || settings.unitTest.unittestEnabled) {
+        // Ignore the exceptions returned
+        // This function is invoked via a command which will be invoked else where in the extension
+        discoverTests(true).catch(() => {
+            // Ignore the errors
+        });
+    }
+
     settings.addListener('change', onConfigChanged);
     context.subscriptions.push(activateCodeLenses());
 
@@ -51,10 +54,10 @@ function dispose() {
 }
 function registerCommands(): vscode.Disposable[] {
     const disposables = [];
-    disposables.push(vscode.commands.registerCommand(constants.Commands.Tests_Discover, (quiteMode: boolean) => {
+    disposables.push(vscode.commands.registerCommand(constants.Commands.Tests_Discover, () => {
         // Ignore the exceptions returned
         // This command will be invoked else where in the extension
-        discoverTests(true, quiteMode).catch(() => { return null; });
+        discoverTests(true).catch(() => { return null; });
     }));
     disposables.push(vscode.commands.registerCommand(constants.Commands.Tests_Run_Failed, () => runTestsImpl(true)));
     disposables.push(vscode.commands.registerCommand(constants.Commands.Tests_Run, (testId) => runTestsImpl(testId)));
@@ -149,7 +152,9 @@ function onConfigChanged() {
     }
 
     // No need to display errors
-    discoverTests(true, true);
+    if (settings.unitTest.nosetestsEnabled || settings.unitTest.pyTestEnabled || settings.unitTest.unittestEnabled) {
+        discoverTests(true);
+    }
 }
 function getTestRunner() {
     const rootDirectory = vscode.workspace.rootPath;
@@ -171,18 +176,16 @@ function stopTests() {
         testManager.stop();
     }
 }
-function discoverTests(ignoreCache?: boolean, quietMode: boolean = false) {
+function discoverTests(ignoreCache?: boolean) {
     let testManager = getTestRunner();
     if (!testManager) {
-        if (!quietMode) {
-            displayTestFrameworkError(outChannel);
-        }
+        displayTestFrameworkError(outChannel);
         return Promise.resolve(null);
     }
 
     if (testManager && (testManager.status !== TestStatus.Discovering && testManager.status !== TestStatus.Running)) {
         testResultDisplay = testResultDisplay ? testResultDisplay : new TestResultDisplay(outChannel);
-        return testResultDisplay.DisplayDiscoverStatus(testManager.discoverTests(ignoreCache, quietMode), quietMode);
+        return testResultDisplay.DisplayDiscoverStatus(testManager.discoverTests(ignoreCache));
     }
     else {
         return Promise.resolve(null);