implement pylama like pep8

Author: Thijs Damsma

src/client/common/configSettings.ts

@@ -48,6 +48,8 @@ export interface ILintingSettings {
     pylintArgs: string[];
     pep8Enabled: boolean;
     pep8Args: string[];
+    pylamaEnabled: boolean;
+    pylamaArgs: string[];
     flake8Enabled: boolean;
     flake8Args: string[];
     pydocstyleEnabled: boolean;
@@ -59,6 +61,7 @@ export interface ILintingSettings {
     prospectorPath: string;
     pylintPath: string;
     pep8Path: string;
+    pylamaPath: string;
     flake8Path: string;
     pydocstylePath: string;
     outputWindow: string;
@@ -151,6 +154,7 @@ export class PythonSettings extends EventEmitter implements IPythonSettings {
         this.linting.pylintPath = getAbsolutePath(this.linting.pylintPath, workspaceRoot);
         this.linting.flake8Path = getAbsolutePath(this.linting.flake8Path, workspaceRoot);
         this.linting.pep8Path = getAbsolutePath(this.linting.pep8Path, workspaceRoot);
+        this.linting.pylamaPath = getAbsolutePath(this.linting.pylamaPath, workspaceRoot);
         this.linting.prospectorPath = getAbsolutePath(this.linting.prospectorPath, workspaceRoot);
         this.linting.pydocstylePath = getAbsolutePath(this.linting.pydocstylePath, workspaceRoot);
 

src/client/linters/pylama.ts

@@ -0,0 +1,33 @@
+'use strict';
+
+import * as baseLinter from './baseLinter';
+import {OutputChannel} from 'vscode';
+import { Product } from '../common/installer';
+
+export class Linter extends baseLinter.BaseLinter {
+    constructor(outputChannel: OutputChannel, workspaceRootPath: string) {
+        super('pylama', Product.pylama, outputChannel, workspaceRootPath);
+    }
+
+    public isEnabled(): Boolean {
+        return this.pythonSettings.linting.pylamaEnabled;
+    }
+    public runLinter(filePath: string, txtDocumentLines: string[]): Promise<baseLinter.ILintMessage[]> {
+        if (!this.pythonSettings.linting.pylamaEnabled) {
+            return Promise.resolve([]);
+        }
+
+        let pylamaPath = this.pythonSettings.linting.pylamaPath;
+        let pylamaArgs = Array.isArray(this.pythonSettings.linting.pylamaArgs) ? this.pythonSettings.linting.pylamaArgs : [];
+        return new Promise<baseLinter.ILintMessage[]>(resolve => {
+            this.run(pylamaPath, pylamaArgs.concat(['--format=%(row)d,%(col)d,%(code)s,%(code)s:%(text)s', filePath]), filePath, txtDocumentLines, this.workspaceRootPath).then(messages => {
+                // All messages in pylama are treated as warnings for now
+                messages.forEach(msg => {
+                    msg.severity = baseLinter.LintMessageSeverity.Information;
+                });
+
+                resolve(messages);
+            });
+        });
+    }
+}

src/client/providers/lintProvider.ts

@@ -6,6 +6,7 @@ import * as linter from '../linters/baseLinter';
 import * as prospector from './../linters/prospector';
 import * as pylint from './../linters/pylint';
 import * as pep8 from './../linters/pep8Linter';
+import * as pylama from './../linters/pylama';
 import * as flake8 from './../linters/flake8';
 import * as pydocstyle from './../linters/pydocstyle';
 import * as mypy from './../linters/mypy';
@@ -71,6 +72,7 @@ export class LintProvider extends vscode.Disposable {
         this.linters.push(new prospector.Linter(this.outputChannel, this.workspaceRootPath));
         this.linters.push(new pylint.Linter(this.outputChannel, this.workspaceRootPath));
         this.linters.push(new pep8.Linter(this.outputChannel, this.workspaceRootPath));
+        this.linters.push(new pylama.Linter(this.outputChannel, this.workspaceRootPath));
         this.linters.push(new flake8.Linter(this.outputChannel, this.workspaceRootPath));
         this.linters.push(new pydocstyle.Linter(this.outputChannel, this.workspaceRootPath));
         this.linters.push(new mypy.Linter(this.outputChannel, this.workspaceRootPath));