fixed linter errors

Author: DonJayamanne

src/client/debugger/DebugServers/BaseDebugServer.ts

@@ -1,8 +1,7 @@
 "use strict";
 
-import {DebugSession, OutputEvent} from "vscode-debugadapter";
+import {DebugSession} from "vscode-debugadapter";
 import {IPythonProcess, IDebugServer} from "../Common/Contracts";
-import * as net from "net";
 import {EventEmitter} from "events";
 import {Deferred, createDeferred} from '../../common/helpers';
 
@@ -14,15 +13,15 @@ export abstract class BaseDebugServer extends EventEmitter {
     public get IsRunning(): boolean {
         return this.isRunning;
     }
-    protected debugClientConnected: Deferred<Boolean>;
+    protected debugClientConnected: Deferred<boolean>;
     public get DebugClientConnected(): Promise<boolean> {
         return this.debugClientConnected.promise;
     }
     constructor(debugSession: DebugSession, pythonProcess: IPythonProcess) {
         super();
         this.debugSession = debugSession;
         this.pythonProcess = pythonProcess;
-        this.debugClientConnected = createDeferred<Boolean>();
+        this.debugClientConnected = createDeferred<boolean>();
     }
 
     public abstract Start(): Promise<IDebugServer>;

src/client/debugger/Main.ts

@@ -1,25 +1,19 @@
 "use strict";
 
-import { Variable, DebugSession, InitializedEvent, TerminatedEvent, StoppedEvent, OutputEvent, Thread, StackFrame, Scope, Source, Handles } from "vscode-debugadapter";
+import { DebugSession, InitializedEvent, TerminatedEvent, StoppedEvent, OutputEvent, Thread, StackFrame, Scope, Source, Handles } from "vscode-debugadapter";
 import { ThreadEvent } from "vscode-debugadapter";
 import { DebugProtocol } from "vscode-debugprotocol";
-import { readFileSync } from "fs";
-import { basename } from "path";
 import * as path from "path";
-import * as os from "os";
 import * as fs from "fs";
-import * as child_process from "child_process";
-import * as StringDecoder from "string_decoder";
-import * as net from "net";
 import { PythonProcess } from "./PythonProcess";
-import { FrameKind, IPythonProcess, IPythonThread, IPythonModule, IPythonEvaluationResult, IPythonStackFrame, IDebugServer } from "./Common/Contracts";
+import { IPythonThread, IPythonModule, IPythonEvaluationResult, IPythonStackFrame, IDebugServer } from "./Common/Contracts";
 import { IPythonBreakpoint, PythonBreakpointConditionKind, PythonBreakpointPassCountKind, IPythonException, PythonEvaluationResultReprKind, enum_EXCEPTION_STATE } from "./Common/Contracts";
 import { BaseDebugServer } from "./DebugServers/BaseDebugServer";
-import { DebugClient, DebugType } from "./DebugClients/DebugClient";
+import { DebugClient } from "./DebugClients/DebugClient";
 import { CreateAttachDebugClient, CreateLaunchDebugClient } from "./DebugClients/DebugFactory";
-import { DjangoApp, LaunchRequestArguments, AttachRequestArguments, DebugFlags, DebugOptions, TelemetryEvent, PythonEvaluationResultFlags } from "./Common/Contracts";
+import { LaunchRequestArguments, AttachRequestArguments, DebugOptions, TelemetryEvent, PythonEvaluationResultFlags } from "./Common/Contracts";
 import * as telemetryContracts from "../common/telemetryContracts";
-import { validatePath, validatePathSync, getPythonExecutable } from './Common/Utils';
+import { validatePath, getPythonExecutable } from './Common/Utils';
 import { isNotInstalledError } from '../common/helpers';
 
 const CHILD_ENUMEARATION_TIMEOUT = 5000;
@@ -347,11 +341,10 @@ export class PythonDebugger extends DebugSession {
             }
 
             let breakpoints: { verified: boolean, line: number }[] = [];
-            let breakpointsToRemove = [];
             let linesToAdd = args.breakpoints.map(b => b.line);
             let registeredBks = this.registeredBreakpointsByFileName.get(args.source.path);
             let linesToRemove = registeredBks.map(b => b.LineNo).filter(oldLine => linesToAdd.indexOf(oldLine) === -1);
-            let linesToUpdate = registeredBks.map(b => b.LineNo).filter(oldLine => linesToAdd.indexOf(oldLine) >= 0);
+            // let linesToUpdate = registeredBks.map(b => b.LineNo).filter(oldLine => linesToAdd.indexOf(oldLine) >= 0);
 
             // Always add new breakpoints, don't re-enable previous breakpoints
             // Cuz sometimes some breakpoints get added too early (e.g. in django) and don't get registeredBks

src/client/providers/jediProxy.ts

@@ -340,7 +340,7 @@ function spawnProcess(dir: string) {
                         break;
                     }
                     case CommandType.Hover: {
-                        var defs = <any[]>response['results'];
+                        let defs = <any[]>response['results'];
                         var defResult: IHoverResult = {
                             requestId: cmd.id,
                             items: defs.map(def => {
@@ -358,7 +358,7 @@ function spawnProcess(dir: string) {
                         break;
                     }
                     case CommandType.Symbols: {
-                        var defs = <any[]>response['results'];
+                        let defs = <any[]>response['results'];
                         defs = Array.isArray(defs) ? defs : [];
                         var defResults: ISymbolResult = {
                             requestId: cmd.id,
@@ -441,7 +441,7 @@ function sendCommand<T extends ICommandResult>(cmd: ICommand<T>): Promise<T> {
     }
     var executionCmd = <IExecutionCommand<T>>cmd;
     var payload = createPayload(executionCmd);
-    executionCmd.deferred = createDeferred<ICommandResult>();
+    executionCmd.deferred = createDeferred<T>();
     // if (typeof executionCmd.telemetryEvent === 'string') {
     //     executionCmd.delays = new telemetryHelper.Delays();
     // }

src/client/providers/renameProvider.ts

@@ -46,7 +46,7 @@ export class PythonRenameProvider implements vscode.RenameProvider {
         }).catch(reason => {
             vscode.window.showErrorMessage(reason);
             this.outputChannel.appendLine(reason);
-            return;
+            return Promise.reject(reason);
         });
     }
 }

src/client/unittests/main.ts

@@ -11,7 +11,7 @@ import { TestResultDisplay } from './display/main';
 import { TestDisplay } from './display/picker';
 import * as constants from '../common/constants';
 import { activateCodeLenses } from './codeLenses/main';
-import { displayTestFrameworkError, displayPromptToEnableTests } from './configuration';
+import { displayTestFrameworkError } from './configuration';
 
 const settings = PythonSettings.getInstance();
 let testManager: BaseTestManager;
@@ -155,7 +155,7 @@ function runCurrentTestFile() {
     testManager.discoverTests(true, true).then(() => {
         const tests = getDiscoveredTests();
         const testFiles = tests.testFiles.filter(testFile => {
-            return testFile.fullPath == currentFilePath;
+            return testFile.fullPath === currentFilePath;
         });
         if (testFiles.length < 1) {
             return;
@@ -270,7 +270,7 @@ function isFlattenedTestFunction(arg: any): arg is FlattenedTestFunction {
     return arg && arg.testFunction && typeof arg.xmlClassName === 'string' &&
         arg.parentTestFile && typeof arg.testFunction.name === 'string';
 }
-function identifyTestType(rootDirectory: string, arg?: vscode.Uri | TestsToRun | boolean | FlattenedTestFunction): TestsToRun | Boolean {
+function identifyTestType(rootDirectory: string, arg?: vscode.Uri | TestsToRun | boolean | FlattenedTestFunction): TestsToRun | boolean {
     if (typeof arg === 'boolean') {
         return arg === true;
     }

src/test/extension.refactor.extract.method.test.ts

@@ -5,7 +5,7 @@ import * as assert from 'assert';
 // You can import and use all API from the \'vscode\' module
 // as well as import your extension to test it
 import * as vscode from 'vscode';
-import { TextDocument, TextLine, Position, Range } from 'vscode';
+import { TextLine, Position, Range } from 'vscode';
 import * as path from 'path';
 import * as settings from '../client/common/configSettings';
 import * as fs from 'fs-extra';
@@ -110,7 +110,7 @@ suite('Method Extraction', () => {
         }
         fs.copySync(refactorSourceFile, refactorTargetFile, { clobber: true });
         closeActiveWindows().then(() => {
-            vscode.commands.executeCommand = (cmd) => Promise.resolve();
+            (<any>vscode).commands.executeCommand = (cmd) => Promise.resolve();
             done();
         }).catch(done);
     });

src/test/extension.refactor.extract.var.test.ts

@@ -6,7 +6,7 @@ import * as assert from 'assert';
 // You can import and use all API from the \'vscode\' module
 // as well as import your extension to test it
 import * as vscode from 'vscode';
-import { TextDocument, TextLine, Position, Range } from 'vscode';
+import { TextLine, Position, Range } from 'vscode';
 import * as path from 'path';
 import * as settings from '../client/common/configSettings';
 import * as fs from 'fs-extra';
@@ -110,7 +110,7 @@ suite('Variable Extraction', () => {
         }
         fs.copySync(refactorSourceFile, refactorTargetFile, { clobber: true });
         closeActiveWindows().then(() => {
-            vscode.commands.executeCommand = (cmd) => Promise.resolve();
+            (<any>vscode).commands.executeCommand = (cmd) => Promise.resolve();
             done();
         }).catch(done);
     });