Skip to content

Commit d1abd10

Browse files
authored
Merge pull request #28 from EventAccess/sergeihychko-dev
Add Python linting
2 parents 791a49e + bc51e2c commit d1abd10

5 files changed

Lines changed: 98 additions & 8 deletions

File tree

.git-blame-ignore-revs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
# Autoformat: black
2+
2ee4a7853e7eb55e47653d5f69f271f858a6d3a8
Lines changed: 88 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,88 @@
1+
name: Python
2+
on:
3+
pull_request:
4+
push:
5+
branches:
6+
- dev
7+
jobs:
8+
python-mypy:
9+
name: Mypy
10+
runs-on: ubuntu-latest
11+
permissions:
12+
contents: read
13+
pull-requests: write
14+
15+
steps:
16+
- uses: actions/checkout@v4.2.2
17+
18+
- name: Set up Python
19+
uses: actions/setup-python@v5.3.0
20+
with:
21+
python-version: 3.12
22+
cache: 'pip'
23+
cache-dependency-path: |
24+
**/requirements.txt
25+
**/requirements-*.txt
26+
27+
- name: Install reviewdog
28+
uses: reviewdog/action-setup@v1.3.0
29+
with:
30+
reviewdog_version: latest
31+
32+
- name: Install dependencies
33+
run: pip install -r requirements-dev.txt
34+
35+
- name: Run MyPy
36+
run: |
37+
mypy --output=json \
38+
| jq -Mac '{"message":(.message+"\n"+.hint),"location":{"path":.file,"range":{"start":{"line":.line,"column":.column}}},"severity":.severity|ascii_upcase,"code":{"url":"https://mypy.readthedocs.io/en/stable/error_code_list.html","value":.code}}' \
39+
| reviewdog -f=rdjsonl -reporter=github-check -name mypy -fail-level warning -filter-mode nofilter
40+
env:
41+
REVIEWDOG_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }}
42+
43+
python-black:
44+
name: Black
45+
runs-on: ubuntu-latest
46+
permissions:
47+
contents: read
48+
pull-requests: write
49+
50+
steps:
51+
- uses: actions/checkout@v4.2.2
52+
53+
- name: Set up Python
54+
uses: actions/setup-python@v5.3.0
55+
with:
56+
python-version: 3.12
57+
cache: 'pip'
58+
cache-dependency-path: |
59+
**/requirements.txt
60+
**/requirements-*.txt
61+
62+
- name: Install reviewdog
63+
uses: reviewdog/action-setup@v1.3.0
64+
with:
65+
reviewdog_version: v0.20.1
66+
67+
- name: Install dependencies
68+
run: pip install -r requirements-dev.txt
69+
70+
- name: Run Black
71+
if: github.event_name == 'pull_request'
72+
uses: reviewdog/action-black@v3.22.2
73+
with:
74+
reporter: github-pr-review
75+
tool_name: black
76+
level: warning
77+
fail_on_error: true
78+
filter_mode: nofilter
79+
80+
- name: Run Black
81+
if: github.event_name == 'push'
82+
uses: reviewdog/action-black@v3.22.2
83+
with:
84+
reporter: github-check
85+
tool_name: black
86+
level: warning
87+
fail_on_error: true
88+
filter_mode: nofilter

backendapi/admin.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
@admin.register(Attendant)
77
class AttendantAdmin(admin.ModelAdmin):
8-
list_display = ('ticket_id', 'nfc_id_decoded', 'discord', 'is_crew', 'is_valid')
8+
list_display = ("ticket_id", "nfc_id_decoded", "discord", "is_crew", "is_valid")
99

1010
def nfc_id_decoded(self, obj):
1111
return b16encode(obj.nfc_id).decode()

backendapi/urls.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,6 @@
77
urlpatterns = [
88
path("nfctag/<hex:tag>", views.scanned),
99
path("test", views.api_get, name="api_get"),
10-
path("tickets/verify/<slug:ticket>",
11-
views.verify_ticket,
12-
name="verify_ticket"),
13-
path("attendants", views.create_attendant, name="create_attendant")
10+
path("tickets/verify/<slug:ticket>", views.verify_ticket, name="verify_ticket"),
11+
path("attendants", views.create_attendant, name="create_attendant"),
1412
]

backendapi/views.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,12 +34,14 @@ def api_get(request):
3434
@api_view(["GET"])
3535
def verify_ticket(request, ticket):
3636
# TODO: Implement ticket check
37-
if ticket == 'test123':
37+
if ticket == "test123":
3838
return Response(
39-
{"is_valid": True}, status=status.HTTP_200_OK,
39+
{"is_valid": True},
40+
status=status.HTTP_200_OK,
4041
)
4142
return Response(
42-
{"is_valid": False}, status=status.HTTP_400_BAD_REQUEST,
43+
{"is_valid": False},
44+
status=status.HTTP_400_BAD_REQUEST,
4345
)
4446

4547

0 commit comments

Comments
 (0)